Received: by 2002:ac0:946b:0:0:0:0:0 with SMTP id j40csp182319imj; Fri, 8 Feb 2019 17:48:39 -0800 (PST) X-Google-Smtp-Source: AHgI3IYwheRcysArhYelctd/Je7AxPu7/vE1IH23BiWRhqf5yxqJHOUzRnVkZYai2Tr37itvBsAT X-Received: by 2002:a17:902:b494:: with SMTP id y20mr26599977plr.178.1549676919879; Fri, 08 Feb 2019 17:48:39 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1549676919; cv=none; d=google.com; s=arc-20160816; b=D2vutyTFIDW95KsXEnVuGLhQGS2odP7n4tddW7v7hY6DRwASyDirRFBrFWEJOsYcg2 4cmqa6oEfUmxI9TNtr+ilDkEAuH8KKoL1DEbH0ZAW18uImGuS4rV6cKrAMLZ7cEL7/64 bcJc87IY4LKkvRs99AjQYJqQNbfB79MKa3QswTOX/0zhdamqlGJO8Gpr+9v1kEPLIRZ9 0w+JLzj8qUBU4viRUcsGYOBJvakyFsdqqBTjfx9t3gtF3DfLrGY1xbGvFtdrM9hizJUf hGEdabuB+SoN0QIx10YppCRZjCTlJJa9G/gt/bwTwgueob3CEIDzTkK5f5hqSh8lGXm8 PYYA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:references:in-reply-to:message-id:date :subject:cc:to:from:dkim-signature; bh=+GiavFYmZpYMitroMq7xO+5Ht+hTs+Up5dnwk5QqqHQ=; b=sPLArLDkk+us0q8mw3Zv4Jg2icW0rSrDerhOX71TuR5ztPR4RDhZHFmVtSnpgcy+Qk 0Knk5Nl1OBP/sJQY+Hzvd3ggEke380mmpf2YjZI1bcGjLENveBF83n6iT5M6osoErEBM SU+fCRUhfd5oGpKDeGs2/RkqYdnxttIeGdN8IBnIwNQvA0L/tN/PjL517hRpS/+m9O8Y holPNhyZgZKIhKQoNCwkjFJCkuvnCO7ICZQKVfB7+l8CLheSiNP5ssNaIeQAzxfjMtNt HUVKW4LopUwWRnddTJjs5NKJWhlSzaCZ6Sdw3PIpXOvepVcQwEfNFwJsjyGWtD+oro2E UDgQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@gmail.com header.s=20161025 header.b=NezphF+Y; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id v35si4321542pgl.130.2019.02.08.17.48.24; Fri, 08 Feb 2019 17:48:39 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@gmail.com header.s=20161025 header.b=NezphF+Y; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727057AbfBIBsM (ORCPT + 99 others); Fri, 8 Feb 2019 20:48:12 -0500 Received: from mail-pl1-f195.google.com ([209.85.214.195]:46323 "EHLO mail-pl1-f195.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726969AbfBIBsD (ORCPT ); Fri, 8 Feb 2019 20:48:03 -0500 Received: by mail-pl1-f195.google.com with SMTP id o6so2501685pls.13; Fri, 08 Feb 2019 17:48:03 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=+GiavFYmZpYMitroMq7xO+5Ht+hTs+Up5dnwk5QqqHQ=; b=NezphF+Yq9MJuAS92CD13Si1d4BqyBJ4MEo91tRfAmi6bSP5XqNDMbnilvvvRkQudZ 6ywm7tTmtDTDIKlovpkdgbQ+b02BXr/1WvX3f9lP0jgPCKEuVbU+NBxxBgvpBkTaVbFv pU34aI9BYgngXIdDQ8XBgKharG0RqtsKzNpTxNzTU4Ny402VOQ/25tpMDxs4s1rWQ6Z1 6n3kF9T36bHkDgfe9qtyY548+8S538mQGz8FHVWJnFWXGLFTabDDUOsxPy+uxBwqOY7K lgVyigggKL0lSxIGHEBGjfGBTJ+r3uNUEH4i0jNu469LqmWvCfn+UvznBaJtOW7RlflT XtEQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=+GiavFYmZpYMitroMq7xO+5Ht+hTs+Up5dnwk5QqqHQ=; b=MydMVMI3wTV99u4qIpxT781fF3SY4Lr056JENWktqCUsXcqRXUxJRkQVg2wdN22A+H 0QeF6fX3QCnO6eneDNZtA0pKoFrXwSSQOuFmSiU1Hao4EryKesd6beAPjjdHRC/nSyAA AiDWz88NGxwFIF/+TIOOYzJNU2C75KFt3NhJeZkICZrGMqZwZH2y2oyg8eq0gOkE7Fef ioh/CDh5oRQ006DyATahEN+vgSsg4U/JdBI9DWyvFxJKTvCpctCw+P5juQsUxjGTRLo+ ThGJqAmf6+95tyYM2/VqrnquwN6a93jh3cLVQCicP/SgL4sBRViRb2rdHMKA9kc0aiqu gzcA== X-Gm-Message-State: AHQUAuaw6LWmvJhSfEgmvI3zMtobIrSKATX8YPHpw1SFZV3GS/XyjeQT FCLYOMJC3mgZ2cYDcqqIzayI5rP4 X-Received: by 2002:a17:902:be03:: with SMTP id r3mr25383129pls.68.1549676882664; Fri, 08 Feb 2019 17:48:02 -0800 (PST) Received: from majic.sklembedded.com (c-73-202-231-77.hsd1.ca.comcast.net. [73.202.231.77]) by smtp.googlemail.com with ESMTPSA id p67sm4305393pfg.44.2019.02.08.17.48.01 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Fri, 08 Feb 2019 17:48:01 -0800 (PST) From: Steve Longerbeam To: linux-media@vger.kernel.org Cc: Tim Harvey , Steve Longerbeam , Philipp Zabel , Mauro Carvalho Chehab , Greg Kroah-Hartman , devel@driverdev.osuosl.org (open list:STAGING SUBSYSTEM), linux-kernel@vger.kernel.org (open list) Subject: [PATCH v4 4/4] media: imx: Allow BT.709 encoding for IC routes Date: Fri, 8 Feb 2019 17:47:48 -0800 Message-Id: <20190209014748.10427-5-slongerbeam@gmail.com> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20190209014748.10427-1-slongerbeam@gmail.com> References: <20190209014748.10427-1-slongerbeam@gmail.com> Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org The IC now supports BT.709 Y'CbCr encoding, in addition to existing BT.601 encoding, so allow both, for pipelines that route through the IC. Reported-by: Tim Harvey Signed-off-by: Steve Longerbeam --- Changes in v2: - move ic_route check above default colorimetry checks, and fill default colorimetry for ic_route, otherwise it's not possible to set BT.709 encoding for ic routes. --- drivers/staging/media/imx/imx-media-utils.c | 20 +++++++++++++------- 1 file changed, 13 insertions(+), 7 deletions(-) diff --git a/drivers/staging/media/imx/imx-media-utils.c b/drivers/staging/media/imx/imx-media-utils.c index 5f110d90a4ef..dde0e47550d7 100644 --- a/drivers/staging/media/imx/imx-media-utils.c +++ b/drivers/staging/media/imx/imx-media-utils.c @@ -544,6 +544,19 @@ void imx_media_fill_default_mbus_fields(struct v4l2_mbus_framefmt *tryfmt, if (tryfmt->field == V4L2_FIELD_ANY) tryfmt->field = fmt->field; + if (ic_route) { + if (tryfmt->colorspace == V4L2_COLORSPACE_DEFAULT) + tryfmt->colorspace = fmt->colorspace; + + tryfmt->quantization = is_rgb ? + V4L2_QUANTIZATION_FULL_RANGE : + V4L2_QUANTIZATION_LIM_RANGE; + + if (tryfmt->ycbcr_enc != V4L2_YCBCR_ENC_601 && + tryfmt->ycbcr_enc != V4L2_YCBCR_ENC_709) + tryfmt->ycbcr_enc = V4L2_YCBCR_ENC_601; + } + /* fill colorimetry if necessary */ if (tryfmt->colorspace == V4L2_COLORSPACE_DEFAULT) { tryfmt->colorspace = fmt->colorspace; @@ -566,13 +579,6 @@ void imx_media_fill_default_mbus_fields(struct v4l2_mbus_framefmt *tryfmt, tryfmt->ycbcr_enc); } } - - if (ic_route) { - tryfmt->quantization = is_rgb ? - V4L2_QUANTIZATION_FULL_RANGE : - V4L2_QUANTIZATION_LIM_RANGE; - tryfmt->ycbcr_enc = V4L2_YCBCR_ENC_601; - } } EXPORT_SYMBOL_GPL(imx_media_fill_default_mbus_fields); -- 2.17.1