Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Subject: Re: [PATCH] watchdog/hpwdt: Update Kconfig documentation
To:     Jerry Hoemann <jerry.hoemann@hpe.com>, wim@linux-watchdog.org
Cc:     linux-watchdog@vger.kernel.org, linux-kernel@vger.kernel.org
References: <1549648083-9501-1-git-send-email-jerry.hoemann@hpe.com>
From:   Guenter Roeck <linux@roeck-us.net>
Message-ID: <a20685a2-1f30-5088-7ad5-fe4d590e3a37@roeck-us.net>
Date:   Fri, 8 Feb 2019 21:10:51 -0800
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101
 Thunderbird/60.2.1
MIME-Version: 1.0
In-Reply-To: <1549648083-9501-1-git-send-email-jerry.hoemann@hpe.com>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Language: en-US
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On 2/8/19 9:48 AM, Jerry Hoemann wrote:
> Update documentation relating to HPWDT_NMI_DECODING to reflect its
> current usage.
> 
> Signed-off-by: Jerry Hoemann <jerry.hoemann@hpe.com>

Reviewed-by: Guenter Roeck <linux@roeck-us.net>

> ---
>   drivers/watchdog/Kconfig | 9 +++++----
>   1 file changed, 5 insertions(+), 4 deletions(-)
> 
> diff --git a/drivers/watchdog/Kconfig b/drivers/watchdog/Kconfig
> index 57f017d..846dd07 100644
> --- a/drivers/watchdog/Kconfig
> +++ b/drivers/watchdog/Kconfig
> @@ -1145,7 +1145,7 @@ config HP_WATCHDOG
>   	select WATCHDOG_CORE
>   	depends on X86 && PCI
>   	help
> -	  A software monitoring watchdog and NMI sourcing driver. This driver
> +	  A software monitoring watchdog and NMI handling driver. This driver
>   	  will detect lockups and provide a stack trace. This is a driver that
>   	  will only load on an HP ProLiant system with a minimum of iLO2 support.
>   	  To compile this driver as a module, choose M here: the module will be
> @@ -1163,12 +1163,13 @@ config KEMPLD_WDT
>   	  called kempld_wdt.
>   
>   config HPWDT_NMI_DECODING
> -	bool "NMI decoding support for the HP ProLiant iLO2+ Hardware Watchdog Timer"
> +	bool "NMI support for the HP ProLiant iLO2+ Hardware Watchdog Timer"
>   	depends on HP_WATCHDOG
>   	default y
>   	help
> -	  When an NMI occurs this feature will make the necessary BIOS calls to
> -	  log the cause of the NMI.
> +	  Enables the NMI handler for the watchdog pretimeout NMI and the iLO
> +	  "Generate NMI to System" virtual button.  When an NMI is claimed
> +	  by the driver, panic is called.
>   
>   config SC1200_WDT
>   	tristate "National Semiconductor PC87307/PC97307 (ala SC1200) Watchdog"
>