Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
From:   "Tokunori Ikegami" <ikegami.t@gmail.com>
To:     "'Gustavo A. R. Silva'" <gustavo@embeddedor.com>,
        "'David Woodhouse'" <dwmw2@infradead.org>,
        "'Brian Norris'" <computersforpeace@gmail.com>,
        "'Boris Brezillon'" <bbrezillon@kernel.org>,
        "'Marek Vasut'" <marek.vasut@gmail.com>,
        "'Richard Weinberger'" <richard@nod.at>
Cc:     <linux-mtd@lists.infradead.org>, <linux-kernel@vger.kernel.org>
References: <20190208180615.GA24601@embeddedor>
In-Reply-To: <20190208180615.GA24601@embeddedor>
Subject: RE: [PATCH] mtd: cfi_cmdset_0002: Mark expected switch fall-throughs
Date:   Sat, 9 Feb 2019 17:29:46 +0900
Message-ID: <000001d4c051$9f66deb0$de349c10$@gmail.com>
MIME-Version: 1.0
Content-Type: text/plain;
        charset="utf-8"
Content-Transfer-Encoding: quoted-printable
Thread-Index: AQLfvGHS4rj+Sm6xb7HCdJOPFYC+/aPBKgyA
Content-Language: ja
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

Reviewed-by: Tokunori Ikegami <ikegami.t@gmail.com>

> -----Original Message-----
> From: linux-mtd [mailto:linux-mtd-bounces@lists.infradead.org] On =
Behalf
> Of Gustavo A. R. Silva
> Sent: Saturday, February 9, 2019 3:06 AM
> To: David Woodhouse; Brian Norris; Boris Brezillon; Marek Vasut; =
Richard
> Weinberger
> Cc: linux-mtd@lists.infradead.org; linux-kernel@vger.kernel.org; =
Gustavo
> A. R. Silva
> Subject: [PATCH] mtd: cfi_cmdset_0002: Mark expected switch =
fall-throughs
>=20
> In preparation to enabling -Wimplicit-fallthrough, mark switch
> cases where we are expecting to fall through.
>=20
> This patch fixes the following warnings:
>=20
> drivers/mtd/chips/cfi_cmdset_0002.c: In function =
=E2=80=98get_chip=E2=80=99:
> drivers/mtd/chips/cfi_cmdset_0002.c:870:6: warning: this statement may
> fall through [-Wimplicit-fallthrough=3D]
>    if (mode =3D=3D FL_READY && chip->oldstate =3D=3D FL_READY)
>       ^
> drivers/mtd/chips/cfi_cmdset_0002.c:873:2: note: here
>   default:
>   ^~~~~~~
> drivers/mtd/chips/cfi_cmdset_0002.c: In function =
=E2=80=98cfi_amdstd_sync=E2=80=99:
> drivers/mtd/chips/cfi_cmdset_0002.c:2745:16: warning: this statement =
may
> fall through [-Wimplicit-fallthrough=3D]
>     chip->state =3D FL_SYNCING;
>     ~~~~~~~~~~~~^~~~~~~~~~~~
> drivers/mtd/chips/cfi_cmdset_0002.c:2750:3: note: here
>    case FL_SYNCING:
>    ^~~~
>=20
> Warning level 3 was used: -Wimplicit-fallthrough=3D3
>=20
> This patch is part of the ongoing efforts to enabling
> -Wimplicit-fallthrough.
>=20
> Signed-off-by: Gustavo A. R. Silva <gustavo@embeddedor.com>
> ---
>  drivers/mtd/chips/cfi_cmdset_0002.c | 2 ++
>  1 file changed, 2 insertions(+)
>=20
> diff --git a/drivers/mtd/chips/cfi_cmdset_0002.c
> b/drivers/mtd/chips/cfi_cmdset_0002.c
> index 72428b6bfc47..0b0a1874d3bf 100644
> --- a/drivers/mtd/chips/cfi_cmdset_0002.c
> +++ b/drivers/mtd/chips/cfi_cmdset_0002.c
> @@ -869,6 +869,7 @@ static int get_chip(struct map_info *map, struct =
flchip
> *chip, unsigned long adr
>  		/* Only if there's no operation suspended... */
>  		if (mode =3D=3D FL_READY && chip->oldstate =3D=3D FL_READY)
>  			return 0;
> +		/* fall through */
>=20
>  	default:
>  	sleep:
> @@ -2747,6 +2748,7 @@ static void cfi_amdstd_sync (struct mtd_info =
*mtd)
>  			 * as the whole point is that nobody can do anything
>  			 * with the chip now anyway.
>  			 */
> +			/* fall through */
>  		case FL_SYNCING:
>  			mutex_unlock(&chip->mutex);
>  			break;
> --
> 2.20.1
>=20
>=20
> ______________________________________________________
> Linux MTD discussion mailing list
> http://lists.infradead.org/mailman/listinfo/linux-mtd/