Received: by 2002:ac0:946b:0:0:0:0:0 with SMTP id j40csp1202536imj; Sat, 9 Feb 2019 19:02:51 -0800 (PST) X-Google-Smtp-Source: AHgI3IZckWIi9PkqVW6opUjIFDzUlsHTgVgNppnBhPTPA5RPMwXEimbBMWZP/atlNKqOLpkb934h X-Received: by 2002:a17:902:a50a:: with SMTP id s10mr29713509plq.278.1549767771837; Sat, 09 Feb 2019 19:02:51 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1549767771; cv=none; d=google.com; s=arc-20160816; b=ZeYTqFlnLXYjnA6ldwyn+ccqdckTgEfxUe/KMvQSqRNPTcWiLmA6Oz1eJstFMhz+Uy G92EewvmFKGIYmXHiMBFV1uJ0KeA4+G6bru7kbaDUY/h0/lkYKOMx2nwQ7q0FAuy4IcO ywL3KsOtZEEMhlo3HdTpbE1ulNv1oMBu0vNCPCwjBc3A8HJHyPP9GJPYpFs3gfEnfmBt LvfXeGu/cdAJ8DS+YY8PUgpMoKEIJJGBFO/H5oJ9d/4IzMKabMk5dJygbKRv1pxJt0pY VbvUv2BHPItGfs9Sia0zpF1/uX4S5wxkaAIp45EHJWDNCLJ5xzADA+iDzZ+F+cSoPRuS nwEg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :references:in-reply-to:from:subject:cc:to:message-id:date; bh=DT6MIuXbzWYvqxiGZOYMxWf6LOETqnZJ8B1lzHVrrB4=; b=OIWBu6zHD0SonNxVcIXzxG8gYnLZEHK72jSvU83Ae/zhX2bXi2LWF3OyV1wuDIOvcN W35wPa5KJIrdN86VIAZ6HCktrZK5qzbkKfugtN4yuciionBB9kwl0NfgPsb1w59q07QN MM0YCqKDXTXdI+lLxoN9NElH/vBcb+qH4gpMiF4HId2LZhvi4PSkXvhvI8mxE0HC74Pn X3HbJv3q/JBeawwUCLDdsN18UsOmQxdoN/A0R84QUS5vPxeKWZto4ERYNSHhU2qZPyEi y3iUpW98514oPnoCIhkNRbRVBc22KC2BJtWLyyMqmBY/3P3UbYAeBHfRomrEtatUIS8W 7QQw== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id t61si7018895plb.339.2019.02.09.19.02.35; Sat, 09 Feb 2019 19:02:51 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726930AbfBJDBQ (ORCPT + 99 others); Sat, 9 Feb 2019 22:01:16 -0500 Received: from shards.monkeyblade.net ([23.128.96.9]:51242 "EHLO shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726524AbfBJDBP (ORCPT ); Sat, 9 Feb 2019 22:01:15 -0500 Received: from localhost (unknown [IPv6:2601:601:9f80:35cd::bf5]) (using TLSv1 with cipher AES256-SHA (256/256 bits)) (Client did not present a certificate) (Authenticated sender: davem-davemloft) by shards.monkeyblade.net (Postfix) with ESMTPSA id CED4814B545F4; Sat, 9 Feb 2019 19:01:14 -0800 (PST) Date: Sat, 09 Feb 2019 19:01:14 -0800 (PST) Message-Id: <20190209.190114.542890373094719579.davem@davemloft.net> To: kal.conley@dectris.com Cc: willemb@google.com, edumazet@google.com, gregkh@linuxfoundation.org, jeffrey.t.kirsher@intel.com, alexander.h.duyck@intel.com, ktkhai@virtuozzo.com, vincent.whitchurch@axis.com, lirongqing@baidu.com, magnus.karlsson@intel.com, netdev@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] net/packet: fix 4gb buffer limit due to overflow check From: David Miller In-Reply-To: <20190209203701.27252-1-kal.conley@dectris.com> References: <20190209203701.27252-1-kal.conley@dectris.com> X-Mailer: Mew version 6.8 on Emacs 26.1 Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.5.12 (shards.monkeyblade.net [149.20.54.216]); Sat, 09 Feb 2019 19:01:15 -0800 (PST) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Kal Conley Date: Sat, 9 Feb 2019 21:37:00 +0100 > When calculating rb->frames_per_block * req->tp_block_nr the result > can overflow. Check it for overflow without limiting the total buffer > size to UINT_MAX. > > This change fixes support for packet ring buffers >= UINT_MAX. Please resubmit with a proper signoff and also an appropriate Fixes: tag.