Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Date:   Sun, 10 Feb 2019 10:39:07 -0200
From:   Rodrigo Siqueira <rodrigosiqueiramelo@gmail.com>
To:     Shayenne Moura <shayenneluzmoura@gmail.com>
Cc:     Haneen Mohammed <hamohammed.sa@gmail.com>,
        Daniel Vetter <daniel@ffwll.ch>,
        David Airlie <airlied@linux.ie>,
        dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] drm/vkms: WARN when hrtimer_forward_now fails
Message-ID: <20190210123907.cbfcq6lgjooskpii@smtp.gmail.com>
References: <20190206200813.d5w7gjpepoeeadiy@smtp.gmail.com>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha512;
        protocol="application/pgp-signature"; boundary="cgncsaslrioffxe7"
Content-Disposition: inline
In-Reply-To: <20190206200813.d5w7gjpepoeeadiy@smtp.gmail.com>
User-Agent: NeoMutt/20180716
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk


--cgncsaslrioffxe7
Content-Type: text/plain; charset=iso-8859-1
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On 02/06, Shayenne Moura wrote:
> Make the variable have the same type of function hrtimer_forward_now
> return.

Hi,

First of all, thanks for your patch.

Applied to the drm-misc-misc branch of drm-misc.git.

P.s.: I made a tiny change in the commit message.

Best Regards

> Add a warn to verify the hrtimer_forward_now return.
>=20
> Signed-off-by: Shayenne Moura <shayenneluzmoura@gmail.com>
> ---
>  drivers/gpu/drm/vkms/vkms_crtc.c | 4 +++-
>  1 file changed, 3 insertions(+), 1 deletion(-)
>=20
> diff --git a/drivers/gpu/drm/vkms/vkms_crtc.c b/drivers/gpu/drm/vkms/vkms=
_crtc.c
> index 5a095610726b..734a3e197df8 100644
> --- a/drivers/gpu/drm/vkms/vkms_crtc.c
> +++ b/drivers/gpu/drm/vkms/vkms_crtc.c
> @@ -16,7 +16,7 @@ static enum hrtimer_restart vkms_vblank_simulate(struct=
 hrtimer *timer)
>  						  vblank_hrtimer);
>  	struct drm_crtc *crtc =3D &output->crtc;
>  	struct vkms_crtc_state *state =3D to_vkms_crtc_state(crtc->state);
> -	int ret_overrun;
> +	u64 ret_overrun;
>  	bool ret;
> =20
>  	spin_lock(&output->lock);
> @@ -43,6 +43,8 @@ static enum hrtimer_restart vkms_vblank_simulate(struct=
 hrtimer *timer)
> =20
>  	ret_overrun =3D hrtimer_forward_now(&output->vblank_hrtimer,
>  					  output->period_ns);
> +	WARN_ON(ret_overrun !=3D 1);
> +
>  	spin_unlock(&output->lock);
> =20
>  	return HRTIMER_RESTART;
> --=20
> 2.17.1
>=20

--=20
Rodrigo Siqueira
https://siqueira.tech
Graduate Student
Department of Computer Science
University of S=E3o Paulo

--cgncsaslrioffxe7
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQIzBAEBCgAdFiEE4tZ+ii1mjMCMQbfkWJzP/comvP8FAlxgG2sACgkQWJzP/com
vP+wKhAAiH7LM5ey6eeUgSJLqWlv43ZD/csJStQFXFWxN4CEPY8PQi6FudKsERqv
UbBlXs2jM5XknwwWP35QfDjNOJJVQ0J9ROZl2jjd9Ub/u6MwQHbVeSBfuaNiz4vY
vXeRLHpb5xIRxFSynTgMIZwSatIeCV/oZFR3k61tTa9wClJ9mEPdzNyOGLVuUG77
96eo1ZtaMvL/zbbLTH5EgbmOBV+OL3CSpp8eiykpWD0qZC+lP7dHTWQnn4VIjoTA
0ZqI9DSUGudJXwawHzDeFCvdfgHK8SecMEd4Zmu4XqT3l5tA0P+QJojGGtEnhteR
JKzUWk7BK/EskeXeSaRNQ4wSlA+/Vabp3W8xXyQr8pczSdIVGmjkqYQPnCbKkS85
V7g7ECC9z0vgXqYIzlMRkvg6KlfLzs5XXTQ6MQOzu2y25CeHnBdg6s42Nr8nfFpx
E4tLB77Fr5zgcdGx6pJWVSuHkhazQapLz/3fPpduV9+zvvgbvPlRJQaVd/Q0FNg7
ueIr5NbgHBSp/9LjDgtxCf8Y3cN03j3HLih+h65xjN6Kqhs4d1JUHxW1M4T4/yyb
Emb4sdZR/Ur1toqHHCUX3OlG82H1gJtZT221TuVRbp8V3h6SqjVWu0t7zcBAdyx3
QGOGM+Ntxsl+AEksjyarnp2rdeIv8W0P/FRNYpIHGbbAjOY+QfM=
=M3yK
-----END PGP SIGNATURE-----

--cgncsaslrioffxe7--