Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S262708AbUCJQqX (ORCPT ); Wed, 10 Mar 2004 11:46:23 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S262711AbUCJQqX (ORCPT ); Wed, 10 Mar 2004 11:46:23 -0500 Received: from phoenix.infradead.org ([213.86.99.234]:1807 "EHLO phoenix.infradead.org") by vger.kernel.org with ESMTP id S262708AbUCJQqW (ORCPT ); Wed, 10 Mar 2004 11:46:22 -0500 Date: Wed, 10 Mar 2004 16:46:17 +0000 From: Christoph Hellwig To: Bartlomiej Zolnierkiewicz Cc: Thomas Horsten , andre@linux-ide.org, arjanv@redhat.com, linux-kernel@vger.kernel.org Subject: Re: [PATCH] 2.4.x Linux Medley RAID Version 7 Message-ID: <20040310164617.A24567@infradead.org> Mail-Followup-To: Christoph Hellwig , Bartlomiej Zolnierkiewicz , Thomas Horsten , andre@linux-ide.org, arjanv@redhat.com, linux-kernel@vger.kernel.org References: <200403101707.38595.bzolnier@elka.pw.edu.pl> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline User-Agent: Mutt/1.2.5.1i In-Reply-To: <200403101707.38595.bzolnier@elka.pw.edu.pl>; from B.Zolnierkiewicz@elka.pw.edu.pl on Wed, Mar 10, 2004 at 05:07:38PM +0100 Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 504 Lines: 16 On Wed, Mar 10, 2004 at 05:07:38PM +0100, Bartlomiej Zolnierkiewicz wrote: > + if (!inode || !inode->i_rdev) > + { > + return -EINVAL; > + } > > if (!inode || !inode->i_rdev) > return -EINVAL; Actually it should just go away. The check is totally bogus. - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/