Received: by 2002:ac0:946b:0:0:0:0:0 with SMTP id j40csp1840887imj; Sun, 10 Feb 2019 11:34:48 -0800 (PST) X-Google-Smtp-Source: AHgI3IZbTDilNvuhvaY9TaJWsYvk0sLoC2w+KBjIm1nu+Gb1AGw2dQ9EnJKTEUuerCdBYenSsv7W X-Received: by 2002:a17:902:bc3:: with SMTP id 61mr34300234plr.15.1549827288137; Sun, 10 Feb 2019 11:34:48 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1549827288; cv=none; d=google.com; s=arc-20160816; b=FzI+wUiiTb8+YrxY/EJ87bguWpYqCfUZlXE7iklzoi/WAf8RGQCTfFmxoavMjzyhYm x1/RxEU788ZRwJPWKjwVN+JgGFSPWPklXmlFjWluAM86gp4A7NZEKaTLadEXRNyU3gJO K1G/aJVbi+1+2xuBBQzRkvXHT/BuJlV1nykyLRI4bnZbOOCrZ4lhdggPbZwEoAIGEa/i kKVbx/RB5z8Mc+AiFYqhJhSjGkgHL+d2mKp6LtMZWgdSHUfK3gu5DYT/2veM+gXsbjK2 kDIqqyvZ/UC7MCt6KDMpoAuZRIY9ZYT+9wk7Mutf4ZqVeSkzveEWHhTbbOpfs7xPmmbN yAtg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding :content-language:in-reply-to:mime-version:user-agent:date :message-id:autocrypt:openpgp:from:references:cc:to:subject :dkim-signature; bh=KNY5zECgExW4ILR3xsKh1LqdbsCQIgK+wkOcJfKWtQU=; b=Mk8DpwlPZTijYBf/qHCVenFyUr+XUGoht0gasSw5QMmG/w772rGsPWqIZ3pQkewJXv GIiQuYCsYlImHleiLthRIQaas5/OFswIZtfVqzwkrNgWogmZwu+DtS27nAz8FRofHKPG jnpp8o9S70AyoWDw215FXMeI9oQG+/3NRci8iKwVnmVjukYBKR2e4BE2XAbHo3cnvB8h D4cSPDFDDCWlKqBTcp1eDp0Lqw3cuZKLlqAQBv2XWslpeKzkMmiV7aAuRT9kPf3n9bGE nG8m2tqaY/gNloeAqRZQ5oaooKElBRe4nNc30cv/0uAGE2PbqC/iiOemfbDFCwShPKHk N8pw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@gmail.com header.s=20161025 header.b=I1JWArZZ; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id v9si1061840pgj.182.2019.02.10.11.34.24; Sun, 10 Feb 2019 11:34:48 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@gmail.com header.s=20161025 header.b=I1JWArZZ; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726152AbfBJTeU (ORCPT + 99 others); Sun, 10 Feb 2019 14:34:20 -0500 Received: from mail-ot1-f68.google.com ([209.85.210.68]:37141 "EHLO mail-ot1-f68.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725971AbfBJTeT (ORCPT ); Sun, 10 Feb 2019 14:34:19 -0500 Received: by mail-ot1-f68.google.com with SMTP id s13so14156508otq.4; Sun, 10 Feb 2019 11:34:18 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=subject:to:cc:references:from:openpgp:autocrypt:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=KNY5zECgExW4ILR3xsKh1LqdbsCQIgK+wkOcJfKWtQU=; b=I1JWArZZLEAeyX7uRJnrOmzKAWB0MP5w+lS1hRJdvZApoIXzBSH1D3uJZF1xfhjT0B I8YTfAOX58SZC1SAMU//jDMPNXHV1jeIoXOkHSs2mvE7OCflpb4HkOoRU6NVdMuZlaG1 LMuIEf24jj0FETNSImb2shGX9bG+QByboxFpqKc/8ZV+/mL+BU2Dj3yt5BrhXon7vuh3 vnpP/chK1zmxBNzKQHbxwvZJnw+UUGrmbheJmq51rjB7ttEnqDx47UDFEkIynmZDK6z5 cs1sclqTfV0u1x5WVrItSft7caX0KCi3xG7knhB40YVACP09RUC+7zkpKOkZUL1FOPuV lcNg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:openpgp:autocrypt :message-id:date:user-agent:mime-version:in-reply-to :content-language:content-transfer-encoding; bh=KNY5zECgExW4ILR3xsKh1LqdbsCQIgK+wkOcJfKWtQU=; b=PhTkXKynizMKPsUKztFST/HdLF/JWmdsgQBUME28VeaIGgyS8mwIK7KO5C22ZcObXl w5sI58wK4hJI+1CWkGIk1JzgMoOX8Aa4kLEabGoLM67j9YTy+u4ut5kYmyIvw6QXuVw/ neC442oNl1b3/iUP+KvW+3q3PTmFAiDis9zYY3anu/MJol+6aBmkKXxLn9jjWNeqAgXE c3gBqg935p88M0J+TOlfy6flExKcx+0rjlyNcyRPGL8EruO0rXyf83/7MBoGy+mNdALn gAlZABSQ7z+MvoGgN3vnqFXI34lbp6fIJrrg4tMx8p5KsJA8tQ23N7SzbvEjEl9oOGTi CzRA== X-Gm-Message-State: AHQUAuYgYSYw8wkhyNqxSzZLOllKdM1vBhg6SKaEjd583wRaFli6AxXh VBxqlbnC/ufrLEDx7hBSUx4= X-Received: by 2002:a9d:8c6:: with SMTP id 64mr24747923otf.168.1549827258116; Sun, 10 Feb 2019 11:34:18 -0800 (PST) Received: from [192.168.1.2] (ip68-228-73-187.oc.oc.cox.net. [68.228.73.187]) by smtp.googlemail.com with ESMTPSA id h89sm966418oth.34.2019.02.10.11.34.16 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Sun, 10 Feb 2019 11:34:16 -0800 (PST) Subject: Re: [PATCH net-next v2 06/16] net: bridge: Stop calling switchdev_port_attr_get() To: Ido Schimmel Cc: "netdev@vger.kernel.org" , "linux-kernel@vger.kernel.org" , "devel@driverdev.osuosl.org" , "bridge@lists.linux-foundation.org" , Jiri Pirko , "andrew@lunn.ch" , "vivien.didelot@gmail.com" References: <20190210175105.31629-1-f.fainelli@gmail.com> <20190210175105.31629-7-f.fainelli@gmail.com> <20190210190501.GA26726@splinter> From: Florian Fainelli Openpgp: preference=signencrypt Autocrypt: addr=f.fainelli@gmail.com; prefer-encrypt=mutual; keydata= mQGiBEjPuBIRBACW9MxSJU9fvEOCTnRNqG/13rAGsj+vJqontvoDSNxRgmafP8d3nesnqPyR xGlkaOSDuu09rxuW+69Y2f1TzjFuGpBk4ysWOR85O2Nx8AJ6fYGCoeTbovrNlGT1M9obSFGQ X3IzRnWoqlfudjTO5TKoqkbOgpYqIo5n1QbEjCCwCwCg3DOH/4ug2AUUlcIT9/l3pGvoRJ0E AICDzi3l7pmC5IWn2n1mvP5247urtHFs/uusE827DDj3K8Upn2vYiOFMBhGsxAk6YKV6IP0d ZdWX6fqkJJlu9cSDvWtO1hXeHIfQIE/xcqvlRH783KrihLcsmnBqOiS6rJDO2x1eAgC8meAX SAgsrBhcgGl2Rl5gh/jkeA5ykwbxA/9u1eEuL70Qzt5APJmqVXR+kWvrqdBVPoUNy/tQ8mYc nzJJ63ng3tHhnwHXZOu8hL4nqwlYHRa9eeglXYhBqja4ZvIvCEqSmEukfivk+DlIgVoOAJbh qIWgvr3SIEuR6ayY3f5j0f2ejUMYlYYnKdiHXFlF9uXm1ELrb0YX4GMHz7QnRmxvcmlhbiBG YWluZWxsaSA8Zi5mYWluZWxsaUBnbWFpbC5jb20+iGYEExECACYCGyMGCwkIBwMCBBUCCAME FgIDAQIeAQIXgAUCVF/S8QUJHlwd3wAKCRBhV5kVtWN2DvCVAJ4u4/bPF4P3jxb4qEY8I2gS 6hG0gACffNWlqJ2T4wSSn+3o7CCZNd7SLSC5BA0ESM+4EhAQAL/o09boR9D3Vk1Tt7+gpYr3 WQ6hgYVON905q2ndEoA2J0dQxJNRw3snabHDDzQBAcqOvdi7YidfBVdKi0wxHhSuRBfuOppu pdXkb7zxuPQuSveCLqqZWRQ+Cc2QgF7SBqgznbe6Ngout5qXY5Dcagk9LqFNGhJQzUGHAsIs hap1f0B1PoUyUNeEInV98D8Xd/edM3mhO9nRpUXRK9Bvt4iEZUXGuVtZLT52nK6Wv2EZ1TiT OiqZlf1P+vxYLBx9eKmabPdm3yjalhY8yr1S1vL0gSA/C6W1o/TowdieF1rWN/MYHlkpyj9c Rpc281gAO0AP3V1G00YzBEdYyi0gaJbCEQnq8Vz1vDXFxHzyhgGz7umBsVKmYwZgA8DrrB0M oaP35wuGR3RJcaG30AnJpEDkBYHznI2apxdcuTPOHZyEilIRrBGzDwGtAhldzlBoBwE3Z3MY 31TOpACu1ZpNOMysZ6xiE35pWkwc0KYm4hJA5GFfmWSN6DniimW3pmdDIiw4Ifcx8b3mFrRO BbDIW13E51j9RjbO/nAaK9ndZ5LRO1B/8Fwat7bLzmsCiEXOJY7NNpIEpkoNoEUfCcZwmLrU +eOTPzaF6drw6ayewEi5yzPg3TAT6FV3oBsNg3xlwU0gPK3v6gYPX5w9+ovPZ1/qqNfOrbsE FRuiSVsZQ5s3AAMFD/9XjlnnVDh9GX/r/6hjmr4U9tEsM+VQXaVXqZuHKaSmojOLUCP/YVQo 7IiYaNssCS4FCPe4yrL4FJJfJAsbeyDykMN7wAnBcOkbZ9BPJPNCbqU6dowLOiy8AuTYQ48m vIyQ4Ijnb6GTrtxIUDQeOBNuQC/gyyx3nbL/lVlHbxr4tb6YkhkO6shjXhQh7nQb33FjGO4P WU11Nr9i/qoV8QCo12MQEo244RRA6VMud06y/E449rWZFSTwGqb0FS0seTcYNvxt8PB2izX+ HZA8SL54j479ubxhfuoTu5nXdtFYFj5Lj5x34LKPx7MpgAmj0H7SDhpFWF2FzcC1bjiW9mjW HaKaX23Awt97AqQZXegbfkJwX2Y53ufq8Np3e1542lh3/mpiGSilCsaTahEGrHK+lIusl6mz Joil+u3k01ofvJMK0ZdzGUZ/aPMZ16LofjFA+MNxWrZFrkYmiGdv+LG45zSlZyIvzSiG2lKy kuVag+IijCIom78P9jRtB1q1Q5lwZp2TLAJlz92DmFwBg1hyFzwDADjZ2nrDxKUiybXIgZp9 aU2d++ptEGCVJOfEW4qpWCCLPbOT7XBr+g/4H3qWbs3j/cDDq7LuVYIe+wchy/iXEJaQVeTC y5arMQorqTFWlEOgRA8OP47L9knl9i4xuR0euV6DChDrguup2aJVU4hPBBgRAgAPAhsMBQJU X9LxBQkeXB3fAAoJEGFXmRW1Y3YOj4UAn3nrFLPZekMeqX5aD/aq/dsbXSfyAKC45Go0YyxV HGuUuzv+GKZ6nsysJ7kCDQRXG8fwARAA6q/pqBi5PjHcOAUgk2/2LR5LjjesK50bCaD4JuNc YDhFR7Vs108diBtsho3w8WRd9viOqDrhLJTroVckkk74OY8r+3t1E0Dd4wHWHQZsAeUvOwDM PQMqTUBFuMi6ydzTZpFA2wBR9x6ofl8Ax+zaGBcFrRlQnhsuXLnM1uuvS39+pmzIjasZBP2H UPk5ifigXcpelKmj6iskP3c8QN6x6GjUSmYx+xUfs/GNVSU1XOZn61wgPDbgINJd/THGdqiO iJxCLuTMqlSsmh1+E1dSdfYkCb93R/0ZHvMKWlAx7MnaFgBfsG8FqNtZu3PCLfizyVYYjXbV WO1A23riZKqwrSJAATo5iTS65BuYxrFsFNPrf7TitM8E76BEBZk0OZBvZxMuOs6Z1qI8YKVK UrHVGFq3NbuPWCdRul9SX3VfOunr9Gv0GABnJ0ET+K7nspax0xqq7zgnM71QEaiaH17IFYGS sG34V7Wo3vyQzsk7qLf9Ajno0DhJ+VX43g8+AjxOMNVrGCt9RNXSBVpyv2AMTlWCdJ5KI6V4 KEzWM4HJm7QlNKE6RPoBxJVbSQLPd9St3h7mxLcne4l7NK9eNgNnneT7QZL8fL//s9K8Ns1W t60uQNYvbhKDG7+/yLcmJgjF74XkGvxCmTA1rW2bsUriM533nG9gAOUFQjURkwI8jvMAEQEA AYkCaAQYEQIACQUCVxvH8AIbAgIpCRBhV5kVtWN2DsFdIAQZAQIABgUCVxvH8AAKCRCH0Jac RAcHBIkHD/9nmfog7X2ZXMzL9ktT++7x+W/QBrSTCTmq8PK+69+INN1ZDOrY8uz6htfTLV9+ e2W6G8/7zIvODuHk7r+yQ585XbplgP0V5Xc8iBHdBgXbqnY5zBrcH+Q/oQ2STalEvaGHqNoD UGyLQ/fiKoLZTPMur57Fy1c9rTuKiSdMgnT0FPfWVDfpR2Ds0gpqWePlRuRGOoCln5GnREA/ 2MW2rWf+CO9kbIR+66j8b4RUJqIK3dWn9xbENh/aqxfonGTCZQ2zC4sLd25DQA4w1itPo+f5 V/SQxuhnlQkTOCdJ7b/mby/pNRz1lsLkjnXueLILj7gNjwTabZXYtL16z24qkDTI1x3g98R/ xunb3/fQwR8FY5/zRvXJq5us/nLvIvOmVwZFkwXc+AF+LSIajqQz9XbXeIP/BDjlBNXRZNdo dVuSU51ENcMcilPr2EUnqEAqeczsCGpnvRCLfVQeSZr2L9N4svNhhfPOEscYhhpHTh0VPyxI pPBNKq+byuYPMyk3nj814NKhImK0O4gTyCK9b+gZAVvQcYAXvSouCnTZeJRrNHJFTgTgu6E0 caxTGgc5zzQHeX67eMzrGomG3ZnIxmd1sAbgvJUDaD2GrYlulfwGWwWyTNbWRvMighVdPkSF 6XFgQaosWxkV0OELLy2N485YrTr2Uq64VKyxpncLh50e2RnyAJ9qfUATKC9NgZjRvBztfqy4 a9BQwACgnzGuH1BVeT2J0Ra+ZYgkx7DaPR0= Message-ID: <73a10fbb-7689-74a7-3fbf-076f8dc9d76f@gmail.com> Date: Sun, 10 Feb 2019 11:34:14 -0800 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.4.0 MIME-Version: 1.0 In-Reply-To: <20190210190501.GA26726@splinter> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Le 2/10/19 à 11:05 AM, Ido Schimmel a écrit : > On Sun, Feb 10, 2019 at 09:50:55AM -0800, Florian Fainelli wrote: >> Now that all switchdev drivers have been converted to checking the >> bridge port flags during the prepare phase of the >> switchdev_port_attr_set(), we can move straight to trying to set the >> desired flag through SWITCHDEV_ATTR_ID_PORT_BRIDGE_FLAGS. >> >> Acked-by: Jiri Pirko >> Signed-off-by: Florian Fainelli >> --- >> net/bridge/br_switchdev.c | 20 +++----------------- >> 1 file changed, 3 insertions(+), 17 deletions(-) >> >> diff --git a/net/bridge/br_switchdev.c b/net/bridge/br_switchdev.c >> index db9e8ab96d48..939f300522c5 100644 >> --- a/net/bridge/br_switchdev.c >> +++ b/net/bridge/br_switchdev.c >> @@ -64,29 +64,15 @@ int br_switchdev_set_port_flag(struct net_bridge_port *p, >> { >> struct switchdev_attr attr = { >> .orig_dev = p->dev, >> - .id = SWITCHDEV_ATTR_ID_PORT_BRIDGE_FLAGS_SUPPORT, >> + .id = SWITCHDEV_ATTR_ID_PORT_BRIDGE_FLAGS, >> + .flags = SWITCHDEV_F_DEFER, > > How does this work? You defer the operation, so the driver cannot veto > it. This is why we have SWITCHDEV_ATTR_ID_PORT_BRIDGE_FLAGS_SUPPORT > which is not deferred. I missed that indeed, how would you feel about splitting the attribute setting into different phases: - checking that the attribute setting is supported (caller context, so possibly atomic) - allocating and committing resources (deferred context) For pretty much any DSA driver, we will have to be in sleepable context anyway because of MDIO, SPI, I2C, whatever transport layer. Not sure how to best approach this now... -- Florian