Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Date:   Sun, 10 Feb 2019 14:29:03 -0800
From:   Ira Weiny <ira.weiny@intel.com>
To:     Thomas Gleixner <tglx@linutronix.de>
Cc:     Ingo Molnar <mingo@redhat.com>, Borislav Petkov <bp@alien8.de>,
        x86@kernel.org, linux-kernel@vger.kernel.org, linux-mm@kvack.org,
        "Kirill A. Shutemov" <kirill.shutemov@linux.intel.com>,
        Dave Hansen <dave.hansen@intel.com>,
        Andrew Morton <akpm@linux-foundation.org>,
        Dan Williams <dan.j.williams@intel.com>
Subject: Re: [PATCH] mm/gup.c: Remove unused write variable
Message-ID: <20190210222902.GA13720@iweiny-DESK2.sc.intel.com>
References: <20190209173109.9361-1-ira.weiny@intel.com>
 <alpine.DEB.2.21.1902102029560.8784@nanos.tec.linutronix.de>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <alpine.DEB.2.21.1902102029560.8784@nanos.tec.linutronix.de>
User-Agent: Mutt/1.11.1 (2018-12-01)
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On Sun, Feb 10, 2019 at 08:39:44PM +0100, Thomas Gleixner wrote:
> Ira,
> 
> On Sat, 9 Feb 2019, ira.weiny@intel.com wrote:
> 
> nice patch. Just a few nitpicks vs. the subject and the change log.
> 
> > Subject: [PATCH] mm/gup.c: Remove unused write variable
> 
> We usually avoid filenames in the subsystem prefix. mm/gup: is sufficient.

Thanks.

> 
> But what's a bit more confusing is 'write variable'. You are not removing a
> variable, you are removing a unused function argument. That's two different
> things.

Indeed my mistake.

> 
> > write is unused in gup_fast_permitted so remove it.
> 
> When referencing functions please use brackets so it's clear that you talk
> about a function, i.e. gup_fast_permitted().
> 
> So the correct subject line would be:
> 
>   Subject: [PATCH] mm/gup: Remove write argument from gup_fast_permitted()

NP, V2 on its way,
Ira

> 
> Thanks,
> 
> 	tglx