Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Subject: Re: [PATCH v2] PCI: endpoint: functions: Use kmemdup instead of
 duplicating its function
To:     Lorenzo Pieralisi <lorenzo.pieralisi@arm.com>,
        Wen Yang <wen.yang99@zte.com.cn>
CC:     Bjorn Helgaas <bhelgaas@google.com>, <linux-pci@vger.kernel.org>,
        <linux-kernel@vger.kernel.org>, <zhong.weidong@zte.com.cn>,
        Gustavo Pimentel <gustavo.pimentel@synopsys.com>,
        Niklas Cassel <niklas.cassel@axis.com>,
        Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
        Cyrille Pitchen <cyrille.pitchen@free-electrons.com>
References: <20181206125225.9497-1-wen.yang99@zte.com.cn>
 <20190208122027.GE13009@e107981-ln.cambridge.arm.com>
From:   Kishon Vijay Abraham I <kishon@ti.com>
Message-ID: <aa4280f5-9750-05e9-7737-044d8f127521@ti.com>
Date:   Mon, 11 Feb 2019 11:18:25 +0530
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101
 Thunderbird/60.4.0
MIME-Version: 1.0
In-Reply-To: <20190208122027.GE13009@e107981-ln.cambridge.arm.com>
Content-Type: text/plain; charset="utf-8"
Content-Language: en-US
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

Hi Lorenzo,

On 08/02/19 5:50 PM, Lorenzo Pieralisi wrote:
> On Thu, Dec 06, 2018 at 08:52:25PM +0800, Wen Yang wrote:
>> kmemdup has implemented the function that kmalloc() + memcpy().
>> We prefer to kmemdup rather than code opened implementation.
>>
>> This issue was detected with the help of coccinelle.
>>
>> Signed-off-by: Wen Yang <wen.yang99@zte.com.cn>
>> CC: Kishon Vijay Abraham I <kishon@ti.com>
>> CC: Lorenzo Pieralisi <lorenzo.pieralisi@arm.com>
>> CC: Bjorn Helgaas <bhelgaas@google.com>
>> CC: Gustavo Pimentel <gustavo.pimentel@synopsys.com>
>> CC: Niklas Cassel <niklas.cassel@axis.com>
>> CC: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
>> CC: Cyrille Pitchen <cyrille.pitchen@free-electrons.com>
>> CC: linux-pci@vger.kernel.org (open list:PCI ENDPOINT SUBSYSTEM)
>> CC: linux-kernel@vger.kernel.org (open list)
>> ---
>>  drivers/pci/endpoint/functions/pci-epf-test.c | 4 +---
>>  1 file changed, 1 insertion(+), 3 deletions(-)
> 
> Kishon,
> 
> this looks OK to me, anything I am missing ?

For the existing code this might seem the right thing to do but ideally the
memcpy here should be changed to memcpy_fromio/memcpy_toio.

Also later when we plan to use DMA (on the endpoint) for data transfer, we have
to use kzalloc and dma_map_single APIs.

So maybe the right thing would be to just fix it to use memcpy_fromio here.

Thanks
Kishon
> 
> Lorenzo
> 
>> diff --git a/drivers/pci/endpoint/functions/pci-epf-test.c b/drivers/pci/endpoint/functions/pci-epf-test.c
>> index 3e86fa3c7da3..8df6c019f8a2 100644
>> --- a/drivers/pci/endpoint/functions/pci-epf-test.c
>> +++ b/drivers/pci/endpoint/functions/pci-epf-test.c
>> @@ -169,14 +169,12 @@ static int pci_epf_test_read(struct pci_epf_test *epf_test)
>>  		goto err_addr;
>>  	}
>>  
>> -	buf = kzalloc(reg->size, GFP_KERNEL);
>> +	buf = kmemdup(src_addr, reg->size, GFP_KERNEL);
>>  	if (!buf) {
>>  		ret = -ENOMEM;
>>  		goto err_map_addr;
>>  	}
>>  
>> -	memcpy(buf, src_addr, reg->size);
>> -
>>  	crc32 = crc32_le(~0, buf, reg->size);
>>  	if (crc32 != reg->checksum)
>>  		ret = -EIO;
>> -- 
>> 2.19.1
>>