Received: by 2002:ac0:946b:0:0:0:0:0 with SMTP id j40csp2245273imj; Sun, 10 Feb 2019 22:36:02 -0800 (PST) X-Google-Smtp-Source: AHgI3IZVggN3xL9gCRav9YM4RL7SPdrUrYOgBMH7iRe2zBb1lhIo2ak/gf1Kl1d99QttohgzEARu X-Received: by 2002:a17:902:8e8a:: with SMTP id bg10mr35817141plb.192.1549866962107; Sun, 10 Feb 2019 22:36:02 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1549866962; cv=none; d=google.com; s=arc-20160816; b=rlqQ9qPshHweX+PmwhPeScpa4Cxl7+YmcmWoLjmWz6QD7t8Ej2e6fyPGqbvcxWuyeB 8vbsccarujuMEFvKuUyJsGp1GDZ9SvrdXYX2URp1/CvWc3vFM+096FZkrURrn5S1X81k pe8Ack2ChglTKy5vd8hRzOH9SHywUQjlLKQzBmVCNXBaMR1CtDl2+ZxlZnWNJeLw5Fs8 lGBIUUMw5vad93kiNaEKC9/Ekn1bBF6loFgzrppl+bJPtdtUe8v16PAmbxGkGmT9U8FQ Z0nwBUCERumFR8lWgRdTZVLRy5UfRUMADt7vN2jG06TkRVJ4JdWsH+fbzR12Bqg941rF 407w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:mime-version:content-transfer-encoding :references:in-reply-to:date:cc:to:from:subject:message-id; bh=34D14LZCzpn+IJYqJOjyi6wohnx0Qz4rG1FnSGmsWy4=; b=KxW4SNfmRe9E+QjzuYoUInoIcCdMkDyMRVv1IPRki/U49GAD7T5dIiiOi/4+QuUGNs 3t0khrSVi63a0gXrGSCSvTDfM3pUCt1W9Q6L3ztgdt/aVrQ5gYvi/EMi1RvinDVG2WQd nS4JbaEwiZVMUcPC4AY5itOQsL3xMAI5UPjWgHGq6fnkChws87qsuzNdDm83rLdWnQE/ 8onDexzP0ZVeqVBy1VOFmb8VKUfCFlh4x5GeMzL3qpBG5ye4u7Ff7eJ1tdtlOl7ix+WZ i5u2fvHgvE9tM6ce2ZkzN6UXoORBV/3DTnghmHRiV1RNlubSaf9Cf47Yx4QbF9DcJwXH oBig== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id 97si9853213ple.389.2019.02.10.22.35.45; Sun, 10 Feb 2019 22:36:02 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726300AbfBKGfj (ORCPT + 99 others); Mon, 11 Feb 2019 01:35:39 -0500 Received: from mailgw01.mediatek.com ([210.61.82.183]:12923 "EHLO mailgw01.mediatek.com" rhost-flags-OK-FAIL-OK-FAIL) by vger.kernel.org with ESMTP id S1725931AbfBKGfj (ORCPT ); Mon, 11 Feb 2019 01:35:39 -0500 X-UUID: 5a48a9fdda8b4c8aa21af3800d68c9a8-20190211 X-UUID: 5a48a9fdda8b4c8aa21af3800d68c9a8-20190211 Received: from mtkcas08.mediatek.inc [(172.21.101.126)] by mailgw01.mediatek.com (envelope-from ) (mhqrelay.mediatek.com ESMTP with TLS) with ESMTP id 1290777801; Mon, 11 Feb 2019 14:35:30 +0800 Received: from mtkcas08.mediatek.inc (172.21.101.126) by mtkmbs08n2.mediatek.inc (172.21.101.56) with Microsoft SMTP Server (TLS) id 15.0.1395.4; Mon, 11 Feb 2019 14:35:29 +0800 Received: from [172.21.84.99] (172.21.84.99) by mtkcas08.mediatek.inc (172.21.101.73) with Microsoft SMTP Server id 15.0.1395.4 via Frontend Transport; Mon, 11 Feb 2019 14:35:29 +0800 Message-ID: <1549866929.22817.20.camel@mtksdccf07> Subject: Re: [PATCH v6 1/6] irqchip/mtk-sysirq: support 4 interrupt parameters for sysirq From: Seiya Wang To: Marc Zyngier CC: Matthias Brugger , Erin Lo , Rob Herring , Mark Rutland , Thomas Gleixner , Jason Cooper , Greg Kroah-Hartman , Stephen Boyd , , srv_heupstream , , , , , , , , Date: Mon, 11 Feb 2019 14:35:29 +0800 In-Reply-To: References: <1548317240-44682-1-git-send-email-erin.lo@mediatek.com> <1548317240-44682-2-git-send-email-erin.lo@mediatek.com> <898ca3d9-002b-e28e-fc97-86bc2538e9de@gmail.com> <626b5b46-aac7-1532-386e-2fed85bf4ad9@arm.com> Content-Type: text/plain; charset="UTF-8" X-Mailer: Evolution 3.2.3-0ubuntu6 Content-Transfer-Encoding: 7bit MIME-Version: 1.0 X-TM-SNTS-SMTP: 0EC95753EDE9BB9F38910B43EEEF03341118F2C1563FCCA041DC54C948DD96C92000:8 X-MTK: N Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, 2019-02-07 at 15:52 +0000, Marc Zyngier wrote: > On 07/02/2019 15:47, Marc Zyngier wrote: > > On 07/02/2019 15:20, Matthias Brugger wrote: > >> > >> > >> On 24/01/2019 09:07, Erin Lo wrote: > >>> From: Seiya Wang > >>> > >>> To support partitioned PPIs, 4 interrupt parameters should be valid > >>> for sysirq. > >>> > >>> Signed-off-by: Seiya Wang > >>> Signed-off-by: Erin Lo > >>> --- > >>> drivers/irqchip/irq-mtk-sysirq.c | 4 ++-- > >>> 1 file changed, 2 insertions(+), 2 deletions(-) > >>> > >>> diff --git a/drivers/irqchip/irq-mtk-sysirq.c b/drivers/irqchip/irq-mtk-sysirq.c > >>> index 90aaf19..282736a 100644 > >>> --- a/drivers/irqchip/irq-mtk-sysirq.c > >>> +++ b/drivers/irqchip/irq-mtk-sysirq.c > >>> @@ -81,7 +81,7 @@ static int mtk_sysirq_domain_translate(struct irq_domain *d, > >>> unsigned int *type) > >>> { > >>> if (is_of_node(fwspec->fwnode)) { > >>> - if (fwspec->param_count != 3) > >>> + if (fwspec->param_count != 3 && fwspec->param_count != 4) > >> > >> Where is this 4th parameter used? > > > > https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/Documentation/devicetree/bindings/interrupt-controller/arm,gic-v3.txt#n14 > Sorry, I fired Send way too early. > > What I wanted to add is that it is not clear to me why this change would > be required here, as this driver only supports SPIs. It could be fixed > by just relaxing the binding itself. > > Thanks, > > M. Do you mean that we should change #interrupt-cells back to 3 for sysirq and remove the 4th parameters of every spi interrupts in mt8183.dtsi (i.e. 3 parameters for spi, 4 for ppi) such that we can discard this patch? If yes, we may need some time to verify the change before resending the patch. Thanks.