Received: by 2002:ac0:946b:0:0:0:0:0 with SMTP id j40csp2333447imj; Mon, 11 Feb 2019 00:39:35 -0800 (PST) X-Google-Smtp-Source: AHgI3IYl4QQ+JldI2yLYz0i6sNm8Pp+QEWZXUC/SkbLBoGDraiF5vGF8DoDChd9QUPQSh9iAgJ4S X-Received: by 2002:a63:4346:: with SMTP id q67mr4353312pga.92.1549874374934; Mon, 11 Feb 2019 00:39:34 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1549874374; cv=none; d=google.com; s=arc-20160816; b=Yyti8wADoZe1FRTHb3hP9pwxf0sEjwqTsKBTF/Ht1xo+mtgWddBmmbr9U50Th0bngc ymSyrwxOiwC+DblXb3ebxWz0ge78MliWBPL9vORTFgD8YQNo+9iGjwg71on2150lMsxT q9LjpH2DbahQ4Mp/6REpIYb4yuRo+ElYhytIZfJ+Ri9o+q7WMtlctfjl7/kwMSndq59u Dt60Z5aXY5QIj6bMV8HalDe95YV21Ifk+K2vRKGbpiR9Dz1HkdtLFqR+rFTEaAQjhB+8 IP/Hx6XlpNay0TT6xlsINs9MC8rnx02w6P7W+JX9xb4REIRssHkPtwlrcjp9NxRRg/Lh R0Kg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding :content-language:in-reply-to:mime-version:user-agent:date :message-id:from:references:cc:to:subject:dkim-signature; bh=sb8NaGm2k/XwWwVVppweFWt8LA6VpiYcLXVpJw5XySQ=; b=eI4bPPcjr2s6KbWIpsfaUqhSQS58CjvBNuVYAsKljF4z4jNTSj+gmIpg95/0Gn+BB7 srp/3JcaeJx7xb7fzj8JYwRDhoaSGtk8mn4Ym0AjoxWCBuKpsh4ItJhms5xWxx4ihP2g uZvrwwlEFHGwvlxTBC/GDN41ExajwkLY9Z8cBif7Kfw96eFSJ1c715A+cSG4dm+MbFbH hWD3/5pfK43NUeCv4YLUEJSAdYE7UbF7Y8a9kNRzfNYi3FS7Z/SVkc743lUs3ceNYNmJ TNivQitvqXswSklDzwDgoXSEUpI3gHPPbk52m/wg8/TzTME69oO8hGSEl1VE5HPapB69 s6DQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@cogentembedded-com.20150623.gappssmtp.com header.s=20150623 header.b=n+dLEfQl; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id d25si9182484pgd.88.2019.02.11.00.39.18; Mon, 11 Feb 2019 00:39:34 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@cogentembedded-com.20150623.gappssmtp.com header.s=20150623 header.b=n+dLEfQl; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727180AbfBKIii (ORCPT + 99 others); Mon, 11 Feb 2019 03:38:38 -0500 Received: from mail-lj1-f193.google.com ([209.85.208.193]:35152 "EHLO mail-lj1-f193.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727085AbfBKIih (ORCPT ); Mon, 11 Feb 2019 03:38:37 -0500 Received: by mail-lj1-f193.google.com with SMTP id j13-v6so8019411ljc.2 for ; Mon, 11 Feb 2019 00:38:35 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=cogentembedded-com.20150623.gappssmtp.com; s=20150623; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=sb8NaGm2k/XwWwVVppweFWt8LA6VpiYcLXVpJw5XySQ=; b=n+dLEfQliRHulGENEzjiPtUKTF95uOEQRIZxdgLtLbSute1MpTPKXHmCZKPYS4qqOA 0JTJ50wGKXwJcyvr1eqiNb1Nk1U4k9uhLLE/wWx5ka1A+z1kAReKU4RpJogimUwe8sFu mbCjYrXBDH722WdOw5bH2HBemQyYTssoVdChqEoBw4INCjmr0rHGP1MEW4F8KDOBHowG 3ewz/IkFwz6SoHpV0DntU33sIvvRmK5QpGO/DMBdNjrKDs/fGOmfEJQg9msPkuAFcRYT ZYJoeeOAai/MoHBg+41quwhHYJV+e8vzayEeYZBG+eWqremf8lSSGX4eC7nF+rxOwt6Y s8zg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=sb8NaGm2k/XwWwVVppweFWt8LA6VpiYcLXVpJw5XySQ=; b=ip3Njy7zvOIvbNvRehC2Jm15u1stCnIbgj/+dXwVlJAjqZaVoHI0pG96lZSTeOLJuv DULOzLYI/hL6GTtY9JGAUwYxNtbt57RBP9FVNlIv67wSZkjidkCSiRXPZLrJE1lOK6i8 5ITHtMLwOwoEu9Ma7p6wS5Z3wgCKS6h7ZfIANEVQfL9z5ChlG45kn8jm8tgJFJm7hjIn HQQvs9Tr/kxp8vORlaM6uw12zZtJvKR61Ul5lXVykio/QcXBHbbyUaz2nCiDbOUEaHXr Msk45oOmwo0SNqDqAePU4C6Qx+ZZvwYrjL+ZBbYhmOaxiSTVaTvYmg4GGbBxiOjxSo+y gz6g== X-Gm-Message-State: AHQUAuaYbKtQOODDBvOjQTMTCEan1ACjrqYDJt8oJ1T5RjzvEubnTMGb rMqOjsmFRRiP0Gkp5tD3bYtkkQ== X-Received: by 2002:a2e:8ece:: with SMTP id e14-v6mr1768934ljl.64.1549874315029; Mon, 11 Feb 2019 00:38:35 -0800 (PST) Received: from [192.168.0.199] ([31.173.84.177]) by smtp.gmail.com with ESMTPSA id l27sm1519023lfk.6.2019.02.11.00.38.33 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Mon, 11 Feb 2019 00:38:34 -0800 (PST) Subject: Re: [PATCH] mt76: change the retun type of mt76_dma_attach() To: Ryder Lee , Lorenzo Bianconi , Felix Fietkau , Kalle Valo Cc: Roy Luo , linux-wireless@vger.kernel.org, linux-kernel@vger.kernel.org, netdev@vger.kernel.org, linux-mediatek@lists.infradead.org References: <228fdddb9ca96e8ce861e324eb9039722cf18f49.1549850911.git.ryder.lee@mediatek.com> From: Sergei Shtylyov Message-ID: Date: Mon, 11 Feb 2019 11:38:28 +0300 User-Agent: Mozilla/5.0 (Windows NT 6.3; WOW64; rv:60.0) Gecko/20100101 Thunderbird/60.5.0 MIME-Version: 1.0 In-Reply-To: <228fdddb9ca96e8ce861e324eb9039722cf18f49.1549850911.git.ryder.lee@mediatek.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hello! On 11.02.2019 5:13, Ryder Lee wrote: > There is no need to retun 0 in mt76_dma_attach(), so switch it to void. ^ r missing :-) > > Signed-off-by: Ryder Lee [...] MBR, Sergei