Received: by 2002:ac0:946b:0:0:0:0:0 with SMTP id j40csp2339691imj; Mon, 11 Feb 2019 00:48:44 -0800 (PST) X-Google-Smtp-Source: AHgI3IZdDSQ9mYgZXJ/fs5pkmldqd9hnSrp010URmc2VdfUp8zhWMojXSsJhTOSO83XPc8m7E31n X-Received: by 2002:a63:4858:: with SMTP id x24mr17689106pgk.420.1549874924093; Mon, 11 Feb 2019 00:48:44 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1549874924; cv=none; d=google.com; s=arc-20160816; b=yVEjY5rYJ1BHB2dshGLABhe/BUfnnO/5H6vYNZuVo4oc6KSbxD2J/YD/v3Q9+ZpXhp 7X/ay7Cecv0UkvfLoBoDvaQDcDtJQsh1qpW6BI66hc4+HxVKjObUW1+QtTVuJc+6gZ1B Ru7/arPeFUsRfz97lSEaVK3MqOEgSccRtVaTgKPpbd4v4CmnF8e7CkfDv0V8ZHUibIoS aNzT/3N4hlkyownE/psFQi+bZ/M/M4SAinkSHFjxc73959C1v3nPqTI60q62vOlBlbuu ubxwMLU5othHEAiCyNbxpYt5chj3xqgPZqQpl7NW5JBULDhkS5QB7iXiO1ptyZ8LxttF GPMQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:dkim-signature; bh=O4Gxkv7D3TGU3ViCnyhBWMhvZW0k1QD5JBNjYCQQNUQ=; b=sV4bP/lvuhD8KCsHhSmfj8mL1Y5MFOS3AgyoM4CPW6ngTzK3NuPlrdtEHP1Naxne+w meoc4gMwgBDZpGJlkoLAvX/ZTapzBSgk+0MgCNVkFj/QYyOVgZfs9BQ6+luyOHur1EZP CmwQ8qzv2+NjT8Eu6R+opMCehgDKC7jZRLzoi/tTN4SEw4lbj4XsBrY3ghKh/2Y/tptC f1acJxkijoyfDoAz3v30h3v2s0aUeZjYcwlsjWQe3dnGSBfn5fRcMtJ08QeTkxv/H3jI GZms6inVmy5T2eQHBHOkAGJV2cnpIDwCaeVfjeUx7fPkrtcCs/hUZJsy1hBghyLX8Iau pXvQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=owks95T2; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id g12si7623516pgd.567.2019.02.11.00.48.28; Mon, 11 Feb 2019 00:48:44 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=owks95T2; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727120AbfBKIrl (ORCPT + 99 others); Mon, 11 Feb 2019 03:47:41 -0500 Received: from mail.kernel.org ([198.145.29.99]:36860 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725931AbfBKIrl (ORCPT ); Mon, 11 Feb 2019 03:47:41 -0500 Received: from mail-lf1-f49.google.com (mail-lf1-f49.google.com [209.85.167.49]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id BB4902176F; Mon, 11 Feb 2019 08:47:39 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1549874860; bh=zivmjRJeqY7jYqs9u4inzJ0Gz6WHby5gz1++O+RQWrc=; h=References:In-Reply-To:From:Date:Subject:To:Cc:From; b=owks95T2YWjgSufmMAOQbpJ9QKYe0RV0d+FUmOSBNz+KrwCo4LRWDUd2m87D7oMVs EjQLL3NKYe/308PGAu/NnQK7ZKjwyX1sbNPgC389AYYNCz0hJC1eqc0XCxB5Zu+xOM Nwt4SEeuPCbT3GxWUw4V/u7u6ZAJ3wJTa76rmfJE= Received: by mail-lf1-f49.google.com with SMTP id e27so7053941lfj.8; Mon, 11 Feb 2019 00:47:39 -0800 (PST) X-Gm-Message-State: AHQUAubgL37g/4zCCiZMMDlbNs6HUbz1nWu7mKCoGPaM6z+b0wCWlZba w5m+A2aLagFQlCU1V7J6USlc8GdXwgAt9b2fgq0= X-Received: by 2002:a19:f013:: with SMTP id p19mr2761837lfc.154.1549874857895; Mon, 11 Feb 2019 00:47:37 -0800 (PST) MIME-Version: 1.0 References: <20190210225114.20110-1-stuart.menefy@mathembedded.com> <20190210225114.20110-2-stuart.menefy@mathembedded.com> In-Reply-To: <20190210225114.20110-2-stuart.menefy@mathembedded.com> From: Krzysztof Kozlowski Date: Mon, 11 Feb 2019 09:47:26 +0100 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH 1/2] clocksource: exynos_mct: Move one-shot check from tick clear to ISR To: Stuart Menefy Cc: "linux-samsung-soc@vger.kernel.org" , Daniel Lezcano , Thomas Gleixner , Kukjin Kim , linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org Content-Type: text/plain; charset="UTF-8" Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sun, 10 Feb 2019 at 23:51, Stuart Menefy wrote: > > When a timer tick occurs and the clock is in one-shot mode, the timer > needs to be stopped to prevent it triggering subsequent interrupts. > Currently this code is in exynos4_mct_tick_clear(), but as it is > only needed when an ISR occurs move it into exynos4_mct_tick_isr(), > leaving exynos4_mct_tick_clear() just doing what its name suggests it > should. > > Signed-off-by: Stuart Menefy > --- > drivers/clocksource/exynos_mct.c | 22 +++++++++++----------- > 1 file changed, 11 insertions(+), 11 deletions(-) Reviewed-by: Krzysztof Kozlowski Best regards, Krzysztof