Received: by 2002:ac0:946b:0:0:0:0:0 with SMTP id j40csp2364044imj; Mon, 11 Feb 2019 01:19:59 -0800 (PST) X-Google-Smtp-Source: AHgI3IayaWNkXp02JyzuzA3co70VMGLCQ6R8tyOE7m6OMOZt61On1Ba+m2Iiv5H4oLbKoqtGaBNk X-Received: by 2002:a17:902:4124:: with SMTP id e33mr35682030pld.236.1549876799477; Mon, 11 Feb 2019 01:19:59 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1549876799; cv=none; d=google.com; s=arc-20160816; b=ByK2K4B+gR54ak0e2cz2REsrQJGGOXdjWy7+FhWI7WLC2UDI15bd05j2naMjzZ0ljc btvPbz33JKNb27i5u8zgdfx9ArNpGvrO4+OS+W9vaR+GwVFMjKzFgbjF5gF+8Pb9xnK7 kTFcSkvEMR/0u4RaYxNf/BY+nPl+zlSHyBghNfp39SL/S9+HSKkvmkzeSduUUB4BEfqz oN5A6V0/ManJxJ1XABUMNoS3VXvvP8mRNcAKnfokvnXFt+8EyGJC7NhN95va0XA4F0bQ oK6Ki4sw5MhU8d7kfmu9QSQquBzuGIrg8sK61Adrmx49+x7BQ/JNMO40JjQvZUInykyg QxxA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:mime-version:user-agent:message-id :in-reply-to:date:references:subject:cc:to:from:dmarc-filter :dkim-signature:dkim-signature; bh=5XFis5aWcv1gwoj7J2xHFdsjOmh9k1ldE/qL4ot7fE0=; b=eg9wljO+uCrxtaSqL5rSd9rbuVK0ru70KfDqH1l3UwvacdjlKINSRK/BSOPXAJG4Z5 MLU9VF+Lb7uzxgW8CJTVwJCDXKiEYjR52Wg61fBfdN593jUFEidfby6VxKLskFDPNSFp ynfiCpDWyMJGtHwJ1XhMzkKbDOTBq+rX7ES0TOe9m5UZi23JgUZwIVZ35rXl4PizanAl I8ARHM4PiPm01raZAEARhFP4okQvFw5F3Q/ObzbY7Y+8Z2CFJ70BcWo0uh8A1IqnKWOV T0afx/KA61j52E42qgOfbnxyRmPVd8TGK2oa5Xl9l3Vjg/0seEb+br+hQdznD4KLfl0Z 860w== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@codeaurora.org header.s=default header.b=EqvrERqU; dkim=pass header.i=@codeaurora.org header.s=default header.b=EqvrERqU; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id 18si9046435pgb.412.2019.02.11.01.19.42; Mon, 11 Feb 2019 01:19:59 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@codeaurora.org header.s=default header.b=EqvrERqU; dkim=pass header.i=@codeaurora.org header.s=default header.b=EqvrERqU; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726891AbfBKJTf (ORCPT + 99 others); Mon, 11 Feb 2019 04:19:35 -0500 Received: from smtp.codeaurora.org ([198.145.29.96]:43590 "EHLO smtp.codeaurora.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726046AbfBKJTe (ORCPT ); Mon, 11 Feb 2019 04:19:34 -0500 Received: by smtp.codeaurora.org (Postfix, from userid 1000) id B8E56607DF; Mon, 11 Feb 2019 09:19:33 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=codeaurora.org; s=default; t=1549876773; bh=w7vNofABHkmV2IriZIaKXGIVjSCa9cvWKSQNtMH07no=; h=From:To:Cc:Subject:References:Date:In-Reply-To:From; b=EqvrERqUB688WWSutDbadKvSu++wyGb4+sPDQStsU6HuduARpusWMuarXttCRR/3y SULwJSFU8XNeRpVjhqDg+k+0lz5BZsnMdhVzJBZ/37Yqc/BZl+mhRlUUVw2xtA27rq QN+OYWpWZWox9GLz8lAo3sxOxD4Ga+BrlxWVp/CA= X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on pdx-caf-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.7 required=2.0 tests=ALL_TRUSTED,BAYES_00, DKIM_INVALID,DKIM_SIGNED autolearn=no autolearn_force=no version=3.4.0 Received: from x230.qca.qualcomm.com (88-114-240-156.elisa-laajakaista.fi [88.114.240.156]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) (Authenticated sender: kvalo@smtp.codeaurora.org) by smtp.codeaurora.org (Postfix) with ESMTPSA id 15F0A601CF; Mon, 11 Feb 2019 09:19:30 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=codeaurora.org; s=default; t=1549876773; bh=w7vNofABHkmV2IriZIaKXGIVjSCa9cvWKSQNtMH07no=; h=From:To:Cc:Subject:References:Date:In-Reply-To:From; b=EqvrERqUB688WWSutDbadKvSu++wyGb4+sPDQStsU6HuduARpusWMuarXttCRR/3y SULwJSFU8XNeRpVjhqDg+k+0lz5BZsnMdhVzJBZ/37Yqc/BZl+mhRlUUVw2xtA27rq QN+OYWpWZWox9GLz8lAo3sxOxD4Ga+BrlxWVp/CA= DMARC-Filter: OpenDMARC Filter v1.3.2 smtp.codeaurora.org 15F0A601CF Authentication-Results: pdx-caf-mail.web.codeaurora.org; dmarc=none (p=none dis=none) header.from=codeaurora.org Authentication-Results: pdx-caf-mail.web.codeaurora.org; spf=none smtp.mailfrom=kvalo@codeaurora.org From: Kalle Valo To: Ryder Lee Cc: Lorenzo Bianconi , Felix Fietkau , Roy Luo , , , , Subject: Re: [Resend PATCH] mt76: change the return type of mt76_dma_attach() References: <228fdddb9ca96e8ce861e324eb9039722cf18f49.1549850911.git.ryder.lee@mediatek.com> Date: Mon, 11 Feb 2019 11:19:28 +0200 In-Reply-To: <228fdddb9ca96e8ce861e324eb9039722cf18f49.1549850911.git.ryder.lee@mediatek.com> (Ryder Lee's message of "Mon, 11 Feb 2019 16:48:29 +0800") Message-ID: <87lg2m3cnz.fsf@codeaurora.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.5 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Ryder Lee writes: > There is no need to return 0 in mt76_dma_attach(), so switch it to void. > > Signed-off-by: Ryder Lee When you send a new version mark it as v2: https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches#patch_version_missing And add a changelog: https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches#changelog_missing No need to resend because of this, but please do remember this in the future. -- Kalle Valo