Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
From:   Julian Stecklina <jsteckli@amazon.de>
To:     Baoquan He <bhe@redhat.com>
Cc:     Julian Stecklina <js@alien8.de>, <x86@kernel.org>,
        Thomas Gleixner <tglx@linutronix.de>,
        Ingo Molnar <mingo@redhat.com>, Borislav Petkov <bp@alien8.de>,
        <hpa@zytor.com>, <linux-kernel@vger.kernel.org>,
        <jschoenh@amazon.de>
Subject: Re: [PATCH 1/2] x86/boot: fix KASL when memmap range manipulation is used
References: <1548866403-13390-1-git-send-email-js@alien8.de>
        <20190211090931.GA2501@localhost>
Date:   Mon, 11 Feb 2019 10:54:39 +0100
In-Reply-To: <20190211090931.GA2501@localhost> (Baoquan He's message of "Mon,
        11 Feb 2019 17:09:31 +0800")
Message-ID: <ciirm8zhr2ira8.fsf@u54ee758033e858cfa736.ant.amazon.com>
User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.5 (gnu/linux)
MIME-Version: 1.0
Content-Type: text/plain
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

Baoquan He <bhe@redhat.com> writes:

> On 01/30/19 at 05:40pm, Julian Stecklina wrote:
>> diff --git a/arch/x86/boot/compressed/kaslr.c b/arch/x86/boot/compressed/kaslr.c
>> index 9ed9709..5657e34 100644
>> --- a/arch/x86/boot/compressed/kaslr.c
>> +++ b/arch/x86/boot/compressed/kaslr.c
>> @@ -155,6 +155,12 @@ parse_memmap(char *p, unsigned long long *start, unsigned long long *size)
>>  	case '#':
>>  	case '$':
>>  	case '!':
>> +		/*
>> +		 * % would need some more complex parsing, because regions might
>> +		 * actually become usable for KASLR, but the simple way of
>> +		 * ignoring anything that is mentioned in % works for now.
>> +		 */
>
> This seems to make thing more complicated even though have to. One
> concern is whether we need to check the oldtype|newtype , e.g
> oldtype=reserverd, newtype=RAM, is it possible to set like that?

With the above patch the boot code will avoid using any region targeted
by % for KASLR. This does mean regions that are changed to be usable via
% are not taken into account.

Julian