Received: by 2002:ac0:946b:0:0:0:0:0 with SMTP id j40csp2393043imj; Mon, 11 Feb 2019 02:00:01 -0800 (PST) X-Google-Smtp-Source: AHgI3Ibn2VyxyoXKNLeqAEz07w03hv+/tzzLIWY0RKHRxHLzIfOCL/4FCZw0UrSdq0HrdauHXt4O X-Received: by 2002:a17:902:bd0a:: with SMTP id p10mr35691099pls.322.1549879201811; Mon, 11 Feb 2019 02:00:01 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1549879201; cv=none; d=google.com; s=arc-20160816; b=u7bmFyO8nf+v1rc7VwAHcf+kxEeo4e2FJbSX+HIKveZdeqlRRN0IPeKMYWEJQrVnNe QagymD65ZGbB6i5c+XdJDARhk2F8oEzdNNminSigmAQaszorCz/wK8uLdL3lHyfL0QTi T3nzM9CJFHqIgK6XqnF3MjhZQ6v0qk0NQMQf/jItfg1aEpZCnAjB6TC5E5nDg83ZSu7t A+b4WveC+5a78E3G8enJcc+rn7Ars+av/zKv2l4ZP8poL2Erbl9VaM/H/Sm55EzoIJvB b+vPD1t/PdxQTFR2zz54wY+FYvmZ2D/hpRw08CArBL37jGM1vqeF/qTK8Qna1YX4E+tj Zh7Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:mime-version:content-transfer-encoding :content-language:accept-language:in-reply-to:references:message-id :date:thread-index:thread-topic:subject:cc:to:from:dkim-signature; bh=r3a4oNEomQhGkgXthQKDplQWCz5F0jiy5JARVjuXcUI=; b=0EIztJ7VH0Qj0mHJoEYcbSQFrvPhjQPQ6O5w32qNXVRfV1UWgahfksmQS7uipWzVYS PPI4bcxIiHv5yNRUtpnrOtzMd6PqwuILYdD7dkXGN01WPTEM4LYb1RCmVR0Svj8DgxPi 3gAcds17DpQCVTg5f6+m57URxMR59F1iywmfa3F7v/jGYTmnAVJhe8B1OKo2m9LBdAg6 WIzhNk2GXn4dL8LhWNaA+NJs4+Ff2z4kELVxzSd0LhcsmbXeymODsFtSnnblrWTCO3UG H2+wWmQzViKsyKHD6Jywh33areRl4Sbf206Gc4Agz3OcC1gCEjdidAnYUvQROs7bpabt QyiA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@nxp.com header.s=selector1 header.b=jaov2wJO; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=nxp.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id bf3si3881076plb.407.2019.02.11.01.59.46; Mon, 11 Feb 2019 02:00:01 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@nxp.com header.s=selector1 header.b=jaov2wJO; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=nxp.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726365AbfBKJ6O (ORCPT + 99 others); Mon, 11 Feb 2019 04:58:14 -0500 Received: from mail-eopbgr150082.outbound.protection.outlook.com ([40.107.15.82]:55296 "EHLO EUR01-DB5-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1726045AbfBKJ6O (ORCPT ); Mon, 11 Feb 2019 04:58:14 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nxp.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=r3a4oNEomQhGkgXthQKDplQWCz5F0jiy5JARVjuXcUI=; b=jaov2wJO7nC6B05AKJ2mESYa8WDF47DyyQdpPnwKHLQQ0scNz3/i1suMNp8YpJvZagp3ab8RxrrktCw/uuUYY5kHNKGZTLLvE/tZX9+a58cGIKtffeBeFdnuK1GkZ0RXr1CAfQVg+u4D7+iOwagef5BybiDsTU0Ip8OYHphZVAM= Received: from VI1PR04MB4558.eurprd04.prod.outlook.com (20.177.55.216) by VI1SPR01MB0363.eurprd04.prod.outlook.com (20.178.120.74) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.1601.19; Mon, 11 Feb 2019 09:58:04 +0000 Received: from VI1PR04MB4558.eurprd04.prod.outlook.com ([fe80::b0fe:dee7:b2d3:9355]) by VI1PR04MB4558.eurprd04.prod.outlook.com ([fe80::b0fe:dee7:b2d3:9355%5]) with mapi id 15.20.1601.023; Mon, 11 Feb 2019 09:58:04 +0000 From: Jun Li To: Heikki Krogerus , Greg Kroah-Hartman CC: Andy Shevchenko , Chen Yu , Hans de Goede , "linux-usb@vger.kernel.org" , "linux-kernel@vger.kernel.org" Subject: RE: [PATCH v2 6/9] usb: roles: Find the muxes by also matching against the device node Thread-Topic: [PATCH v2 6/9] usb: roles: Find the muxes by also matching against the device node Thread-Index: AQHUuLVSCFz0E1ZQKUWUh+dd3nT5iqXablHw Date: Mon, 11 Feb 2019 09:58:04 +0000 Message-ID: References: <20190130160259.46919-1-heikki.krogerus@linux.intel.com> <20190130160259.46919-7-heikki.krogerus@linux.intel.com> In-Reply-To: <20190130160259.46919-7-heikki.krogerus@linux.intel.com> Accept-Language: zh-CN, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: spf=none (sender IP is ) smtp.mailfrom=jun.li@nxp.com; x-originating-ip: [119.31.174.71] x-ms-publictraffictype: Email x-microsoft-exchange-diagnostics: 1;VI1SPR01MB0363;6:nBAC+ZghSAYqjSoPAu/1FaqygnVc7CFvSOFVsN66ObYh1aHNL9lApAWHRCuC4gRfSnGzDbWCIGWotO53f6mhAfkvBoJ+TFTID3E2qlg6NmfYC7CCTlOO5BkAHoru2Eqkb6MKBWwjOdoZ67g6ouBmnfrOdLbVx9aYADjSmYLUqMS/HWpG7QLSS9+Ph39iqfJSziV3YpSbIxvfP5VYNaV9BTFb7kWjAXsLN3ngj5MQYOnzx4wdoZxdHU/S1lqAa6wL8cSSotnJFFgIZm727sgpN7bDW2N/rY2mQIFlgudppvUUmD37khM4bTFceXMNKzs73UwQMz8SEzlVwLi3crmrBc6Tc8edRbZSVEerwDSFnsAJUzNxcIEdpMwvd3/ijwYIUgQb/91T8uOAYSLqo8vIWS8p+ECDAiZ8pX2zUs2M484sIsb9yEjKniE0c3EkoDL+5B0rwCUE6IHhquem3BHiLw==;5:cbjCRi75EvgmNfCLsblWoHzPS4P1c6VYh+WPeAH6RmLMsDvm94UKo78V1DBeCZqbutsJo5oXgDhUuo3ooeRoIzqDvLaV/VOMGy7VbiTMTI9vnFcga8bAwpIZGVsZMpLXtyzhtnm67uBRRPJP73yPuQAbneQYjcPZUm2CFfewp3llfaf6rYWr7IIutlnFVnDpgllZbtKqcBKNMJha86/i8Q==;7:v8zwsOGY1MxM1Azgfpy25GM94hjA3wpKYk+bUGVj0ep3mP2E0vSUq3rbt5hZovqoe/vkuJWirp4TcdUpeK1VhFA4YObnkg2YE9oKoqAU76n+Pa0ZvszE9zTOF6gNqrxRquJ8hYemozl9t86b9K+rlQ== x-ms-office365-filtering-correlation-id: 0e5b0f7b-51e1-45a4-1b5f-08d690076ab7 x-ms-office365-filtering-ht: Tenant x-microsoft-antispam: BCL:0;PCL:0;RULEID:(2390118)(7020095)(4652040)(8989299)(4534185)(4627221)(201703031133081)(201702281549075)(8990200)(5600110)(711020)(4605077)(4618075)(2017052603328)(7153060)(7193020);SRVR:VI1SPR01MB0363; x-ms-traffictypediagnostic: VI1SPR01MB0363: x-ms-exchange-purlcount: 1 x-microsoft-antispam-prvs: x-forefront-prvs: 0945B0CC72 x-forefront-antispam-report: SFV:NSPM;SFS:(10009020)(39860400002)(376002)(136003)(366004)(346002)(396003)(199004)(189003)(8676002)(478600001)(81166006)(4326008)(316002)(8936002)(486006)(229853002)(4744005)(186003)(7696005)(74316002)(71190400001)(81156014)(966005)(68736007)(446003)(66066001)(71200400001)(476003)(44832011)(11346002)(54906003)(110136005)(14454004)(55016002)(6306002)(9686003)(6436002)(2906002)(102836004)(305945005)(25786009)(105586002)(106356001)(76176011)(7736002)(6246003)(97736004)(26005)(6116002)(3846002)(33656002)(6506007)(99286004)(86362001)(53936002)(256004);DIR:OUT;SFP:1101;SCL:1;SRVR:VI1SPR01MB0363;H:VI1PR04MB4558.eurprd04.prod.outlook.com;FPR:;SPF:None;LANG:en;PTR:InfoNoRecords;A:1;MX:1; received-spf: None (protection.outlook.com: nxp.com does not designate permitted sender hosts) x-ms-exchange-senderadcheck: 1 x-microsoft-antispam-message-info: qkugnWVz2rJdTdLRib9efTNS4TzjbEQKsERIAyVwhC/Ato21DtP3dUjularo6/6x6VSQ3/Y4zxLKqz5QojzyPTrAciCXeF2GJwJhhYwEZevkk+/t7wve8iwFP8Gxt9Z3soDaled58hRR0m2FNi/hobGTB0DyoGD/kWQDCZltYeH7P4clSh2Mxon/JpSx8z1YvpvvdjJqa+hCL5oohXbxd7pmfQfSyrcb8E2j/cpvsPotNe6jDC/2Mr8UzoZavDM99DeEPiKc/j+QSxtu7krzYmPeM3PdVKQm5nZXTI30tib84uvVTQIVLU3ZbXK1kejPvZUbsh+lFo+TKliup/w8fJEnztY6pA6ESFgqivyVVXS6ULSCA5JC8RklbfZmZboYhGvrReghpS4fhPz1kUvBjWdghofdBTAjHTTBKsP22IU= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: nxp.com X-MS-Exchange-CrossTenant-Network-Message-Id: 0e5b0f7b-51e1-45a4-1b5f-08d690076ab7 X-MS-Exchange-CrossTenant-originalarrivaltime: 11 Feb 2019 09:58:04.7688 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635 X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1SPR01MB0363 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Heikki, > @@ -84,7 +85,12 @@ enum usb_role usb_role_switch_get_role(struct > usb_role_switch *sw) } EXPORT_SYMBOL_GPL(usb_role_switch_get_role); >=20 > -static int __switch_match(struct device *dev, const void *name) > +static int switch_fwnode_match(struct device *dev, const void *fwnode) > +{ > + return dev_fwnode(dev) =3D=3D fwnode; You missed the comment https://lkml.org/lkml/2019/1/22/437 return dev_fwnode(dev->parent) =3D=3D fwnode; Jun