Received: by 2002:ac0:946b:0:0:0:0:0 with SMTP id j40csp2525497imj; Mon, 11 Feb 2019 04:25:55 -0800 (PST) X-Google-Smtp-Source: AHgI3IYXHC1OjfmKs5Elink0kRRfw18PkZRBj3HVwBKeAay4zBATNs2F6Pv0Yg61+5GUoS3IDBig X-Received: by 2002:a62:4c5:: with SMTP id 188mr36806494pfe.130.1549887954962; Mon, 11 Feb 2019 04:25:54 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1549887954; cv=none; d=google.com; s=arc-20160816; b=Rb/d8nxWYJO1Xoy1BBowioPFjyS4etsYHiOAlT/wm1DCsgidjvKWm5ZMEnbRQTHsDk GdqYhKrSNLhchkSij6A/XVXLxqkTBNdyhPMWvmBC/7ZdQER1By6uvlltcvI0TbxgmhKI fNC2ggn1Edl0F57zvCxIq73Ay72mGKtodnc5DVkyHiRpysKhJaiKdtzLY+uFeSwNgqcw l6Tzjuc1KoE9CmkuSRyjRIHE0jVlkl+qq8ZTwBmMjEw2AGfMqCU/aaHcHEkkG5JF1ClB XMDot0V3suqHbQm17Im+AxdkS8uCFiQgqMiBnjRLiCGdDRRT/O2qoB+1g5bj6Yjb6HT4 PcXw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=P5r+7TNRpT4IOWYOkJ4Od3nYrWD71FZGJYmKpbNhmMc=; b=PyuY4ALU73UL0KD8MeYivbdojwL+jpryM8AwUOkPgtaR7jh2tfQ8BPKrCC4eLjgc2i ORgjTgE4BdrsArVZeKEn6ZV95LEOkR4s14q7ci+fuMrM6Scs923h4gmTL0kUUDOLPWUd 5ZczIN21wpTghXMskAQ9RlIHFSK5F6I9YZg3DGFyiXYnBaTY6vov86NN/Ts/ZEKrouEN nZd1Pt7u7tD+n61IlDtKZDNcCzo00kPuvTIcP8G+PfMc66bhBIshJIg7jbF9iyC+L7/g qygNmbQWVdNi9sjf185n908Ts4YGajwpBvLX72/3OH6Fc1dbD/3foRzszPKoooxPQpNZ tpoA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@lightnvm-io.20150623.gappssmtp.com header.s=20150623 header.b=hWGNlgok; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id c4si6761741plr.430.2019.02.11.04.25.39; Mon, 11 Feb 2019 04:25:54 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@lightnvm-io.20150623.gappssmtp.com header.s=20150623 header.b=hWGNlgok; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727340AbfBKMZ0 (ORCPT + 99 others); Mon, 11 Feb 2019 07:25:26 -0500 Received: from mail-lj1-f193.google.com ([209.85.208.193]:34032 "EHLO mail-lj1-f193.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727317AbfBKMZX (ORCPT ); Mon, 11 Feb 2019 07:25:23 -0500 Received: by mail-lj1-f193.google.com with SMTP id v14-v6so8613395ljv.1 for ; Mon, 11 Feb 2019 04:25:21 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=lightnvm-io.20150623.gappssmtp.com; s=20150623; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=P5r+7TNRpT4IOWYOkJ4Od3nYrWD71FZGJYmKpbNhmMc=; b=hWGNlgok/Afol8f4prcEdIM03knAXuUS0vPIR4Hals6x65dhEhbnf2mQ1g/bMijxYo w/bDGAcgT3GK9B3tKPICceWVw6KsFTqmyLhweCa8nYGhjA22iGcI+4+nTajupEJ8mznq JcH3K71jvHWI3FDygU3iy2n4HluzEsWWXVcOLhnehicnOmJjdRE0MyO9Tz2rb1dheBBE JGwMvzTvuabjkd4RHxiQRVrFBMGexU+0UQqkQGaQhfz02iBIW9PHbj49AiPQ0nY9ZO93 68WdUOV2nx+V+ygfEwP7qjyKHz/y9QdvTPpyT62SiFpM8TaGJa1EdzNNhQYrQIPKcr+6 pJCg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=P5r+7TNRpT4IOWYOkJ4Od3nYrWD71FZGJYmKpbNhmMc=; b=otIKYt5cjAL2YM5JEV2fOLKqUBYwc+/CaHXXaHnb4087u7/RseCVAzXTSL190CkggN BDgGvi3VlqhtaDkSHYeBEGgzoltpv2sn1Nk+elg1Bbc0d+f1S8Hk5H7rPZZ4Gx+OE3i9 3MnSOHNX4cblXipiwMgNH6y7xBkz0/Y9x9GOdBZONyb6+Ip849yPTUAGQZRw0HngK44q DHUeDTde2ROQvIO6Ck7vCEOIdKmNtKFyhTUvd+TEjNXCKrOvPo/1rlRJ/TEuk7UK10x/ cHFwjY+K8OYjYsiGFO4SSeb+yWkNV4rdHEdAWbTJwEoB0nZhJWkkI4h+k22/G5jYoHXz bK/g== X-Gm-Message-State: AHQUAuYoVgdy+sgfhYbiN+yhUjfPTQc5PP+eI8rNP9cbOEpgb/P0FaKB 8MQsi+IKIWBIXK7uVyPNRyWU2z1FzXM= X-Received: by 2002:a2e:2416:: with SMTP id k22-v6mr8066565ljk.80.1549887921125; Mon, 11 Feb 2019 04:25:21 -0800 (PST) Received: from skyninja.webspeed.dk (2-111-91-225-cable.dk.customer.tdc.net. [2.111.91.225]) by smtp.gmail.com with ESMTPSA id d70sm2278481lfe.14.2019.02.11.04.25.18 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Mon, 11 Feb 2019 04:25:18 -0800 (PST) From: =?UTF-8?q?Matias=20Bj=C3=B8rling?= To: axboe@fb.com Cc: linux-block@vger.kernel.org, linux-kernel@vger.kernel.org, Andy Shevchenko , =?UTF-8?q?Matias=20Bj=C3=B8rling?= Subject: [GIT PULL 3/8] lightnvm: Use u64 instead of __le64 for CPU visible side Date: Mon, 11 Feb 2019 13:25:04 +0100 Message-Id: <20190211122509.19910-4-mb@lightnvm.io> X-Mailer: git-send-email 2.19.1 In-Reply-To: <20190211122509.19910-1-mb@lightnvm.io> References: <20190211122509.19910-1-mb@lightnvm.io> MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Andy Shevchenko Sparse complains about using strict data types: drivers/lightnvm/pblk-read.c:254:43: warning: incorrect type in assignment (different base types) drivers/lightnvm/pblk-read.c:254:43: expected restricted __le64 drivers/lightnvm/pblk-read.c:254:43: got unsigned long long [unsigned] [usertype] drivers/lightnvm/pblk-read.c:255:29: warning: cast from restricted __le64 drivers/lightnvm/pblk-read.c:268:29: warning: cast from restricted __le64 drivers/lightnvm/pblk-read.c:328:41: warning: incorrect type in assignment (different base types) drivers/lightnvm/pblk-read.c:328:41: expected restricted __le64 drivers/lightnvm/pblk-read.c:328:41: got unsigned long long [unsigned] [usertype] In the code it seems explicit that lba_list_mem and lba_list_media members of struct pblk_pr_ctx are used on CPU side, which means they should not be of strict types. Change types of lba_list_mem and lba_list_media members to be u64. Signed-off-by: Andy Shevchenko Reviewed-by: Javier González Signed-off-by: Matias Bjørling --- drivers/lightnvm/pblk.h | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/lightnvm/pblk.h b/drivers/lightnvm/pblk.h index 85e38ed62f85..0dd697ea201e 100644 --- a/drivers/lightnvm/pblk.h +++ b/drivers/lightnvm/pblk.h @@ -131,8 +131,8 @@ struct pblk_pr_ctx { unsigned int bio_init_idx; void *ppa_ptr; dma_addr_t dma_ppa_list; - __le64 lba_list_mem[NVM_MAX_VLBA]; - __le64 lba_list_media[NVM_MAX_VLBA]; + u64 lba_list_mem[NVM_MAX_VLBA]; + u64 lba_list_media[NVM_MAX_VLBA]; }; /* Pad context */ -- 2.19.1