Received: by 2002:ac0:946b:0:0:0:0:0 with SMTP id j40csp2558446imj; Mon, 11 Feb 2019 05:02:39 -0800 (PST) X-Google-Smtp-Source: AHgI3IZwiXTH6C/3i1eZfXgySHzL5FNQ0SbUXrj+MPSuc3yEdng1Zb6PlEmIW4pqww2Lx7aoFcwf X-Received: by 2002:a63:4c07:: with SMTP id z7mr18715026pga.319.1549890158945; Mon, 11 Feb 2019 05:02:38 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1549890158; cv=none; d=google.com; s=arc-20160816; b=iOpfVdWorYnTrGWgaSA7pxg9/XMSo8UThqySb45GNTXGF88HqCo2pWdIfXuf9+/8Tz Pd9q1OHiHhT5HP9r5ozwHf8s+URuZWzcn6hwi9ylbZZulxX/oSolueBZ23AHMiVjrAfb cvEiJh7Mf5L3H0GejpvdxO93ajfASOnGjY6M/F9k0nojA7gnTeuxoqmj7cobmptgV1wN LzstK4ngTEWehTppXYLEjhhSNId8MMV/0y2uCWwTVZltS6c0nXtjFA82IRw48goJMtcD u73eJCBHspnml0F3CMaNkF2jEGdXjmXCZum+igSSSdNLvFRMxSvGhUmETYOi96BUTfzO c9bQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:mime-version:content-transfer-encoding :references:in-reply-to:date:cc:to:from:subject:message-id; bh=ZzEoZGzo/iQoux9ebL1H1Dv5gCFyrv6JFV2WoSg2uFI=; b=XRrInIB+JO5liF2OK/SU/xURAiPQNtX7DRC0/b5qky2FOhIhPtKNhJsi05G8xTU5o8 f3bATNG4nfdi50RwFMASJ1e7O4HjWxzMNPldFPHwAOI0NUXzDQs33f+OZ6g2NlEmrwIk NdFCv7kW/0KwQF+nKhyLDgpGZZbmF22XYI2eMx5hjM04VlwWMyC4Z5LFZIHJzYE4hM8C e+zK6M7iRAnqKG5WX6i1C66vWPocJZVVBQYCYGqTMCLLQI29fKW1e47rH6FwbEyXbOeo pTVOq8JucM7G48jrWK9tV9lPK9uHkSFN4NVYSkh3i6jtvREGDj6fmoccuKKGJ1lZ9642 jmtg== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id q20si9158170pll.255.2019.02.11.05.02.07; Mon, 11 Feb 2019 05:02:38 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727717AbfBKNB3 (ORCPT + 99 others); Mon, 11 Feb 2019 08:01:29 -0500 Received: from mailgw01.mediatek.com ([210.61.82.183]:32559 "EHLO mailgw01.mediatek.com" rhost-flags-OK-FAIL-OK-FAIL) by vger.kernel.org with ESMTP id S1727106AbfBKNB3 (ORCPT ); Mon, 11 Feb 2019 08:01:29 -0500 X-UUID: 49f011a418914b5192e845bbbea1c649-20190211 X-UUID: 49f011a418914b5192e845bbbea1c649-20190211 Received: from mtkcas08.mediatek.inc [(172.21.101.126)] by mailgw01.mediatek.com (envelope-from ) (mhqrelay.mediatek.com ESMTP with TLS) with ESMTP id 1535236211; Mon, 11 Feb 2019 21:01:21 +0800 Received: from MTKCAS06.mediatek.inc (172.21.101.30) by mtkmbs08n1.mediatek.inc (172.21.101.55) with Microsoft SMTP Server (TLS) id 15.0.1395.4; Mon, 11 Feb 2019 21:01:20 +0800 Received: from [172.21.84.99] (172.21.84.99) by MTKCAS06.mediatek.inc (172.21.101.73) with Microsoft SMTP Server id 15.0.1395.4 via Frontend Transport; Mon, 11 Feb 2019 21:01:20 +0800 Message-ID: <1549890080.22817.24.camel@mtksdccf07> Subject: Re: [PATCH v6 1/6] irqchip/mtk-sysirq: support 4 interrupt parameters for sysirq From: Seiya Wang To: Marc Zyngier CC: Matthias Brugger , Erin Lo , Rob Herring , Mark Rutland , Thomas Gleixner , Jason Cooper , Greg Kroah-Hartman , Stephen Boyd , , srv_heupstream , , , , , , , , Date: Mon, 11 Feb 2019 21:01:20 +0800 In-Reply-To: <868symu2ss.wl-marc.zyngier@arm.com> References: <1548317240-44682-1-git-send-email-erin.lo@mediatek.com> <1548317240-44682-2-git-send-email-erin.lo@mediatek.com> <898ca3d9-002b-e28e-fc97-86bc2538e9de@gmail.com> <626b5b46-aac7-1532-386e-2fed85bf4ad9@arm.com> <1549866929.22817.20.camel@mtksdccf07> <868symu2ss.wl-marc.zyngier@arm.com> Content-Type: text/plain; charset="UTF-8" X-Mailer: Evolution 3.2.3-0ubuntu6 Content-Transfer-Encoding: 7bit MIME-Version: 1.0 X-MTK: N Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, 2019-02-11 at 08:50 +0000, Marc Zyngier wrote: > On Mon, 11 Feb 2019 06:35:29 +0000, > Seiya Wang wrote: > > > > On Thu, 2019-02-07 at 15:52 +0000, Marc Zyngier wrote: > > > On 07/02/2019 15:47, Marc Zyngier wrote: > > > > On 07/02/2019 15:20, Matthias Brugger wrote: > > > >> > > > >> > > > >> On 24/01/2019 09:07, Erin Lo wrote: > > > >>> From: Seiya Wang > > > >>> > > > >>> To support partitioned PPIs, 4 interrupt parameters should be valid > > > >>> for sysirq. > > > >>> > > > >>> Signed-off-by: Seiya Wang > > > >>> Signed-off-by: Erin Lo > > > >>> --- > > > >>> drivers/irqchip/irq-mtk-sysirq.c | 4 ++-- > > > >>> 1 file changed, 2 insertions(+), 2 deletions(-) > > > >>> > > > >>> diff --git a/drivers/irqchip/irq-mtk-sysirq.c b/drivers/irqchip/irq-mtk-sysirq.c > > > >>> index 90aaf19..282736a 100644 > > > >>> --- a/drivers/irqchip/irq-mtk-sysirq.c > > > >>> +++ b/drivers/irqchip/irq-mtk-sysirq.c > > > >>> @@ -81,7 +81,7 @@ static int mtk_sysirq_domain_translate(struct irq_domain *d, > > > >>> unsigned int *type) > > > >>> { > > > >>> if (is_of_node(fwspec->fwnode)) { > > > >>> - if (fwspec->param_count != 3) > > > >>> + if (fwspec->param_count != 3 && fwspec->param_count != 4) > > > >> > > > >> Where is this 4th parameter used? > > > > > > > > https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/Documentation/devicetree/bindings/interrupt-controller/arm,gic-v3.txt#n14 > > > Sorry, I fired Send way too early. > > > > > > What I wanted to add is that it is not clear to me why this change would > > > be required here, as this driver only supports SPIs. It could be fixed > > > by just relaxing the binding itself. > > > > > > Thanks, > > > > > > M. > > > > Do you mean that we should change #interrupt-cells back to 3 for sysirq > > and remove the 4th parameters of every spi interrupts in mt8183.dtsi > > (i.e. 3 parameters for spi, 4 for ppi) such that we can discard this > > patch? > > It is more subtle than that: > > - PPIs must have the affinity parameter in their int-spec (since you > need that for the PMU) > > - SPIs that are directly routed to the GIC must also have the affinity > parameter (although set to zero). > > - SPIs that are routed via the sysirq block (or any other) can use the > 3 parameter variant, as they are not resolved in the context of the > GIC, but in that of the sysirq. > > But in short, yes. You should be able to drop this patch altogether. > > > If yes, we may need some time to verify the change before resending the > > patch. > > That's absolutely fine. > > Thanks, > > M. > Thanks for the detailed descriptions. We will remove this patch and resend again.