Received: by 2002:ac0:946b:0:0:0:0:0 with SMTP id j40csp2580120imj; Mon, 11 Feb 2019 05:22:24 -0800 (PST) X-Google-Smtp-Source: AHgI3IYL7qbmwCBvKpcrQzf2xYd1zcfdgmgY4UtFwtgu2cTt4RpxzE2OPIsFoIspitELWNwXI0tQ X-Received: by 2002:a17:902:243:: with SMTP id 61mr22129001plc.249.1549891343999; Mon, 11 Feb 2019 05:22:23 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1549891343; cv=none; d=google.com; s=arc-20160816; b=iBWdE/Hlojwwi/ow0i9CNI7qOpHyu5FqQotWolsfCZ0K5Cfqns5LKZ2Yg0i+ygmdKk Swuu7wZx1HSVnu6WjzJTiJPJpufYSAHFv5AR+IzRwdgbrAyJqmNvA4+FjCJh2DBxsZ8E Lwtj89ELE0CzlBP2+4etKcZ3QlKYBHWcchMwqY2wSC+HFP3Kp5QjZm8w3lor5szVcyDF XBlgaXf4dJCYtN8F9j92bsPJGnrCQevhOa7Yrp8YZdNLJYFx+m0XegS3ITbBTHMNK38P PNsFowwfi9y2N3NvEsgBMhwiAqmmO2UXGEXdM2K+8+erpaAEiPpd2aByN+RMGMtv5evT B78A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:mime-version:message-id:date:references :in-reply-to:subject:cc:to:from; bh=w7jhyOlO066tOMebUItHmulG/SA0ImNX+uqk0Ytp+mc=; b=SpR2XFh5IZK7TJXPxQNRxaHOOk0XqzyGRck0GrSTaS5dbFD0k1/53CGwd1pCjvC3IP IuTZ2z+LaJDgwGH2J5cRkvzWk0RpcyUw98ADM+d2DVf+hdyp7cKKPzHSum3z4BEDMQB4 HfNDOvb7ZNZNvtxD5ff4gZ8SdpGFf8TKDo7h9q7hCm3YZzyH67k0QpgAj5gPStrb956D q8eTd785SPnurJ7FFJ2YNFfaGZ6SnKombnM+X69eoApYQTEOXcnvWtgq7Vy2gSziyPAT HfH8CnXP1Ou4d/Tdco6A2BOlSHSCbd+sfJTKbQJmqlqoGg4Hk23uIbuNc47+ZchA71tG kLPQ== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=intel.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id d13si1230050pgh.196.2019.02.11.05.22.07; Mon, 11 Feb 2019 05:22:23 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=intel.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728022AbfBKNV1 (ORCPT + 99 others); Mon, 11 Feb 2019 08:21:27 -0500 Received: from mga03.intel.com ([134.134.136.65]:41533 "EHLO mga03.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727768AbfBKNUS (ORCPT ); Mon, 11 Feb 2019 08:20:18 -0500 X-Amp-Result: UNSCANNABLE X-Amp-File-Uploaded: False Received: from fmsmga003.fm.intel.com ([10.253.24.29]) by orsmga103.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 11 Feb 2019 05:20:16 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.58,358,1544515200"; d="asc'?scan'208";a="132677991" Received: from pipin.fi.intel.com (HELO localhost) ([10.237.72.175]) by FMSMGA003.fm.intel.com with ESMTP; 11 Feb 2019 05:20:12 -0800 From: Felipe Balbi To: Pawel Laszczak , Greg KH Cc: "devicetree\@vger.kernel.org" , "mark.rutland\@arm.com" , "linux-usb\@vger.kernel.org" , "hdegoede\@redhat.com" , "heikki.krogerus\@linux.intel.com" , "andy.shevchenko\@gmail.com" , "robh+dt\@kernel.org" , "rogerq\@ti.com" , "linux-kernel\@vger.kernel.org" , "jbergsagel\@ti.com" , "nsekhar\@ti.com" , "nm\@ti.com" , Suresh Punnoose , "peter.chen\@nxp.com" , Pawel Jez , Rahul Kumar Subject: RE: [PATCH v3 2/6] usb:common Separated decoding functions from dwc3 driver. In-Reply-To: References: <1548935553-452-1-git-send-email-pawell@cadence.com> <1548935553-452-3-git-send-email-pawell@cadence.com> <20190204114502.GA28608@kroah.com> <87y36vmyeb.fsf@linux.intel.com> Date: Mon, 11 Feb 2019 15:20:04 +0200 Message-ID: <87sgwu5unv.fsf@linux.intel.com> MIME-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha256; protocol="application/pgp-signature" Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org --=-=-= Content-Type: text/plain Content-Transfer-Encoding: quoted-printable Hi, Pawel Laszczak writes: >>>> +/** >>>> + * usb_decode_ctrl - Returns human readable representation of control= request. >>>> + * @str: buffer to return a human-readable representation of control = request. >>>> + * This buffer should have about 200 bytes. >>> >>> "about 200 bytes" is not very specific. >>> >>> Pass in the length so we know we don't overflow it. >> >>agree. > I also agree and I will add such parameter.=20 https://git.kernel.org/pub/scm/linux/kernel/git/balbi/usb.git/commit/?h=3Dn= ext&id=3D7790b3556fccc555ae422f1576e97bf34c8ab8b6 =2D-=20 balbi --=-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAEBCAAdFiEElLzh7wn96CXwjh2IzL64meEamQYFAlxhdoQACgkQzL64meEa mQb5xg/+L1jMjt8wc4bizrfHHLF4BcSWh3E63cm3aukB/l/O8A+eCOkarrfXNeG5 4fSJJmUo6HHFPbVqXUa5sQDY/8TOunHtrUIeJLAVBwXsYcJgld5ii6y/F8q3Ehdv X+bw1bg3USH1nkfj/xIOAEbD0z5IyrHKr7HiJNF2wWC4TPwyUS/yinQIMUDiEg+k Xj4x/fT3ddVqvWVysHd/QoEqWFk5K3Neltv6aPLG2aByh2MU7+TrRDv1mzcqlVpD SZjxGSjF05mFhT8Hs3YZMH41CBBwzlta5foNIF0CYFDEjjbn369z4ihAN3UeK0Ae Dmvh2UzDkZUPSAmp06zKRW1Hrm87pep9OsFBecr0I5HEVVlXxNSCCtiRTm72RCEz pvxz0sMepbI03SSYbJ/jJQJeKuZ00FrgaAeW+X2PIz9TxtiW9vDRsPLLKvezBIes 1m/Zs7u2vaTsulSMQWnRsN7gFtDv7w2aEonOtarysTlNZy5ZQjCp0G8XwgnDPPkH uRMmIn4JwsEPpsrocvrFTrCSHQy7c6WfnY7ExCAM3svGf90DjRZPzCLZCm30tQKB 27Qt6AU68Yl762ZoVpFI9LgN/QzYMN8T9/v9VFgDDzo4IUxoEEsHYvgfKvJz+2hq jD2KcIGwRoD2gkCFe4b+lOWcSdj3fctFXk3yx5XQCFV0KU7dmIU= =rSxT -----END PGP SIGNATURE----- --=-=-=--