Received: by 2002:ac0:946b:0:0:0:0:0 with SMTP id j40csp2584395imj; Mon, 11 Feb 2019 05:26:32 -0800 (PST) X-Google-Smtp-Source: AHgI3IYh/PDr5IT4mF3gOhQu6+IDr9O01gteHCMvI7Ny8Qw0OwH3HK7AICvEMa1DIp9jWtHKMrwv X-Received: by 2002:a65:46c9:: with SMTP id n9mr9814785pgr.254.1549891592318; Mon, 11 Feb 2019 05:26:32 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1549891592; cv=none; d=google.com; s=arc-20160816; b=xsku6dvoDBkDw7pXWxqJZvb27PmHBYq2HvirvmFzVQhY5sMQiL1EqlNLrLEj/OXCJK XrSBhC79NC+lqqywr/I6jr7qlz6JOpwDVVS6022yDOfzr/IvCrHhKqeM07M9v+122gTY GPgW3VpO1A94fX549a40hfRIPAYIGv/5siNydH9J8hn09G0d8y8oISgRY6F+Q1vxrCn1 8DKnJ+u+s0hsP7R8K5HvNwerxCHQG4wEYRol5kCekiajRw0errsYi62fgYM1L/y0i2SN ATACAPWNDryWmyfuSdZe7PIZl8lsQ+dXSeMC65BIT0XkwHG+ObXyrIrkYYgtAMMB1IU+ sO2w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from; bh=SgP19XarE8PRA+eG7FyF3K1U+H/9VeS73q2gIwMFuSA=; b=dxePVhat8H2OuEHKn3OWB0RR3ipTL8sHlDVOdRNSvM5QB9YO1xBHKrEoRUBKXstmPe q6golwqYAqqosojGOFS2zxGAbfBQqmx1ZrO8vZJfGmTT6REidBkIXsygjqv2mWHANZ7Q 4lPWrIn2HqxjyscemKtaVQQ8rcsk8YQUERjrlogYdNqJACmp/YP6rqxd6gJOpS5iCt3Y 56frXMgdKx4SDLVgIHfLwJoeubi55lK2Xe54tyD72iJyFN7nQivBnvhCVt7JHSboB2gz NV+uM7u2LuX4PQ1JfiVNVO/02VGbn465+pDSVuglJ+EY8YMPJnGbADYn1qCeCWBodfJ7 wZ9g== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id c10si10558106pla.173.2019.02.11.05.26.16; Mon, 11 Feb 2019 05:26:32 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728058AbfBKNYm (ORCPT + 99 others); Mon, 11 Feb 2019 08:24:42 -0500 Received: from relay3-d.mail.gandi.net ([217.70.183.195]:52043 "EHLO relay3-d.mail.gandi.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728008AbfBKNYi (ORCPT ); Mon, 11 Feb 2019 08:24:38 -0500 X-Originating-IP: 90.88.22.177 Received: from localhost (aaubervilliers-681-1-80-177.w90-88.abo.wanadoo.fr [90.88.22.177]) (Authenticated sender: thomas.petazzoni@bootlin.com) by relay3-d.mail.gandi.net (Postfix) with ESMTPSA id D5EDE6000D; Mon, 11 Feb 2019 13:24:35 +0000 (UTC) From: Thomas Petazzoni To: Adrian Hunter , Kishon Vijay Abraham I , Ulf Hansson , Thierry Reding , Jonathan Hunter Cc: linux-mmc@vger.kernel.org, linux-kernel@vger.kernel.org, linux-tegra@vger.kernel.org, Faiz Abbas , Thomas Petazzoni , Thierry Reding Subject: [PATCH v2 3/3] mmc: sdhci-tegra: drop ->get_ro() implementation Date: Mon, 11 Feb 2019 14:23:42 +0100 Message-Id: <20190211132342.31009-4-thomas.petazzoni@bootlin.com> X-Mailer: git-send-email 2.20.1 In-Reply-To: <20190211132342.31009-1-thomas.petazzoni@bootlin.com> References: <20190211132342.31009-1-thomas.petazzoni@bootlin.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org The SDHCI core is know properly checking for the state of a WP GPIO, so there is no longer any need for the sdhci-tegra code to implement ->get_ro() using mmc_gpio_get_ro(). Signed-off-by: Thomas Petazzoni Tested-by: Thierry Reding Acked-by: Thierry Reding --- Changes since v1: - Added Tested-by/Acked-by from Thierry Reding Note: this patch has only been compiled tested, as I don't have the hardware to test it. --- drivers/mmc/host/sdhci-tegra.c | 9 --------- 1 file changed, 9 deletions(-) diff --git a/drivers/mmc/host/sdhci-tegra.c b/drivers/mmc/host/sdhci-tegra.c index e6ace31e2a41..6ed7323bf030 100644 --- a/drivers/mmc/host/sdhci-tegra.c +++ b/drivers/mmc/host/sdhci-tegra.c @@ -237,11 +237,6 @@ static void tegra210_sdhci_writew(struct sdhci_host *host, u16 val, int reg) } } -static unsigned int tegra_sdhci_get_ro(struct sdhci_host *host) -{ - return mmc_gpio_get_ro(host->mmc); -} - static bool tegra_sdhci_is_pad_and_regulator_valid(struct sdhci_host *host) { struct sdhci_pltfm_host *pltfm_host = sdhci_priv(host); @@ -837,7 +832,6 @@ static void tegra_sdhci_voltage_switch(struct sdhci_host *host) } static const struct sdhci_ops tegra_sdhci_ops = { - .get_ro = tegra_sdhci_get_ro, .read_w = tegra_sdhci_readw, .write_l = tegra_sdhci_writel, .set_clock = tegra_sdhci_set_clock, @@ -893,7 +887,6 @@ static const struct sdhci_tegra_soc_data soc_data_tegra30 = { }; static const struct sdhci_ops tegra114_sdhci_ops = { - .get_ro = tegra_sdhci_get_ro, .read_w = tegra_sdhci_readw, .write_w = tegra_sdhci_writew, .write_l = tegra_sdhci_writel, @@ -947,7 +940,6 @@ static const struct sdhci_tegra_soc_data soc_data_tegra124 = { }; static const struct sdhci_ops tegra210_sdhci_ops = { - .get_ro = tegra_sdhci_get_ro, .read_w = tegra_sdhci_readw, .write_w = tegra210_sdhci_writew, .write_l = tegra_sdhci_writel, @@ -980,7 +972,6 @@ static const struct sdhci_tegra_soc_data soc_data_tegra210 = { }; static const struct sdhci_ops tegra186_sdhci_ops = { - .get_ro = tegra_sdhci_get_ro, .read_w = tegra_sdhci_readw, .write_l = tegra_sdhci_writel, .set_clock = tegra_sdhci_set_clock, -- 2.20.1