Received: by 2002:ac0:946b:0:0:0:0:0 with SMTP id j40csp2651658imj; Mon, 11 Feb 2019 06:29:54 -0800 (PST) X-Google-Smtp-Source: AHgI3IaCgDR7kSI2Zycuv1mqqsL5aBLWr5uMWLJK65uvX0UZuR2iR3M4PNI+q6AkpGr6in1t07FA X-Received: by 2002:a17:902:b20e:: with SMTP id t14mr38055613plr.128.1549895394429; Mon, 11 Feb 2019 06:29:54 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1549895394; cv=none; d=google.com; s=arc-20160816; b=EoyuymaPPwo3ba+FlsMo/Ph9VWJyIoofct6R/bS1V6axIZoGHP4zi9VIYsyTXfuozg ETEH5EGnC6sCq+Ppa7+wgColgv5eRtmQSenorO40Lxlzdh3OvaCMPFbKXgFgMTYIxtdx qHETUhtQxHK2rGW2R9BTgF3qU8ACIhTv36iIp2de/7F4iSq7DCBgXumwp3LldNC+6cHN PKSuQYkBhVNGOKVwa4fLXhk9C2DdfsgdyV7LaRx5/ARDc2WIlbJC7R+08KBQBv6X7MO0 2xLb9+e2A+qV5KH88uNBzcu5NudZmbM8P0k5jWx+0178k8iQFr65xj1eyPtLz33/KX3/ yH0Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :user-agent:references:in-reply-to:message-id:date:subject:cc:to :from:dkim-signature; bh=GoWPbpLQkfsaFw0av5f5Ug/0w5JhpxT2Ytb4GStGIqM=; b=bGw/PcZo1gH10bX3z+DG/cGCJ2gtrfI0ix0qhrFHMVdX0ZeeVV4vgNgbatpb7nlGaP D/c+XtPbEJ4GbR4QNEnaEBl9OOO7qLr/xx8IYmuS2qPnL/mnt5Rtlb5o65P63MFfOW1t Elk/cqxmhDUvli4kiN884cycC79nw19NsKm19zl8TUig5Npq7wOfzDhCopONooX7DE0L wuGpQ4GUGvRgbBNV0MlPVGTINg2DxTWSb8xxZJJGpF7fJXHiUdPQeWWMblyVFHdC5ukj 5EtF3r/c7FVGwUpCajVyHUnQnBDBcQV+QcvrXj5SCmbc+47srTuf8ZrdjYc5aXT5SWyY k+iA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=GcTmoiBr; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id 204si9551740pga.383.2019.02.11.06.29.38; Mon, 11 Feb 2019 06:29:54 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=GcTmoiBr; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729563AbfBKO02 (ORCPT + 99 others); Mon, 11 Feb 2019 09:26:28 -0500 Received: from mail.kernel.org ([198.145.29.99]:60224 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1729557AbfBKO0Z (ORCPT ); Mon, 11 Feb 2019 09:26:25 -0500 Received: from localhost (5356596B.cm-6-7b.dynamic.ziggo.nl [83.86.89.107]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id BAC0120821; Mon, 11 Feb 2019 14:26:23 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1549895184; bh=89qU9cIlTqaRMDgw/aO1vPPmZkBzGA2eqlY8E/1Sqec=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=GcTmoiBrKTkvHnF5ojj+DHumSvSKtep8IbW5ZFZWdL+UcNwKkmlR1OggFSz4kTu4l BbfFg0QP1nA5ATZi7YmJNBvRRdKa4fMXY09kDxab1NYrJ0UYfojhLvaUdxjC4LYKUd qaPT++0PMgNLqm2+Zuwb9zxM6DaN5CdjaPFREjDM= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Oskari Lemmela , Akash Gajjar , Heiko Stuebner , Sasha Levin Subject: [PATCH 4.20 122/352] arm64: dts: rockchip: fix rk3399-rockpro64 regulator gpios Date: Mon, 11 Feb 2019 15:15:49 +0100 Message-Id: <20190211141853.932371833@linuxfoundation.org> X-Mailer: git-send-email 2.20.1 In-Reply-To: <20190211141846.543045703@linuxfoundation.org> References: <20190211141846.543045703@linuxfoundation.org> User-Agent: quilt/0.65 X-stable: review X-Patchwork-Hint: ignore MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org 4.20-stable review patch. If anyone has any objections, please let me know. ------------------ [ Upstream commit 690e16bada6029694740d5501025faf483d14339 ] Rockpro64 is not able boot if GPIO1_C1 pin is pulled high before loading linux kernel. In rockpro64 GPIO1_C1 pin is connected vdd_cpu_b regulator VSEL pin. Pin should be pulled down in normal operation and pulled high in suspend. PMIC LDO_REG2 is connected to touch panel connector. Rename regulator and set it to correct voltage. PCIe power is controller by GPIO1_D0. Schematics can be downloaded from: http://files.pine64.org/doc/rockpro64/rockpro64_v21-SCH.pdf Signed-off-by: Oskari Lemmela Acked-by: Akash Gajjar Signed-off-by: Heiko Stuebner Signed-off-by: Sasha Levin --- .../boot/dts/rockchip/rk3399-rockpro64.dts | 20 +++++++++++-------- 1 file changed, 12 insertions(+), 8 deletions(-) diff --git a/arch/arm64/boot/dts/rockchip/rk3399-rockpro64.dts b/arch/arm64/boot/dts/rockchip/rk3399-rockpro64.dts index 1d35f5406b5e..5bd4d69914bd 100644 --- a/arch/arm64/boot/dts/rockchip/rk3399-rockpro64.dts +++ b/arch/arm64/boot/dts/rockchip/rk3399-rockpro64.dts @@ -97,7 +97,7 @@ vcc3v3_pcie: vcc3v3-pcie-regulator { compatible = "regulator-fixed"; enable-active-high; - gpio = <&gpio1 RK_PC1 GPIO_ACTIVE_HIGH>; + gpio = <&gpio1 RK_PD0 GPIO_ACTIVE_HIGH>; pinctrl-names = "default"; pinctrl-0 = <&pcie_pwr_en>; regulator-name = "vcc3v3_pcie"; @@ -293,12 +293,12 @@ }; }; - vcc2v8_dvp: LDO_REG2 { - regulator-name = "vcc2v8_dvp"; + vcc3v0_touch: LDO_REG2 { + regulator-name = "vcc3v0_touch"; regulator-always-on; regulator-boot-on; - regulator-min-microvolt = <2800000>; - regulator-max-microvolt = <2800000>; + regulator-min-microvolt = <3000000>; + regulator-max-microvolt = <3000000>; regulator-state-mem { regulator-off-in-suspend; }; @@ -397,7 +397,9 @@ vdd_cpu_b: regulator@40 { compatible = "silergy,syr827"; reg = <0x40>; - fcs,suspend-voltage-selector = <0>; + fcs,suspend-voltage-selector = <1>; + pinctrl-names = "default"; + pinctrl-0 = <&vsel1_gpio>; regulator-name = "vdd_cpu_b"; regulator-min-microvolt = <712500>; regulator-max-microvolt = <1500000>; @@ -415,6 +417,8 @@ compatible = "silergy,syr828"; reg = <0x41>; fcs,suspend-voltage-selector = <1>; + pinctrl-names = "default"; + pinctrl-0 = <&vsel2_gpio>; regulator-name = "vdd_gpu"; regulator-min-microvolt = <712500>; regulator-max-microvolt = <1500000>; @@ -519,7 +523,7 @@ pcie { pcie_pwr_en: pcie-pwr-en { - rockchip,pins = <1 RK_PC1 RK_FUNC_GPIO &pcfg_pull_none>; + rockchip,pins = <1 RK_PD0 RK_FUNC_GPIO &pcfg_pull_none>; }; }; @@ -529,7 +533,7 @@ }; vsel1_gpio: vsel1-gpio { - rockchip,pins = <1 RK_PC2 RK_FUNC_GPIO &pcfg_pull_down>; + rockchip,pins = <1 RK_PC1 RK_FUNC_GPIO &pcfg_pull_down>; }; vsel2_gpio: vsel2-gpio { -- 2.19.1