Received: by 2002:ac0:946b:0:0:0:0:0 with SMTP id j40csp2665001imj; Mon, 11 Feb 2019 06:42:00 -0800 (PST) X-Google-Smtp-Source: AHgI3IbmtzfJnppRsLoGQJmO/5BJErkCMgY0W4DPf140PktWvwn6AjGux7QhB7/J2vN/StZup81t X-Received: by 2002:a65:6116:: with SMTP id z22mr33538364pgu.265.1549896120565; Mon, 11 Feb 2019 06:42:00 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1549896120; cv=none; d=google.com; s=arc-20160816; b=0cOJNW3XsYOTtk45yso/4as8OCUXAsHUV2obFx7c5rw5Ea+1LtM5oIj2fgHxc2n3t5 QvhwrnOUgYs5sAniAHGynwoh7Gr7KB2XHgE0ROy4rGOyXdNFiBwX0ShST09ByhCWChO/ 8fKEUrKsRb64osf3EU3h0Tj3klb7hh6Dt3YT07QFQu6dVsuSMD/CexyK+5u2uKqoTdkk q3wPfX9Q8bKQNZ2/HkLb2jgurjmMVeut8itDTeKV+Gl77jv9sjaDud7D98bS5KTmAbL9 M0NR1TxzlMdOZESXllqvSFUSB56GtPSMJYmiUJW15EFZ0Aim4U0KyKqOBmXYhy9tpbL2 iRcg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :user-agent:references:in-reply-to:message-id:date:subject:cc:to :from:dkim-signature; bh=F2gBtpYwxcAm3W5VYdfMe1ahNKN77mzCvDrPvVwzq/k=; b=EkEGUWLvO39esRClqSkZ6tTIAzMmdGM0ci4q1QE4uce6eyH10iEIL+K/msS+y3OBBx UpoS4OMoypBDQPMdbQnUB6CMg+NN/o259qHRUOl8e+Aanw48FNoaUU4Z+zm/2TWAEJst upOAw3xppwZoL0+oGFtyaLWx8ncGTng3uwwtGtlMyMHq+opG60DiRhFFtXBVLp8C/6Gk w+VhHOGHsl0C6PXSlzDxcP3/qqGXhHk7sdPz5m/MCDyn1G1Icn47jQjSMC98pI2GDMyt oxjKGiz2eEWqv29kd9GqJjOQKDQAfS3km6JSo0IaX8FDuvF9mRb7dgUHHweFcDMwUeMF ylOA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=zzzvzQUX; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id j21si10319024pfn.277.2019.02.11.06.41.44; Mon, 11 Feb 2019 06:42:00 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=zzzvzQUX; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1732131AbfBKOku (ORCPT + 99 others); Mon, 11 Feb 2019 09:40:50 -0500 Received: from mail.kernel.org ([198.145.29.99]:51812 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1732096AbfBKOks (ORCPT ); Mon, 11 Feb 2019 09:40:48 -0500 Received: from localhost (5356596B.cm-6-7b.dynamic.ziggo.nl [83.86.89.107]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 2B92020700; Mon, 11 Feb 2019 14:40:47 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1549896047; bh=xUFmMQWthcndDkJmIc16aTtyltelucZxbYJNPgXLW9o=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=zzzvzQUXWqU97I47b/7zxkuhU3voctc5bjHgcvyNUiMRVBsJuvEJapDfR8y3q451H WxVtdzl6ArlDBJkpN1gRcdNvjwdbcjllY25w7Lj3KlII4tJbheAUyw81hipGl3HPyO dRvyv8CnBSrfY8y2OfxmvFaybOI4XLzrGaF32Hmw= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Lukas Wunner , Andy Duan , Fabio Estevam , =?UTF-8?q?Uwe=20Kleine-K=C3=B6nig?= , Sasha Levin Subject: [PATCH 4.19 026/313] serial: fsl_lpuart: clear parity enable bit when disable parity Date: Mon, 11 Feb 2019 15:15:06 +0100 Message-Id: <20190211141855.165321028@linuxfoundation.org> X-Mailer: git-send-email 2.20.1 In-Reply-To: <20190211141852.749630980@linuxfoundation.org> References: <20190211141852.749630980@linuxfoundation.org> User-Agent: quilt/0.65 X-stable: review X-Patchwork-Hint: ignore MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org 4.19-stable review patch. If anyone has any objections, please let me know. ------------------ [ Upstream commit 397bd9211fe014b347ca8f95a8f4e1017bac1aeb ] Current driver only enable parity enable bit and never clear it when user set the termios. The fix clear the parity enable bit when PARENB flag is not set in termios->c_cflag. Cc: Lukas Wunner Signed-off-by: Andy Duan Reviewed-by: Fabio Estevam Acked-by: Uwe Kleine-König Signed-off-by: Greg Kroah-Hartman Signed-off-by: Sasha Levin --- drivers/tty/serial/fsl_lpuart.c | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/drivers/tty/serial/fsl_lpuart.c b/drivers/tty/serial/fsl_lpuart.c index 3f8d1274fc85..7d030c2e42ff 100644 --- a/drivers/tty/serial/fsl_lpuart.c +++ b/drivers/tty/serial/fsl_lpuart.c @@ -1477,6 +1477,8 @@ lpuart_set_termios(struct uart_port *port, struct ktermios *termios, else cr1 &= ~UARTCR1_PT; } + } else { + cr1 &= ~UARTCR1_PE; } /* ask the core to calculate the divisor */ @@ -1688,6 +1690,8 @@ lpuart32_set_termios(struct uart_port *port, struct ktermios *termios, else ctrl &= ~UARTCTRL_PT; } + } else { + ctrl &= ~UARTCTRL_PE; } /* ask the core to calculate the divisor */ -- 2.19.1