Received: by 2002:ac0:946b:0:0:0:0:0 with SMTP id j40csp2672197imj; Mon, 11 Feb 2019 06:49:18 -0800 (PST) X-Google-Smtp-Source: AHgI3IZq0BfXRCemmiIEz/yxgZexZ0OsRDLk+0cNPZ/gyMUEpv6st5zLX5W35SUyIy1/uYqhaXGm X-Received: by 2002:a63:c0e:: with SMTP id b14mr9177301pgl.236.1549896558921; Mon, 11 Feb 2019 06:49:18 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1549896558; cv=none; d=google.com; s=arc-20160816; b=ICajUdtTCGA1TMYVtr3QTruAIK5QG1u3KpIzp+MVkL1IjdUvzy5JSW1Nfa8RAyJq28 FhBWV5Nd0wggtcko3tO0U3+vYk6JeozJf1H8YOZfwQ/PUFLrwjdhwVMTsvhfgypN4O4X ALysd3CQa6BK+Qg3ziwojS6vqlv8/yPtWAZlwPHICPaQDTBgQBKhTpyrebUsv/5B3eiV zO4rQRPeqvjyjl7bOURQGli2YNvCEGUbq3orSLx3BmpOEqyC4N5sP3vyUh28mLmCgxtI 6PJw6bO5sm82/baB0nXeMGMyyhHdgdl1sbnA1kxNR1/gbp1Nsje/58D5lZpL3/7jpVKi ZJjw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :user-agent:references:in-reply-to:message-id:date:subject:cc:to :from:dkim-signature; bh=s9hw13yXGEUzBhZx5UNXJog+3QieXAfMaWMjfvqx49k=; b=tRyznpLd9xVKPq0stmTRsMZzWMSwnup+lyETN+5XzWK9dpOA73LhQ9u3mQdgcWjt6n ALhyeaynUz6TLWPc+2unw1HJjSVcPgTMYalXb1UDliAXFNQnxnqSPifU3uqslaCyWa/9 pBEV0KEDHHjQnXu7M/sV6CWlOrx51E4dBHU4ksVmUbMtcQV5HuGrP0+sdmYcK3clDjjx JA1LjmwwVGL7gb/uCrgpgRQG2RVS3TntLkuu+dII8XjXqqA1Md4yNgkSOp7x5gxVmnAb IZNeFFH7xNS0hiD4xYs0qYP3Xza+G7XQe85raDIhbGimKEDshgSKBQNpYGaRRnTf574s v3ww== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=zonnUTRa; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id d32si10516953pla.136.2019.02.11.06.49.02; Mon, 11 Feb 2019 06:49:18 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=zonnUTRa; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2387420AbfBKOqy (ORCPT + 99 others); Mon, 11 Feb 2019 09:46:54 -0500 Received: from mail.kernel.org ([198.145.29.99]:60082 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1732327AbfBKOqx (ORCPT ); Mon, 11 Feb 2019 09:46:53 -0500 Received: from localhost (5356596B.cm-6-7b.dynamic.ziggo.nl [83.86.89.107]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 03822206BA; Mon, 11 Feb 2019 14:46:51 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1549896412; bh=HWW2Qlin36a+ztaKDzZwp1BoRxSiwU/9hMwqITUpR5o=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=zonnUTRaUCR5e1/wWpZG3IQXMl1neqrqG7Pct62JSIJwtnSI/OYm2UR0AxLKeb5AC EOlvRM7oc7G0ezEGcVgAnO2jgvf/TNb8uOuRedoRZPl4Kb3Vxn/SNINklSBB4MKBtn zCWtoZuIRIhbWu1PeI1jEf9oT+zm1zpsQE3hRD2I= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Ondrej Jirman , Chen-Yu Tsai , Marcel Holtmann , Sasha Levin Subject: [PATCH 4.19 175/313] Bluetooth: hci_bcm: Handle deferred probing for the clock supply Date: Mon, 11 Feb 2019 15:17:35 +0100 Message-Id: <20190211141905.075101991@linuxfoundation.org> X-Mailer: git-send-email 2.20.1 In-Reply-To: <20190211141852.749630980@linuxfoundation.org> References: <20190211141852.749630980@linuxfoundation.org> User-Agent: quilt/0.65 X-stable: review X-Patchwork-Hint: ignore MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org 4.19-stable review patch. If anyone has any objections, please let me know. ------------------ [ Upstream commit 28ac03b9ac3f784c2f048a910c8d0a7a87483b66 ] On some systems that actually have the bluetooth controller wired up with an extra clock signal, it's possible the bluetooth controller probes before the clock provider. clk_get would return a defer probe error, which was not handled by this driver. Handle this properly, so that these systems can work reliably. Tested-by: Ondrej Jirman Signed-off-by: Chen-Yu Tsai Signed-off-by: Marcel Holtmann Signed-off-by: Sasha Levin --- drivers/bluetooth/hci_bcm.c | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/drivers/bluetooth/hci_bcm.c b/drivers/bluetooth/hci_bcm.c index ddbd8c6a0ceb..800132369134 100644 --- a/drivers/bluetooth/hci_bcm.c +++ b/drivers/bluetooth/hci_bcm.c @@ -907,6 +907,10 @@ static int bcm_get_resources(struct bcm_device *dev) dev->clk = devm_clk_get(dev->dev, NULL); + /* Handle deferred probing */ + if (dev->clk == ERR_PTR(-EPROBE_DEFER)) + return PTR_ERR(dev->clk); + dev->device_wakeup = devm_gpiod_get_optional(dev->dev, "device-wakeup", GPIOD_OUT_LOW); if (IS_ERR(dev->device_wakeup)) -- 2.19.1