Received: by 2002:ac0:946b:0:0:0:0:0 with SMTP id j40csp2680682imj; Mon, 11 Feb 2019 06:57:35 -0800 (PST) X-Google-Smtp-Source: AHgI3IaejNp3bC5Tot7zsYE3UnPUVd3kXQftchEUudpqHbyRbT/qwZn/izYu7FLVMnxOo35m19R8 X-Received: by 2002:a17:902:112c:: with SMTP id d41mr36729915pla.144.1549897055672; Mon, 11 Feb 2019 06:57:35 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1549897055; cv=none; d=google.com; s=arc-20160816; b=SywUbFUbvTZCuUIHFfemYp7ELtVTH96q/zIgYgXVnecvPP9QCz7PDytjwCTp0ls5lF pvCJfG9HvQaHXIJN4bQcc8k8ONQAjrz82NA30vHHsBSe704SreDwYeFZXfCC5SWhNkqu caUc0s+8Y+YmBJPVId6l9fmlKtRcWC0qoPNMs7FjTmfOjHdmboQrXozshDLsF6ju0IbV Jthg3UadTN75UE+/IlOIsdbzIi9i3ZDJ8siOL9fzLy36Yi8wlpDm8e2N+RUp8j+M5Ye2 xPMz6cuOY5/u5aSzvHZqrUJ6msmNi+vaD+yMz0qUddcfMKiBiF8PyrqrBN49tPFrM2bb HzYA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :user-agent:references:in-reply-to:message-id:date:subject:cc:to :from:dkim-signature; bh=NkHUWyQ/UktgO1MoeTrkIr6U21I/LP2EDKdQ8FY6Zwo=; b=hFTMk/O+vfne+6q2fwTIMQ13fR6kmOJh4NXPcobIQFnf+PGvPHNcfdV4MQCr8mtuDB JDaSGdAR1jO5/6390NyU4OBz1rCTCqDTmaiFtv4jws/Pj3gJrLhYVc0RHqfDhwGHIpdb nKkP80Fa7i8DU9Lt+ljy5dvXpsUi8k4EGceFsSQrpu9uwxI6d3CZ3KEpMajaTgJWewci EJjrN2UPUWHf9O7NJcC2yCmWCQPdHSaq0y4vhOiKFywqIAhdSbU+89tgGBDFOd5AfQbZ Go1abERaZi5nxRNR8JPwDtB/yxfbXMuTy1uTD/gKTO7kiQalvw4ot3YD0faOn+sFsztG ee/g== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=ilz7o2UJ; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id bb8si4870136plb.261.2019.02.11.06.57.19; Mon, 11 Feb 2019 06:57:35 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=ilz7o2UJ; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2388117AbfBKOzE (ORCPT + 99 others); Mon, 11 Feb 2019 09:55:04 -0500 Received: from mail.kernel.org ([198.145.29.99]:41958 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2388898AbfBKOzD (ORCPT ); Mon, 11 Feb 2019 09:55:03 -0500 Received: from localhost (5356596B.cm-6-7b.dynamic.ziggo.nl [83.86.89.107]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 371002229E; Mon, 11 Feb 2019 14:55:02 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1549896902; bh=xom11xpwxKrdYw40XGVEPJXMLg9TjV0H5F2+FHbkzxI=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=ilz7o2UJ/nyf9IEkIs33OxnzUvsY4hDfl99Y6ds+H2P4GGzp3t8TASCXT2c2S01d6 C2OI5dg2I0gGgnAKgRxKvFVLIhLjSuHLGeiVI7JquZoJtZo92lcGdxqK9UAREPuU6t Ul2C576pBcwkVuHEMiyLHlTC7Y6/y/cgbKPE1Ioc= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Lukas Wunner , Andy Duan , Fabio Estevam , =?UTF-8?q?Uwe=20Kleine-K=C3=B6nig?= , Sasha Levin Subject: [PATCH 4.14 018/205] serial: fsl_lpuart: clear parity enable bit when disable parity Date: Mon, 11 Feb 2019 15:16:56 +0100 Message-Id: <20190211141828.345526949@linuxfoundation.org> X-Mailer: git-send-email 2.20.1 In-Reply-To: <20190211141827.214852402@linuxfoundation.org> References: <20190211141827.214852402@linuxfoundation.org> User-Agent: quilt/0.65 X-stable: review X-Patchwork-Hint: ignore MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org 4.14-stable review patch. If anyone has any objections, please let me know. ------------------ [ Upstream commit 397bd9211fe014b347ca8f95a8f4e1017bac1aeb ] Current driver only enable parity enable bit and never clear it when user set the termios. The fix clear the parity enable bit when PARENB flag is not set in termios->c_cflag. Cc: Lukas Wunner Signed-off-by: Andy Duan Reviewed-by: Fabio Estevam Acked-by: Uwe Kleine-König Signed-off-by: Greg Kroah-Hartman Signed-off-by: Sasha Levin --- drivers/tty/serial/fsl_lpuart.c | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/drivers/tty/serial/fsl_lpuart.c b/drivers/tty/serial/fsl_lpuart.c index fd64ac2c1a74..716c33b2a11c 100644 --- a/drivers/tty/serial/fsl_lpuart.c +++ b/drivers/tty/serial/fsl_lpuart.c @@ -1482,6 +1482,8 @@ lpuart_set_termios(struct uart_port *port, struct ktermios *termios, else cr1 &= ~UARTCR1_PT; } + } else { + cr1 &= ~UARTCR1_PE; } /* ask the core to calculate the divisor */ @@ -1694,6 +1696,8 @@ lpuart32_set_termios(struct uart_port *port, struct ktermios *termios, else ctrl &= ~UARTCTRL_PT; } + } else { + ctrl &= ~UARTCTRL_PE; } /* ask the core to calculate the divisor */ -- 2.19.1