Received: by 2002:ac0:946b:0:0:0:0:0 with SMTP id j40csp2742279imj; Mon, 11 Feb 2019 07:49:31 -0800 (PST) X-Google-Smtp-Source: AHgI3IZLQN7I+K/OUsJ2k1rzbPXkDQPmetliU3Hiuhl2ActmHXJ8PsVa9qBH9MEGDzMIHSGqAQcM X-Received: by 2002:a62:6047:: with SMTP id u68mr36822761pfb.239.1549900170937; Mon, 11 Feb 2019 07:49:30 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1549900170; cv=none; d=google.com; s=arc-20160816; b=Agm6JJ+7zTYjGm7VBLWlDoDTne9rnnr+zTtkEhdkk2H4W57TUV1evRFkuzIKbRNeEB P1IsH8J4oig4OAz5W28usJlcXu8wpCWNpYEJBYSW2oqm0Fo5CjHPuMK+2AD9c9KDWBTx jYu+XD+xlqDnXRhkAKBXUi642yzG8XYswWaqNNl+fw8Xlf7wgsvFjQFYfn4mTJ9C91Rs ISB5TMkxJvRDrgCg3jlxiw/bDTCVma3JZqzhNdUlA65jSgzneoFNpZjjfKba5FI+2DPi oAFmxsOONshjYaudYD+dKjfa2sFPwJCkf0/lFgzhOsr3Teftrg3SClaJBoM0Sy5GZoIn BCog== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :user-agent:references:in-reply-to:message-id:date:subject:cc:to :from:dkim-signature; bh=ZDeQmWZgb8hsIAa433xHfV/AYw7LUt2FpboNqalcisk=; b=rDxxw4mLllJ6k5j99Bh0aTsUlLEKGV4U48yHmuub/uKoXfwsL0HyAGYSCw01Yl8k+G RPXqo2k5W2dI2d15Z/m9RadH5LoaRaTlQPXMsLlU1DaoSMwOE3OE0huiMSjVj5LS34T0 E3A0zr9cDMuSwF6ISqOOV3U01fH3ORImOCmxbFqNn3OdN4FoHhxBeuzqvFmttTc0aPQx zMS+Hf+wP7OIJTvQf8/vLPSH88DwHS3y5pgacxDyA4SuxBYuv28zu99JE0nLuIhrTvkA tc8gtaoxXNqTRj2UqcKQ5xY0RDwqj5gQOq9HHrBSvmNGJwlM46JeJGHs46M/+dq3H4NR xi0A== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=Bf20abCr; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id w6si9905830pfb.191.2019.02.11.07.49.14; Mon, 11 Feb 2019 07:49:30 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=Bf20abCr; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1732626AbfBKPro (ORCPT + 99 others); Mon, 11 Feb 2019 10:47:44 -0500 Received: from mail.kernel.org ([198.145.29.99]:52616 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1731787AbfBKOlV (ORCPT ); Mon, 11 Feb 2019 09:41:21 -0500 Received: from localhost (5356596B.cm-6-7b.dynamic.ziggo.nl [83.86.89.107]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 2C1DE20700; Mon, 11 Feb 2019 14:41:20 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1549896080; bh=2cZW44OKdeBHD9tJLSk5XCJUTECC9u5Eq+MDk7KhD5E=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=Bf20abCrzi8S+L63G8XkzQwPg6gh5EqZLYmWH22Z/bz0Sx6cpX7VCkLHktsWPjXWF OCIwd7iIFRn1dHCBa3ffGHvr0Libxi/tyJoibIz4Dnm0TEUhcB6RnnDTbIMugxxF1/ crXTMgxre9rVafDX//gyHXGgxYWi7Ht3MkLHWkHs= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Yunlei He , Jaegeuk Kim , Sasha Levin Subject: [PATCH 4.19 067/313] f2fs: move dir data flush to write checkpoint process Date: Mon, 11 Feb 2019 15:15:47 +0100 Message-Id: <20190211141858.338606130@linuxfoundation.org> X-Mailer: git-send-email 2.20.1 In-Reply-To: <20190211141852.749630980@linuxfoundation.org> References: <20190211141852.749630980@linuxfoundation.org> User-Agent: quilt/0.65 X-stable: review X-Patchwork-Hint: ignore MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org 4.19-stable review patch. If anyone has any objections, please let me know. ------------------ [ Upstream commit b61ac5b720146c619c7cdf17eff2551b934399e5 ] This patch move dir data flush to write checkpoint process, by doing this, it may reduce some time for dir fsync. pre: -f2fs_do_sync_file enter -file_write_and_wait_range <- flush & wait -write_checkpoint -do_checkpoint <- wait all -f2fs_do_sync_file exit now: -f2fs_do_sync_file enter -write_checkpoint -block_operations <- flush dir & no wait -do_checkpoint <- wait all -f2fs_do_sync_file exit Signed-off-by: Yunlei He Signed-off-by: Jaegeuk Kim Signed-off-by: Sasha Levin --- fs/f2fs/file.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/fs/f2fs/file.c b/fs/f2fs/file.c index 5474aaa274b9..fd36aa6569dc 100644 --- a/fs/f2fs/file.c +++ b/fs/f2fs/file.c @@ -220,6 +220,9 @@ static int f2fs_do_sync_file(struct file *file, loff_t start, loff_t end, trace_f2fs_sync_file_enter(inode); + if (S_ISDIR(inode->i_mode)) + goto go_write; + /* if fdatasync is triggered, let's do in-place-update */ if (datasync || get_dirty_pages(inode) <= SM_I(sbi)->min_fsync_blocks) set_inode_flag(inode, FI_NEED_IPU); -- 2.19.1