Received: by 2002:ac0:946b:0:0:0:0:0 with SMTP id j40csp2746319imj; Mon, 11 Feb 2019 07:53:24 -0800 (PST) X-Google-Smtp-Source: AHgI3Ibu+KuYtWyWQpf7Ae0af3/eZs97kCw3wJ01zeqlahDJgpmLojm4u5ix1Lf0OA2dBGO7guIT X-Received: by 2002:a17:902:27e6:: with SMTP id i35mr37559654plg.222.1549900404611; Mon, 11 Feb 2019 07:53:24 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1549900404; cv=none; d=google.com; s=arc-20160816; b=CMjjYUPgX/Gz6m1XYm3Xh7SJW6qWJpsxhhuCq11DAeD/jJZh3PsAR0X3lZ+r5B0bQb WZc0EWFo5zpb+NypAxrp7e+WSmPsQ1y579TWq8u9ugJOreSZZ2SYsn26LeKoCb5bw07P dVz2HIaxIeO/IDWI8KGm0tEZPVVgnkVowHW4Xo3kTuFH9A8+SVLs8bmjwhEs9DH2Iosq MQea0nivRal1nBcnSRNfMI/Zfy1bpIa8qaqgQ9LEl75dKhamFV/b8Jxbm1ATqC8ex7P6 eCAwuPvv6ut1+4en2SQcxdH+3ZRCLzJtJ/TCvPMknavy8Q3U/9svAOiwg4PeMMbRHh47 hslw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :user-agent:references:in-reply-to:message-id:date:subject:cc:to :from:dkim-signature; bh=qCdxgcww4dEsM0Q4OeRw0U9RRUrW0pBkuDJwHQvXJOQ=; b=V9P9yTYjMD5u2yMZk6cpxnYOe47XbSfhr6GfzhyeSBKekborU9EfhHV66RDHkxBNER Tll9HermJmwJYnMzn2pgxT6o0AmacfROTDe5W+ee59w1X07japglfvV3RtD5n/3SleIi g1sOgbebnk39ad+139TFwuyiQ1WObP4VWvVZiN5cNBj2YiTQ10We7Zf1qnRxrE33M98l ADaOpsnzfQdegxsK8W+aS33k9B9W4SnJBEe6kzABZ1pigzt9GF28u4BBkru0USfRjhiV 4AFELKUQBVYALFuSRFSdIjoSjur7dKI/EflwBCY3FVOjg5WiBAnSZlKi8GTQA+8aAafa 3FHQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=uXMYkVOz; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id r27si9637447pgl.494.2019.02.11.07.53.08; Mon, 11 Feb 2019 07:53:24 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=uXMYkVOz; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1731683AbfBKOif (ORCPT + 99 others); Mon, 11 Feb 2019 09:38:35 -0500 Received: from mail.kernel.org ([198.145.29.99]:48428 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1731695AbfBKOie (ORCPT ); Mon, 11 Feb 2019 09:38:34 -0500 Received: from localhost (5356596B.cm-6-7b.dynamic.ziggo.nl [83.86.89.107]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id E520D2081B; Mon, 11 Feb 2019 14:38:32 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1549895913; bh=usp17gc9uVjGi37sSRUw/7G1meYtMbyrASBohuiJ/yk=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=uXMYkVOzvsitE6EeSzsIX1jY+FgbbYr98TV0DnbuV3+XrFmY3gapnI/InKl6cHsFZ 4MBFxHnVea5spb288VWWJDSBs6KEvYpUb9NlkAuuF8VksbDgc7OKtUQWw9LNCNP7XM Ux5x97IOKmEiojFMSyj5YOZm0EuaWtNWqlOdUKRw= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Alexei Avshalom Lazar , Maya Erez , Kalle Valo , Sasha Levin Subject: [PATCH 4.19 012/313] wil6210: fix reset flow for Talyn-mb Date: Mon, 11 Feb 2019 15:14:52 +0100 Message-Id: <20190211141853.924280389@linuxfoundation.org> X-Mailer: git-send-email 2.20.1 In-Reply-To: <20190211141852.749630980@linuxfoundation.org> References: <20190211141852.749630980@linuxfoundation.org> User-Agent: quilt/0.65 X-stable: review X-Patchwork-Hint: ignore MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org 4.19-stable review patch. If anyone has any objections, please let me know. ------------------ [ Upstream commit d083b2e2b7db5cca1791643d036e6597af27f49b ] With current reset flow, Talyn sometimes get stuck causing PCIe enumeration to fail. Fix this by removing some reset flow operations that are not relevant for Talyn. Setting bit 15 in RGF_HP_CTRL is WBE specific and is not in use for all wil6210 devices. For Sparrow, BIT_HPAL_PERST_FROM_PAD and BIT_CAR_PERST_RST were set as a WA an HW issue. Signed-off-by: Alexei Avshalom Lazar Signed-off-by: Maya Erez Signed-off-by: Kalle Valo Signed-off-by: Sasha Levin --- drivers/net/wireless/ath/wil6210/main.c | 11 +++++++---- 1 file changed, 7 insertions(+), 4 deletions(-) diff --git a/drivers/net/wireless/ath/wil6210/main.c b/drivers/net/wireless/ath/wil6210/main.c index 7debed6bec06..a0fe8cbad104 100644 --- a/drivers/net/wireless/ath/wil6210/main.c +++ b/drivers/net/wireless/ath/wil6210/main.c @@ -995,10 +995,13 @@ static int wil_target_reset(struct wil6210_priv *wil, int no_flash) wil_dbg_misc(wil, "Resetting \"%s\"...\n", wil->hw_name); - /* Clear MAC link up */ - wil_s(wil, RGF_HP_CTRL, BIT(15)); - wil_s(wil, RGF_USER_CLKS_CTL_SW_RST_MASK_0, BIT_HPAL_PERST_FROM_PAD); - wil_s(wil, RGF_USER_CLKS_CTL_SW_RST_MASK_0, BIT_CAR_PERST_RST); + if (wil->hw_version < HW_VER_TALYN) { + /* Clear MAC link up */ + wil_s(wil, RGF_HP_CTRL, BIT(15)); + wil_s(wil, RGF_USER_CLKS_CTL_SW_RST_MASK_0, + BIT_HPAL_PERST_FROM_PAD); + wil_s(wil, RGF_USER_CLKS_CTL_SW_RST_MASK_0, BIT_CAR_PERST_RST); + } wil_halt_cpu(wil); -- 2.19.1