Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S262927AbUCKBLH (ORCPT ); Wed, 10 Mar 2004 20:11:07 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S262925AbUCKBLH (ORCPT ); Wed, 10 Mar 2004 20:11:07 -0500 Received: from stat1.steeleye.com ([65.114.3.130]:43217 "EHLO hancock.sc.steeleye.com") by vger.kernel.org with ESMTP id S262922AbUCKBLD (ORCPT ); Wed, 10 Mar 2004 20:11:03 -0500 Subject: RE: [Announce] Emulex LightPulse Device Driver From: James Bottomley To: "Smart, James" Cc: Jeff Garzik , "'linux-scsi@vger.kernel.org'" , "'linux-kernel@vger.kernel.org'" In-Reply-To: <3356669BBE90C448AD4645C843E2BF2802C014F1@xbl.ma.emulex.com> References: <3356669BBE90C448AD4645C843E2BF2802C014F1@xbl.ma.emulex.com> Content-Type: text/plain Content-Transfer-Encoding: 7bit X-Mailer: Ximian Evolution 1.0.8 (1.0.8-9) Date: 10 Mar 2004 20:10:54 -0500 Message-Id: <1078967456.10834.80.camel@mulgrave> Mime-Version: 1.0 Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1554 Lines: 33 On Wed, 2004-03-10 at 17:47, Smart, James wrote: > we receive comments. There are constructs in the driver that are likely not > going to change, such as the logging facility. How contentious is this ? > What about the IP interfaces? and so on. Anything we receive, especially on > the larger concepts in the driver, only helps us understand what's ahead. Well, what your logging facility tries to do (discriminated messages to the console based on a mask) is extremely standard for drivers. The way you implement it is slightly, erm, less than desirable. Having your own version of sprintf in your driver is a definite no-no (why do you do this? You never seem actually to use the added formatting characters like %E?). But at least it doesn't do anything silly like try to ouput to the serial port. As far as the IP portion goes: layering and separation should really be the order of the day---perhaps even to the point where you have a core module with a scsi and an IP one that sit on top of it. > Our plans are to complete most of the work list on the FAQ by early April. > We'll try to make weekly drops on SourceForge, with each snapshot containing > a log of the changes. Once the code base matures, we will ping the lists > again, asking for feedback. OK, I'll look forward to it. James - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/