Received: by 2002:ac0:946b:0:0:0:0:0 with SMTP id j40csp3026136imj; Mon, 11 Feb 2019 12:31:39 -0800 (PST) X-Google-Smtp-Source: AHgI3Ib7UU/LHHpEoi6lksuBQCYU6E8LjLqkhtjkZiHsITFnyvCf7koV8lGOd1CGj9OSzAPXcSSX X-Received: by 2002:a63:da14:: with SMTP id c20mr41018pgh.233.1549917099194; Mon, 11 Feb 2019 12:31:39 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1549917099; cv=none; d=google.com; s=arc-20160816; b=fsEH7Qi8qfeFzfBgrMv8OPszA3P8z3FLNV+5rxKB8u2/DAT7tlfT4wwEuREHuGvVVS mbkF69oO6kCduW5FjodvlLuTNoT771CCM6e0di6acghUw6+w0BoOB1DM6dMrwWfI1TQS pGtVwuhg/Ok/AwecZVH0RPXL7uAT7aRoF1h6WkdzB+E3vEyjzp3AY9xmWZsVuJTdGu/y zGCOFMBCa4KL+0bsTTpl0HDIBaQocA811qQ/rMXZb4RNfH4K3le6DHuRLBOjyN1QQ/r9 NRDqtk38X4aA++mfyfx3OWyxjXQs/gy272F2kNGS6H6bV5qUwM52GskLyt04Q64Q2svk G0Rg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:in-reply-to :content-disposition:mime-version:references:message-id:subject:cc :to:from:date:dkim-signature; bh=tAvnV6Adt6hwRFCsJZRTsRuKJBB3unr7uTzczU6qxfE=; b=HC7KfXiEEsOSUzDeJRGMYwpZkWk8sxqq7+UvsxQqVV/ls0xohLKQPMdx1gXl6xuDGn PbfRSeBKg1IWRzkQsRQobDRTuCxyLcZypbFk0c5VK9/xkn2gc5nDQs0RUptmJfRCES74 pK/EX2y/tAqQogLRmPQZbf5QKr9c8TOxbXtdEXnKJrM7a9k3eNZzHh28VzMxUjdyndxz rG3rsUdB8BxOS0X9CFntkXC1IuIoQrM/ZySnlkjCE5/yTkLjbqne/fSM+0oouSk7ac4E x9X3LNya0V9KjAAZ32gFgYXDnR5nCdPzgOqMmDSfgu1WVVd9MXeqd/9ylU3PM5gyrq/5 apag== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b="CsxKV/i7"; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id r10si2337671pls.33.2019.02.11.12.31.23; Mon, 11 Feb 2019 12:31:39 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b="CsxKV/i7"; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1730246AbfBKRLe (ORCPT + 99 others); Mon, 11 Feb 2019 12:11:34 -0500 Received: from mail.kernel.org ([198.145.29.99]:34520 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726244AbfBKRLd (ORCPT ); Mon, 11 Feb 2019 12:11:33 -0500 Received: from localhost (5356596B.cm-6-7b.dynamic.ziggo.nl [83.86.89.107]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 6AEF22082F; Mon, 11 Feb 2019 17:11:32 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1549905092; bh=ErKWt0KHUNUfeZ7+bpoLEWio5pL4SoqDtrH6zt0hoAE=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=CsxKV/i7T9vtLcIWEa2tG7tgyku9yP8c7f19f7n23n3BMc14Jg1x/WevcpgvcQsPa j/WypSQaThcZ9biadz7gDKMi87jw4I048x17vdi/O9NED8utMA/tU12viM4gntdi8g HHJf1roCfVGV80eDU6lzKYEfpMYT1nGD9KmEmlLQ= Date: Mon, 11 Feb 2019 18:11:30 +0100 From: Greg KH To: Souptick Joarder Cc: devel@driverdev.osuosl.org, tkjos@android.com, linux-kernel@vger.kernel.org, arve@android.com, maco@android.com, christian@brauner.io Subject: Re: [PATCH] staging: android: vsoc: Remove VSOC_WAIT_FOR_INCOMING_INTERRUPT Message-ID: <20190211171130.GA13294@kroah.com> References: <20190211152602.GA5591@jordon-HP-15-Notebook-PC> <20190211154044.GA16105@kroah.com> <20190211155734.GA18078@kroah.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.11.3 (2019-02-01) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Feb 11, 2019 at 10:15:18PM +0530, Souptick Joarder wrote: > On Mon, Feb 11, 2019 at 9:27 PM Greg KH wrote: > > > > On Mon, Feb 11, 2019 at 09:21:19PM +0530, Souptick Joarder wrote: > > > On Mon, Feb 11, 2019 at 9:10 PM Greg KH wrote: > > > > > > > > On Mon, Feb 11, 2019 at 08:56:02PM +0530, Souptick Joarder wrote: > > > > > As mentioned in TODO list, Removed VSOC_WAIT_FOR_INCOMING_INTERRUPT > > > > > ioctl. This functionality has been superseded by the futex and is > > > > > there for legacy reasons. > > > > > > > > > > Signed-off-by: Souptick Joarder > > > > > --- > > > > > drivers/staging/android/uapi/vsoc_shm.h | 7 ------- > > > > > drivers/staging/android/vsoc.c | 5 ----- > > > > > 2 files changed, 12 deletions(-) > > > > > > > > So userspace is all fixed up now and this ioctl can be dropped? Any > > > > pointers to the userspace commit that did this? > > > > > > I am not sure about user space part. > > > > Then we can not just delete the ioctl :) > > Agree, but where to verify the user space commit ? > Any pointer to the source code path ? Please work with the android developers to solve this. It should be in AOSP "somewhere" :( good luck, greg k-h