Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Date:   Mon, 11 Feb 2019 18:32:39 +0100
From:   Jan Kara <jack@suse.cz>
To:     Steve Magnani <steve.magnani@digidescorp.com>
Cc:     jack@suse.com, linux-kernel@vger.kernel.org,
        "Steven J . Magnani" <steve@digidescorp.com>
Subject: Re: [PATCH] udf: disallow RW mount without valid integrity descriptor
Message-ID: <20190211173239.GL19029@quack2.suse.cz>
References: <20190211142438.16599-1-steve@digidescorp.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20190211142438.16599-1-steve@digidescorp.com>
User-Agent: Mutt/1.10.1 (2018-07-13)
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On Mon 11-02-19 08:24:38, Steve Magnani wrote:
> Refuse to mount a volume read-write without a coherent Logical Volume
> Integrity Descriptor, because we can't generate truly unique IDs without 
> one.
> 
> This fixes a bug where all inodes created on a UDF filesystem following
> mount without a coherent LVID are assigned UID 0.
> 
> Signed-off-by: Steven J. Magnani <steve@digidescorp.com>

Thanks. Added to my tree.

								Honza

> ---
> --- a/fs/udf/super.c	2018-11-16 06:43:00.622344354 -0600
> +++ b/fs/udf/super.c	2019-02-11 08:08:00.478331631 -0600
> @@ -1474,6 +1474,17 @@ static int udf_load_logicalvol(struct su
>  	if (lvd->integritySeqExt.extLength)
>  		udf_load_logicalvolint(sb, leea_to_cpu(lvd->integritySeqExt));
>  	ret = 0;
> +
> +	if (!sbi->s_lvid_bh) {
> +		/* We can't generate UIDs without a valid LVID */
> +		if (sb_rdonly(sb))
> +			UDF_SET_FLAG(sb, UDF_FLAG_RW_INCOMPAT);
> +		else {
> +			udf_warn(sb, "Damaged or missing LVID, forcing "
> +				     "readonly mount\n");
> +			ret = -EACCES;
> +		}
> +	}
>  out_bh:
>  	brelse(bh);
>  	return ret;
> 
-- 
Jan Kara <jack@suse.com>
SUSE Labs, CR