Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S261580AbUCKEkv (ORCPT ); Wed, 10 Mar 2004 23:40:51 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S262256AbUCKEkv (ORCPT ); Wed, 10 Mar 2004 23:40:51 -0500 Received: from 1-2-2-1a.has.sth.bostream.se ([82.182.130.86]:60378 "EHLO K-7.stesmi.com") by vger.kernel.org with ESMTP id S261580AbUCKEku (ORCPT ); Wed, 10 Mar 2004 23:40:50 -0500 Message-ID: <404FEDAC.8090300@stesmi.com> Date: Thu, 11 Mar 2004 05:40:12 +0100 From: Stefan Smietanowski User-Agent: Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.7a) Gecko/20040219 X-Accept-Language: en-us, en MIME-Version: 1.0 To: Linus Torvalds CC: Peter Williams , "Randy.Dunlap" , root@chaos.analogic.com, linux-kernel@vger.kernel.org, "Godbole, Amarendra (GE Consumer & Industrial)" Subject: Re: (0 == foo), rather than (foo == 0) References: <905989466451C34E87066C5C13DDF034593392@HYDMLVEM01.e2k.ad.ge.com> <20040310100215.1b707504.rddunlap@osdl.org> <404F9E28.4040706@aurema.com> <404FD81D.3010502@aurema.com> In-Reply-To: Content-Type: text/plain; charset=us-ascii; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 787 Lines: 32 Hi Linus. > The warning should be there whether there are parenthesis or not, and it > should state that you should have an explicit inequality expression. So if > you have > > if (a = b) > ... > > and you really _mean_ that, then the way to write it sanely is to just > write it as > > if ((a = b) != 0) > ... > > which makes it much clearer what you're actually doing. Or actually change it to a = b; if (a) ... That's even more clear in my opinion. The other still feels a bit iffy but maybe that's just me. // Stefan - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/