Received: by 2002:ac0:946b:0:0:0:0:0 with SMTP id j40csp3037456imj; Mon, 11 Feb 2019 12:43:28 -0800 (PST) X-Google-Smtp-Source: AHgI3IbiOTtVL2puOmzSpNVe2/dBDjeLME1E6V19oJ29mGc30B3If4zMG7vuRAHqGoUWA//oxtRo X-Received: by 2002:a65:520a:: with SMTP id o10mr127605pgp.276.1549917808840; Mon, 11 Feb 2019 12:43:28 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1549917808; cv=none; d=google.com; s=arc-20160816; b=qvuQwnDpMWylzNaGEFiFxY9Wd80KpKDHEeaqcK4BRfbMXl0Yl/kOa5T/49W+v0v5Qg VzNP0r/lMLd4cqiEcY67H2d3T/RUyc9InNYX3vdcOLxZRTkza1bQa4yDYPGC4o0l9ulg pRqBW+08MaA3n4nirtoePsfbxfX+imuvWNALwxzictEbWDhNQAn3lKx6KOkgK8vznJ9o +pgtqLZpTkPtjNMvPEqMnE6/RmEhgVqmSI2Pl+/7M+AKIz00FxCVPg8y9b8JSLc1NiQs Ta5Ph6EVn1JFtK88ZakOtn/gOHWgQqfkqaQGJxSOFWo3kP/CQd65LOiFlmY6x15usi40 6r4g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding :content-language:in-reply-to:mime-version:user-agent:date :message-id:from:references:to:subject; bh=k2FZFo7KLfZViZS6bx1ThopOO/ZHFQU/rDtH/UdkK68=; b=R+aGkvXOlidIxHF2/0l21MSgdLjfsVPZU1Hkv1VQq1HQVgj72dXUQTap6HfhfnAcqM 7QG1rA5rcjbt5AF7xVvxEEYHnD2QkRj+ifJ7PZO/9dYZZO3jfk6O1twgMnRxKlTCDilw 4EdkkkaXbV+4h14qegwXeKreE5T2ZJruZZ807t3CiT/Ih/1Hsn4qoe2tX0sSWSfYguRb nvYTm7EhkXBusx/1yqH8CxfXp18OsksbCz9DrpP63xiDrYB53htnA+0Amqzy/v7xSLUN nKu6iHqxMGsfkjI0gz3cV9coPXRucVnkbKyS7t/SiIRKXHpob8QaVCJdsrhdCYyFDhsI +RHg== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id n7si10858079plk.18.2019.02.11.12.43.12; Mon, 11 Feb 2019 12:43:28 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1733055AbfBKTxm (ORCPT + 99 others); Mon, 11 Feb 2019 14:53:42 -0500 Received: from www62.your-server.de ([213.133.104.62]:57206 "EHLO www62.your-server.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728124AbfBKTxl (ORCPT ); Mon, 11 Feb 2019 14:53:41 -0500 Received: from [78.46.172.3] (helo=sslproxy06.your-server.de) by www62.your-server.de with esmtpsa (TLSv1.2:DHE-RSA-AES256-GCM-SHA384:256) (Exim 4.89_1) (envelope-from ) id 1gtHe5-0001mx-V5; Mon, 11 Feb 2019 20:53:38 +0100 Received: from [178.197.249.40] (helo=linux.home) by sslproxy06.your-server.de with esmtpsa (TLSv1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.89) (envelope-from ) id 1gtHe5-000VgN-PE; Mon, 11 Feb 2019 20:53:37 +0100 Subject: Re: [PATCH v2] xsk: share the mmap_sem for page pinning To: akpm@linux-foundation.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org, "David S . Miller" , Bjorn Topel , Magnus Karlsson , netdev@vger.kernel.org, Davidlohr Bueso References: <20190207053740.26915-1-dave@stgolabs.net> <20190207053740.26915-2-dave@stgolabs.net> <20190211161529.uskq5ca7y3j5522i@linux-r8p5> From: Daniel Borkmann Message-ID: Date: Mon, 11 Feb 2019 20:53:37 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.3.0 MIME-Version: 1.0 In-Reply-To: <20190211161529.uskq5ca7y3j5522i@linux-r8p5> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit X-Authenticated-Sender: daniel@iogearbox.net X-Virus-Scanned: Clear (ClamAV 0.100.2/25357/Mon Feb 11 11:38:50 2019) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 02/11/2019 05:15 PM, Davidlohr Bueso wrote: > Holding mmap_sem exclusively for a gup() is an overkill. > Lets share the lock and replace the gup call for gup_longterm(), > as it is better suited for the lifetime of the pinning. > > Cc: David S. Miller > Cc: Bjorn Topel > Cc: Magnus Karlsson > CC: netdev@vger.kernel.org > Signed-off-by: Davidlohr Bueso Applied, thanks!