Received: by 2002:ac0:946b:0:0:0:0:0 with SMTP id j40csp3038374imj; Mon, 11 Feb 2019 12:44:34 -0800 (PST) X-Google-Smtp-Source: AHgI3IZTFD9LXfXy3AeAXqDpkjCk5YB9kNTyRJ8skpT2PaB/dcgczYvvyKJrcEz8hTU/JnFntcGb X-Received: by 2002:a63:fb42:: with SMTP id w2mr121468pgj.408.1549917874652; Mon, 11 Feb 2019 12:44:34 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1549917874; cv=none; d=google.com; s=arc-20160816; b=BHP1Gdsh+ECGSazs/GPlYRy9lC63A5QBVeaiOxHEZH95pf7zHWMUEFdoxXx0bLB3TU 6LnU5Rn0veHWvpoUXGSJcdN8Iyqw4/H2DFvpY9kx5P3P6Zn0SJCZe6MppHq1xzDXLgh8 ZRJ2z6q2PRqZMkIx2MJct1qrtpWyAyvKJY+QRhiAT/E/KVMH+fQEgVsXvFtuDaYElzQQ K90+xvwsJZJHyQudSici2SBiNfvakSfe7Crp71JPat9EUETxdVRO77A2Y6LknIT5LqL9 piZEJ6hlnB4u9R6/C0Aa5Jdo3TAR0PtmQZKl0mDv6Gx97bvdKlFCcOlxy9ZPu/tg64EY 0Uyg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:mime-version:content-transfer-encoding :content-id:content-language:accept-language:in-reply-to:references :message-id:date:thread-index:thread-topic:subject:cc:to:from :dkim-signature:dkim-signature; bh=Qz+71zK4S8O3ulPwvIWUAtdOJf83HKjdiQm2enhhDUM=; b=eTK4RSaRH5dDGLz2aBhJZPUrI0IwHME3n9t2KBZMRFuHsTCWJ0r4VtKDAScuAbzMJP d1uL4zT61p8hwb/Y6ghGsJ+Ij3yaHpZYqvtkeiYphmJnzQ90HVK1Qe+R4JiXBjhEQwnt aYy4VDudihUgVThLiDKI8NsQN74qxqaA6Z5bUN/p/Stxq0KD5iKnXrwjiJ8OgWRxf0bu +9U6V0SmJGFbg4ydl/2jUze35Y7/6Ia3qxsEzaon1zOGUZj9R25Lk4HnQMhYKV0p8NPz NFApSuRMucX/Rtju64BI+PK4CiIxLuPOPdu9s8DOZbbIHzt5wlpzc4+qcFbNOIs+Es3v DrgA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@fb.com header.s=facebook header.b=SEoYiKwf; dkim=pass header.i=@fb.onmicrosoft.com header.s=selector1-fb-com header.b=HpdJD7+p; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=fb.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id w2si10492342pgh.565.2019.02.11.12.44.17; Mon, 11 Feb 2019 12:44:34 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@fb.com header.s=facebook header.b=SEoYiKwf; dkim=pass header.i=@fb.onmicrosoft.com header.s=selector1-fb-com header.b=HpdJD7+p; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=fb.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1730765AbfBKUN4 (ORCPT + 99 others); Mon, 11 Feb 2019 15:13:56 -0500 Received: from mx0b-00082601.pphosted.com ([67.231.153.30]:59788 "EHLO mx0a-00082601.pphosted.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1726080AbfBKUN4 (ORCPT ); Mon, 11 Feb 2019 15:13:56 -0500 Received: from pps.filterd (m0089730.ppops.net [127.0.0.1]) by m0089730.ppops.net (8.16.0.27/8.16.0.27) with SMTP id x1BKBicj004111; Mon, 11 Feb 2019 12:13:32 -0800 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=fb.com; h=from : to : cc : subject : date : message-id : references : in-reply-to : content-type : content-id : content-transfer-encoding : mime-version; s=facebook; bh=Qz+71zK4S8O3ulPwvIWUAtdOJf83HKjdiQm2enhhDUM=; b=SEoYiKwf35woYtPnRnfysgUcH5hFRMxNJfEzTxEmNnkXRFqkRNQMYKx8ZyzJIeNI4DE3 9BTV1tEYVzlvwiHJNNveZI3WHfWacWizyBOVlZfv2xn0FimBQ5wdrVnlesBm1Gvlm702 N1w+x8S3ZtAnmNgjA/2hvM1o9Xz8jGx1tfQ= Received: from maileast.thefacebook.com ([199.201.65.23]) by m0089730.ppops.net with ESMTP id 2qkdqc0hbr-6 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-SHA384 bits=256 verify=NOT); Mon, 11 Feb 2019 12:13:31 -0800 Received: from frc-hub06.TheFacebook.com (2620:10d:c021:18::176) by frc-hub04.TheFacebook.com (2620:10d:c021:18::174) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384) id 15.1.1531.3; Mon, 11 Feb 2019 12:13:17 -0800 Received: from NAM01-BN3-obe.outbound.protection.outlook.com (192.168.183.28) by o365-in.thefacebook.com (192.168.177.76) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384) id 15.1.1531.3 via Frontend Transport; Mon, 11 Feb 2019 12:13:17 -0800 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=fb.onmicrosoft.com; s=selector1-fb-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=Qz+71zK4S8O3ulPwvIWUAtdOJf83HKjdiQm2enhhDUM=; b=HpdJD7+p1YDos6U5g5n6MdDEKcdDjZSA1We+fWtkz3sBJsbqkA4PNfiDfXOcy7uwtkctvin/rzxmtzqqzcvUBZypwWsQm5VvGAbblNiKPm/JcDb2yRUFF1/PSfaJ7/BhzQfOWWd8SIqYmwtpeC85/tcyhV5Jls/7nJ/yOfoT8PQ= Received: from CY4PR15MB1269.namprd15.prod.outlook.com (10.172.180.139) by CY4PR15MB1560.namprd15.prod.outlook.com (10.172.162.13) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.1601.24; Mon, 11 Feb 2019 20:13:16 +0000 Received: from CY4PR15MB1269.namprd15.prod.outlook.com ([fe80::b9cb:6dd8:d8bf:45c6]) by CY4PR15MB1269.namprd15.prod.outlook.com ([fe80::b9cb:6dd8:d8bf:45c6%2]) with mapi id 15.20.1601.023; Mon, 11 Feb 2019 20:13:16 +0000 From: Vijay Khemka To: Andrew Jeffery , Greg Kroah-Hartman CC: Arnd Bergmann , Joel Stanley , "linux-arm-kernel@lists.infradead.org" , "linux-aspeed@lists.ozlabs.org" , "linux-kernel@vger.kernel.org" , "openbmc @ lists . ozlabs . org" Subject: Re: [PATCH] misc: aspeed-lpc-ctrl: Correct return values Thread-Topic: [PATCH] misc: aspeed-lpc-ctrl: Correct return values Thread-Index: AQHUs3BeMI31TwUu10WDx7+uo1I7z6W+EyAAgAA2EYCAG+OTgIAAcpsA Date: Mon, 11 Feb 2019 20:13:15 +0000 Message-ID: References: <20190123230634.1815021-1-vijaykhemka@fb.com> <20190124081544.GA1649@kroah.com> <13C13AE8-63A4-4002-9E0D-70276C529448@fb.com> <1549862567.1175306.1655243744.11AFF30D@webmail.messagingengine.com> In-Reply-To: <1549862567.1175306.1655243744.11AFF30D@webmail.messagingengine.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [2620:10d:c090:200::6:6ae9] x-ms-publictraffictype: Email x-microsoft-exchange-diagnostics: 1;CY4PR15MB1560;20:Wql2j3IidcbXcAwx+D/tNGEN6DTRbV2P2qviYLYjkTbvDUt+68JN028+7C6R8mV46BxFE+GeGJdu++kg6mW8/8t9MQPWe7jLlEpTM7wDG8C5SPyyxJaSCDnkCsQk8fz7Tf35URLU8Ab1Tv5qsDcBbil+Q6eTxLIZYG1C4Qak4bw= x-ms-office365-filtering-correlation-id: 8866b2e7-bf5d-4a4f-f8f5-08d6905d5b83 x-microsoft-antispam: BCL:0;PCL:0;RULEID:(2390118)(7020095)(4652040)(8989299)(4534185)(4627221)(201703031133081)(201702281549075)(8990200)(5600110)(711020)(4605077)(2017052603328)(7153060)(7193020);SRVR:CY4PR15MB1560; x-ms-traffictypediagnostic: CY4PR15MB1560: x-microsoft-antispam-prvs: x-forefront-prvs: 0945B0CC72 x-forefront-antispam-report: SFV:NSPM;SFS:(10019020)(396003)(376002)(366004)(136003)(346002)(39860400002)(189003)(199004)(106356001)(476003)(86362001)(53936002)(6436002)(229853002)(2616005)(102836004)(14444005)(256004)(53546011)(6506007)(68736007)(11346002)(46003)(82746002)(93886005)(446003)(110136005)(4326008)(316002)(486006)(105586002)(81156014)(97736004)(8676002)(6116002)(36756003)(7736002)(14454004)(6486002)(6246003)(81166006)(8936002)(76176011)(33656002)(71200400001)(99286004)(305945005)(2906002)(54906003)(83716004)(71190400001)(186003)(25786009)(6512007)(478600001);DIR:OUT;SFP:1102;SCL:1;SRVR:CY4PR15MB1560;H:CY4PR15MB1269.namprd15.prod.outlook.com;FPR:;SPF:None;LANG:en;PTR:InfoNoRecords;MX:1;A:1; received-spf: None (protection.outlook.com: fb.com does not designate permitted sender hosts) x-ms-exchange-senderadcheck: 1 x-microsoft-antispam-message-info: l4Q3YgebybB1nvVGl8s4ruueHKDi8pOlCiZuhSrgcwL08zVWW9Z7skUZWNKBYlxx7zQU7eQ7U2dYrfosmZXCzO+5SMf8UzzVrUSStnMvIJy2bcjkAQ0DNxBNGiP3OlvsfHAW9TSH3N2zBjzOSP0pNgQJYaZMNhM/9l1/eAOyRSZg/OeGJ6urrxuUgrrX9/AaATUYMQwHD8HFv0D9l4v1qJ/3KMor26LLxEV0bN86sb2q9bvqJb97Z/3GObl9M8FAFHKBfB0hrx9j9ckkXynkE/+BcEpfenTgZsx4MwQQXPkjQIzfMQqwM783uKFFVLcr0soLxQRuPq3gbWEkO5onuGWj6mT1XeC2TfCVkaOXAe2M947VebUcbf0ikggwcD/+jyPyPmR7aUULWIVDjODCg5ok1c7RwJq3aCsuyMOX2uU= Content-Type: text/plain; charset="utf-8" Content-ID: <63618F2410F7204090F466D259C31D32@namprd15.prod.outlook.com> Content-Transfer-Encoding: base64 MIME-Version: 1.0 X-MS-Exchange-CrossTenant-Network-Message-Id: 8866b2e7-bf5d-4a4f-f8f5-08d6905d5b83 X-MS-Exchange-CrossTenant-originalarrivaltime: 11 Feb 2019 20:13:16.0106 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 8ae927fe-1255-47a7-a2af-5f3a069daaa2 X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-Transport-CrossTenantHeadersStamped: CY4PR15MB1560 X-OriginatorOrg: fb.com X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:,, definitions=2019-02-11_14:,, signatures=0 X-Proofpoint-Spam-Reason: safe X-FB-Internal: Safe Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org DQoNCu+7v09uIDIvMTAvMTksIDk6MjIgUE0sICJBbmRyZXcgSmVmZmVyeSIgPGFuZHJld0Bhai5p ZC5hdT4gd3JvdGU6DQoNCiAgICBPbiBGcmksIDI1IEphbiAyMDE5LCBhdCAwNTo1OSwgVmlqYXkg S2hlbWthIHdyb3RlOg0KICAgID4gDQogICAgPiANCiAgICA+IE9uIDEvMjQvMTksIDEyOjE2IEFN LCAiR3JlZyBLcm9haC1IYXJ0bWFuIiA8Z3JlZ2toQGxpbnV4Zm91bmRhdGlvbi5vcmc+IHdyb3Rl Og0KICAgID4gDQogICAgPiAgICAgT24gV2VkLCBKYW4gMjMsIDIwMTkgYXQgMDM6MDY6MzRQTSAt MDgwMCwgVmlqYXkgS2hlbWthIHdyb3RlOg0KICAgID4gICAgID4gQ29ycmVjdGVkIHNvbWUgb2Yg cmV0dXJuIHZhbHVlcyB3aXRoIGFwcHJvcHJpYXRlIG1lYW5pbmdzLg0KICAgID4gICAgID4gDQog ICAgPiAgICAgPiBTaWduZWQtb2ZmLWJ5OiBWaWpheSBLaGVta2EgPHZpamF5a2hlbWthQGZiLmNv bT4NCiAgICA+ICAgICA+IC0tLQ0KICAgID4gICAgID4gIGRyaXZlcnMvbWlzYy9hc3BlZWQtbHBj LWN0cmwuYyB8IDE1ICsrKysrKystLS0tLS0tLQ0KICAgID4gICAgID4gIDEgZmlsZSBjaGFuZ2Vk LCA3IGluc2VydGlvbnMoKyksIDggZGVsZXRpb25zKC0pDQogICAgPiAgICAgPiANCiAgICA+ICAg ICA+IGRpZmYgLS1naXQgYS9kcml2ZXJzL21pc2MvYXNwZWVkLWxwYy1jdHJsLmMgYi9kcml2ZXJz L21pc2MvYXNwZWVkLQ0KICAgID4gbHBjLWN0cmwuYw0KICAgID4gICAgID4gaW5kZXggMzMyMjEw ZTA2ZTk4Li45N2FlMzQxMTA5ZDUgMTAwNjQ0DQogICAgPiAgICAgPiAtLS0gYS9kcml2ZXJzL21p c2MvYXNwZWVkLWxwYy1jdHJsLmMNCiAgICA+ICAgICA+ICsrKyBiL2RyaXZlcnMvbWlzYy9hc3Bl ZWQtbHBjLWN0cmwuYw0KICAgID4gICAgID4gQEAgLTY4LDcgKzY4LDYgQEAgc3RhdGljIGxvbmcg YXNwZWVkX2xwY19jdHJsX2lvY3RsKHN0cnVjdCBmaWxlIA0KICAgID4gKmZpbGUsIHVuc2lnbmVk IGludCBjbWQsDQogICAgPiAgICAgPiAgCQl1bnNpZ25lZCBsb25nIHBhcmFtKQ0KICAgID4gICAg ID4gIHsNCiAgICA+ICAgICA+ICAJc3RydWN0IGFzcGVlZF9scGNfY3RybCAqbHBjX2N0cmwgPSBm aWxlX2FzcGVlZF9scGNfY3RybChmaWxlKTsNCiAgICA+ICAgICA+IC0Jc3RydWN0IGRldmljZSAq ZGV2ID0gZmlsZS0+cHJpdmF0ZV9kYXRhOw0KICAgID4gICAgID4gIAl2b2lkIF9fdXNlciAqcCA9 ICh2b2lkIF9fdXNlciAqKXBhcmFtOw0KICAgID4gICAgID4gIAlzdHJ1Y3QgYXNwZWVkX2xwY19j dHJsX21hcHBpbmcgbWFwOw0KICAgID4gICAgID4gIAl1MzIgYWRkcjsNCiAgICA+ICAgICA+IEBA IC05Myw4ICs5Miw4IEBAIHN0YXRpYyBsb25nIGFzcGVlZF9scGNfY3RybF9pb2N0bChzdHJ1Y3Qg ZmlsZSANCiAgICA+ICpmaWxlLCB1bnNpZ25lZCBpbnQgY21kLA0KICAgID4gICAgID4gIA0KICAg ID4gICAgID4gIAkJLyogSWYgbWVtb3J5LXJlZ2lvbiBpcyBub3QgZGVzY3JpYmVkIGluIGRldmlj ZSB0cmVlICovDQogICAgPiAgICAgPiAgCQlpZiAoIWxwY19jdHJsLT5tZW1fc2l6ZSkgew0KICAg ID4gICAgID4gLQkJCWRldl9lcnIoZGV2LCAiRGlkbid0IGZpbmQgcmVzZXJ2ZWQgbWVtb3J5XG4i KTsNCiAgICA+ICAgICA+IC0JCQlyZXR1cm4gLUVJTlZBTDsNCiAgICA+ICAgICA+ICsJCQlwcl9l cnIoImFzcGVlZF9scGNfY3RybDogaW9jdGw6IERpZG4ndCBmaW5kIHJlc2VydmVkIG1lbW9yeVxu Iik7DQogICAgPiAgICAgDQogICAgPiAgICAgV2h5IGRpZCB5b3UgY2hhbmdlIGZyb20gZGV2X2Vy cigpIHRvIHByX2VycigpPyAgWW91IGp1c3QgbG9zdCBhIGxvdCBvZg0KICAgID4gICAgIGluZm9y bWF0aW9uIHRoYXQgdGhlIHVzZXIgcHJldmlvdXNseSB3YXMgZ2V0dGluZyBmcm9tIGRldl9lcnIo KSA6KA0KICAgID4gDQogICAgPiBJIGRpZCB0aGlzIGFzIHBlciByZXZpZXcgY29tbWVudCBmcm9t IEFuZHJldyBKZWZmZXJ5LCBhcyB3ZSBkb24ndCB3YW50IA0KICAgID4gdG8gcHV0IHRoaXMgZXJy b3IgZm9yIGRyaXZlci4gSXQgaGFzIHRvIGJlIGhhbmRsZWQgYnkgdXNlcnNwYWNlLiBCdXQgSSAN CiAgICA+IGFtIHN0aWxsIHJlcG9ydGluZyBzb21lIGVycm9yIGhlcmUuDQogICAgDQogICAgU29y cnk/IFdoYXQgSSB3YXMgdHJ5aW5nIHRvIHN1Z2dlc3Qgd2FzIHJlbW92aW5nIHRoZSBsb2dnaW5n IGFsdG9nZXRoZXIgYW5kDQogICAganVzdCByZXR1cm5pbmcgdGhlIGVycm9yIGNvZGUuIE5vdCBz aW1wbHkgY2hhbmdpbmcgaG93IHRoZSBsb2dnaW5nIGlzIGRvbmUuDQpObyBpc3N1ZSwgSSBjYW4g cmVtb3ZlIGxvZ2dpbmcsIHdpbGwganVzdCByZXR1cm4gZXJyb3IgY29kZS4gV2lsbCBzZW5kIG5l dyBwYXRjaCB3aXRoIHVwZGF0ZS4NCiAgICANCiAgICBBbmRyZXcNCiAgICANCg0K