Received: by 2002:ac0:946b:0:0:0:0:0 with SMTP id j40csp3069484imj; Mon, 11 Feb 2019 13:19:02 -0800 (PST) X-Google-Smtp-Source: AHgI3Ib5LpQ7s4FXPu1SpcsPlr6+Vqe2ZKM0GlEWXRiy7ktjV2p44ycqEJCHvcdcch9h4CBoBuN5 X-Received: by 2002:a63:fa48:: with SMTP id g8mr236394pgk.203.1549919942360; Mon, 11 Feb 2019 13:19:02 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1549919942; cv=none; d=google.com; s=arc-20160816; b=kc0kG205gM5+VDr3uKjInxcQzUMbyDj53HpPN2mBYlSvBX4oWg5RpU7SSA2hwlCs8m GG7nxQKM8oA5K1JlDofuBPKJXaEsMSXMx/wRCHFWQiXbG26Mh/wafrDzD0bT08FUIq9S aSVpmyZKTKSiQ9KTJdF/VMD+YCXKU8c0m05XgkER3VhGFSvQEXSjyxSZfv+KXFc7rJEy KK5nN1OPN+w72x7Ryi7RbXoARl8PByYKHWsHpJZXYoaYKSWPLIxiHTkWYpoETkhwoODG bFcjGdF3md+jgVacWgexRAUoDiI3Ya7Iu7nYAZgBqdTm55SMjxUDHWDTxSbf/lvcuos4 oUXA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:references:in-reply-to:message-id:date :subject:cc:to:from:dkim-signature; bh=p5ZCXTBfLok1XMf+SlQNjbPYGN3N8X4VxG7Tq+I0H5E=; b=sM6Im6cENDPnSr8hqkmKlR+KX7JmqH8lZk4mZziJdxym6xVokURuVUBQkPfchn0r4s hY0b09QZcYklrueDqZ/hE+GZ3sexypLja0pnTnO2+t+tX0UQj6O2EKaYXAYX0tkYnuoz 4mVn8Tyw2S+NfirvbtcbGZgGDwv6sdvWDpDYt8PFmeuQJK3J+e03PQ+TNKZOIYo2r5bR 3oCyZbJ17RqZu1qJ/0R9WBFLgwygkMbfTqlBaGLktMMWq99pi2bcNmg10sMLSuDH6HC7 y3BF1Sv+PmkcAcdJkFUTd9lnkmLNfMnLvZzDB2MHRM1Seq51pkAFQ8BCtqzZaHcUoB5k Ozfw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@gmail.com header.s=20161025 header.b=OSIA8Fj2; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id a1si11514490pld.249.2019.02.11.13.18.36; Mon, 11 Feb 2019 13:19:02 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@gmail.com header.s=20161025 header.b=OSIA8Fj2; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727529AbfBKVSW (ORCPT + 99 others); Mon, 11 Feb 2019 16:18:22 -0500 Received: from mail-pl1-f196.google.com ([209.85.214.196]:43983 "EHLO mail-pl1-f196.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726177AbfBKVSV (ORCPT ); Mon, 11 Feb 2019 16:18:21 -0500 Received: by mail-pl1-f196.google.com with SMTP id f90so145556plb.10; Mon, 11 Feb 2019 13:18:20 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=p5ZCXTBfLok1XMf+SlQNjbPYGN3N8X4VxG7Tq+I0H5E=; b=OSIA8Fj2pOi8lhCDKo5ZYKT8u0H9kmPzH/BVhtIGSchGYFx56fFEUVkxdOe3G5YDkL ZyMPiBo7zqGPKB4r03DMaloM7CdCi5cKXAyj4GcrEQ03C9UiMUa6zx0Cw6OmP+RLSL2B o39SdzxdfHh1qq4yZB0xdtfFIwpH0lXDFenjKudDnO154i8DAPuDZjLJOquTiniHgnOk DCD/zJNkUN9KAB1IR16U/hgB8kfOwh4+nqZJPmrir7gYBUYPURe7sL4Bxx6VkrzRgb2P mtGQ7MeofN/DlFTywGxbwpUEVZLBQG5kSBYes1HY958iFY+RZFQoiu7VYZAiDNTEpg6h 3TyQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=p5ZCXTBfLok1XMf+SlQNjbPYGN3N8X4VxG7Tq+I0H5E=; b=f5kOy0vUn/4MF4thHGH3a50K1R+28S1N9pgnQY4Kj11LD6b4TaRvSSDKwWwW0b5ntk MfdupTyaa36RcCmQakJJL/EDURpVEx4n+CdFfsA9amnM0sTnMuLBlq0eyzC21r/ExXPG y1BauLPPkrM4BKcYrmmHQFIzP0dmNaYWyjLnBZcdEeZZdN5NWRtPdY4/UEjrF4P+UX+v QdyYHp1EOZWSylDmPPSa9GRIu0oRDQxaf4zMyCRqFju+vCveKAAP9YqK9tihnX6WKTxs EFyvUrMHBBPvzI+gWdi8s92QFa8nFqwdLPkUOowLujK/f+W544qlB1ACxqZP8W04ZJTN 2dIw== X-Gm-Message-State: AHQUAuavRoSjCqD3UFZ30bm08dPg7lskAqCMHnsrIWo6ZL8UBhbBHAlc 7Zwp04TSiVKkFXU01mWlMgHwGKy2 X-Received: by 2002:a17:902:aa01:: with SMTP id be1mr315854plb.60.1549919900159; Mon, 11 Feb 2019 13:18:20 -0800 (PST) Received: from fainelli-desktop.igp.broadcom.net ([192.19.223.250]) by smtp.gmail.com with ESMTPSA id 24sm15213029pfr.75.2019.02.11.13.18.16 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Mon, 11 Feb 2019 13:18:19 -0800 (PST) From: Florian Fainelli To: netdev@vger.kernel.org Cc: Florian Fainelli , "David S. Miller" , Ido Schimmel , linux-kernel@vger.kernel.org (open list), devel@driverdev.osuosl.org (open list:STAGING SUBSYSTEM), bridge@lists.linux-foundation.org (moderated list:ETHERNET BRIDGE), jiri@mellanox.com, andrew@lunn.ch, vivien.didelot@gmail.com Subject: [PATCH net-next 2/3] rocker: Remove getting PORT_BRIDGE_FLAGS Date: Mon, 11 Feb 2019 13:17:48 -0800 Message-Id: <20190211211749.19847-3-f.fainelli@gmail.com> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20190211211749.19847-1-f.fainelli@gmail.com> References: <20190211211749.19847-1-f.fainelli@gmail.com> Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org There is no code that attempts to get the SWITCHDEV_ATTR_ID_PORT_BRIDGE_FLAGS attribute, remove support for that. Signed-off-by: Florian Fainelli --- drivers/net/ethernet/rocker/rocker.h | 2 -- drivers/net/ethernet/rocker/rocker_main.c | 15 --------------- drivers/net/ethernet/rocker/rocker_ofdpa.c | 10 ---------- 3 files changed, 27 deletions(-) diff --git a/drivers/net/ethernet/rocker/rocker.h b/drivers/net/ethernet/rocker/rocker.h index 748fb12260a6..2b2e1c4f0dc3 100644 --- a/drivers/net/ethernet/rocker/rocker.h +++ b/drivers/net/ethernet/rocker/rocker.h @@ -109,8 +109,6 @@ struct rocker_world_ops { int (*port_attr_bridge_flags_set)(struct rocker_port *rocker_port, unsigned long brport_flags, struct switchdev_trans *trans); - int (*port_attr_bridge_flags_get)(const struct rocker_port *rocker_port, - unsigned long *p_brport_flags); int (*port_attr_bridge_flags_support_get)(const struct rocker_port * rocker_port, unsigned long * diff --git a/drivers/net/ethernet/rocker/rocker_main.c b/drivers/net/ethernet/rocker/rocker_main.c index 66f72f8c46e5..5ce8d5aba603 100644 --- a/drivers/net/ethernet/rocker/rocker_main.c +++ b/drivers/net/ethernet/rocker/rocker_main.c @@ -1582,17 +1582,6 @@ rocker_world_port_attr_bridge_flags_set(struct rocker_port *rocker_port, trans); } -static int -rocker_world_port_attr_bridge_flags_get(const struct rocker_port *rocker_port, - unsigned long *p_brport_flags) -{ - struct rocker_world_ops *wops = rocker_port->rocker->wops; - - if (!wops->port_attr_bridge_flags_get) - return -EOPNOTSUPP; - return wops->port_attr_bridge_flags_get(rocker_port, p_brport_flags); -} - static int rocker_world_port_attr_bridge_flags_support_get(const struct rocker_port * rocker_port, @@ -2061,10 +2050,6 @@ static int rocker_port_attr_get(struct net_device *dev, int err = 0; switch (attr->id) { - case SWITCHDEV_ATTR_ID_PORT_BRIDGE_FLAGS: - err = rocker_world_port_attr_bridge_flags_get(rocker_port, - &attr->u.brport_flags); - break; case SWITCHDEV_ATTR_ID_PORT_BRIDGE_FLAGS_SUPPORT: err = rocker_world_port_attr_bridge_flags_support_get(rocker_port, &attr->u.brport_flags_support); diff --git a/drivers/net/ethernet/rocker/rocker_ofdpa.c b/drivers/net/ethernet/rocker/rocker_ofdpa.c index bea7895930f6..9c07f6040720 100644 --- a/drivers/net/ethernet/rocker/rocker_ofdpa.c +++ b/drivers/net/ethernet/rocker/rocker_ofdpa.c @@ -2511,16 +2511,6 @@ static int ofdpa_port_attr_bridge_flags_set(struct rocker_port *rocker_port, return err; } -static int -ofdpa_port_attr_bridge_flags_get(const struct rocker_port *rocker_port, - unsigned long *p_brport_flags) -{ - const struct ofdpa_port *ofdpa_port = rocker_port->wpriv; - - *p_brport_flags = ofdpa_port->brport_flags; - return 0; -} - static int ofdpa_port_attr_bridge_flags_support_get(const struct rocker_port * rocker_port, -- 2.17.1