Received: by 2002:ac0:946b:0:0:0:0:0 with SMTP id j40csp3132593imj; Mon, 11 Feb 2019 14:37:20 -0800 (PST) X-Google-Smtp-Source: AHgI3IbkJFIA1nIe2CdB7hmKTUR1DotGzRcavet8fmeSN5PTvpjE7DYLhNoX59niBttYd43+l4Pn X-Received: by 2002:a63:e74b:: with SMTP id j11mr515598pgk.397.1549924640290; Mon, 11 Feb 2019 14:37:20 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1549924640; cv=none; d=google.com; s=arc-20160816; b=DidqwZB2pTZW0CK9BibGBRdydJ1y5ctpGHtwVjgLS+84nrN+KOAAwRxyXMJPMTqIqp Uwj2tqvhHGknSYIYVwU9Yw7iLGTo1Wz/+o3ZTlk6NzVShKAsak7h8pZXpYMLdPByfsB9 G9IIOS/Qi9UKAR12HL48hIXEkOzBtSdFKVkk6GtgnN2j73JJyUGn74oV0ucbn809MpHh ZHwj+MMP6yV5dJAzy129SnufeLN8XR8RcPCKnEBGC6xwz3L5HmELUuDurcJxDsEGMjuM qP6jgHYoX+J+y6F0w5GnGhNk+mR40Cxbp/JlkslcnDmepB1mwrZBWdWm6CL7g3UfNUAi 3iSw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:content-transfer-encoding :content-disposition:mime-version:message-id:subject:cc:to:from:date; bh=SkGFCO7YIuRW7TWzpBy06bCGjkjvX+y2ICbINIIuAhQ=; b=nyVqr6lMXggb8HaV8YcX+nql7yCTOaqjypSVhWkY7DPEAgsKSYfTez4fWMvx+Mny4x PO26JKDQXr5TAVtmI4zv6gs8eL4Dlxt0iyFMtM4z//pyk2/oqdhQtN8h9SyzC1VKkyHK Q9xsHQ9cKRScE2fIb+6RsxHUHtrXwoNuRMv8NRsfxoc8k8y1reQ3mU2N9WjnQpfvUolu OsMTQQwHSVQ2jp9ywtGXp+bvRWDMYvY+XYEeK/hhFTUOZ5lZezwND+lLZ4pURoZnDrbX OP92ExUjr7u9BYEa5zvwCboFg3uMBnAfB065oPB5c3dECcfOvUu2MoNG7c3bRf3UNl9n 6QUg== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id v7si10815177pga.15.2019.02.11.14.37.03; Mon, 11 Feb 2019 14:37:20 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727325AbfBKWfP (ORCPT + 99 others); Mon, 11 Feb 2019 17:35:15 -0500 Received: from gateway22.websitewelcome.com ([192.185.46.131]:26277 "EHLO gateway22.websitewelcome.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727006AbfBKWfN (ORCPT ); Mon, 11 Feb 2019 17:35:13 -0500 Received: from cm12.websitewelcome.com (cm12.websitewelcome.com [100.42.49.8]) by gateway22.websitewelcome.com (Postfix) with ESMTP id 9F234D2FF for ; Mon, 11 Feb 2019 16:35:12 -0600 (CST) Received: from gator4166.hostgator.com ([108.167.133.22]) by cmsmtp with SMTP id tKASgB9yeiQertKASgQnNs; Mon, 11 Feb 2019 16:35:12 -0600 X-Authority-Reason: nr=8 Received: from [189.250.119.20] (port=33708 helo=embeddedor) by gator4166.hostgator.com with esmtpa (Exim 4.91) (envelope-from ) id 1gtKA2-004H10-Ke; Mon, 11 Feb 2019 16:35:12 -0600 Date: Mon, 11 Feb 2019 16:34:44 -0600 From: "Gustavo A. R. Silva" To: Paul Bolle , Karsten Keil Cc: gigaset307x-common@lists.sourceforge.net, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, "Gustavo A. R. Silva" , Kees Cook Subject: [PATCH] ser_gigaset: mark expected switch fall-through Message-ID: <20190211223444.GA29517@embeddedor> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit User-Agent: Mutt/1.9.4 (2018-02-28) X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - gator4166.hostgator.com X-AntiAbuse: Original Domain - vger.kernel.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - embeddedor.com X-BWhitelist: no X-Source-IP: 189.250.119.20 X-Source-L: No X-Exim-ID: 1gtKA2-004H10-Ke X-Source: X-Source-Args: X-Source-Dir: X-Source-Sender: (embeddedor) [189.250.119.20]:33708 X-Source-Auth: gustavo@embeddedor.com X-Email-Count: 35 X-Source-Cap: Z3V6aWRpbmU7Z3V6aWRpbmU7Z2F0b3I0MTY2Lmhvc3RnYXRvci5jb20= X-Local-Domain: yes Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org In preparation to enabling -Wimplicit-fallthrough, mark switch cases where we are expecting to fall through. This patch fixes the following warning: drivers/isdn/gigaset/ser-gigaset.c: In function ‘gigaset_tty_ioctl’: drivers/isdn/gigaset/ser-gigaset.c:627:3: warning: this statement may fall through [-Wimplicit-fallthrough=] switch (arg) { ^~~~~~ drivers/isdn/gigaset/ser-gigaset.c:638:2: note: here default: ^~~~~~~ Warning level 3 was used: -Wimplicit-fallthrough=3 Notice that, in this particular case, the code comment is modified in accordance with what GCC is expecting to find. This patch is part of the ongoing efforts to enable -Wimplicit-fallthrough. Signed-off-by: Gustavo A. R. Silva --- drivers/isdn/gigaset/ser-gigaset.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/isdn/gigaset/ser-gigaset.c b/drivers/isdn/gigaset/ser-gigaset.c index ab0b63a4d045..e1de8b1a1001 100644 --- a/drivers/isdn/gigaset/ser-gigaset.c +++ b/drivers/isdn/gigaset/ser-gigaset.c @@ -633,7 +633,7 @@ gigaset_tty_ioctl(struct tty_struct *tty, struct file *file, flush_send_queue(cs); break; } - /* Pass through */ + /* fall through */ default: /* pass through to underlying serial device */ -- 2.20.1