Received: by 2002:ac0:946b:0:0:0:0:0 with SMTP id j40csp3502748imj; Mon, 11 Feb 2019 23:06:22 -0800 (PST) X-Google-Smtp-Source: AHgI3IbpWfn1GtsjvNIENbmFTqMvq1JvdhjPuFLGr5+msFXzqLuvNlJUjgFw0mFcUKIQ1VlvIdv4 X-Received: by 2002:a17:902:402:: with SMTP id 2mr2431800ple.318.1549955182178; Mon, 11 Feb 2019 23:06:22 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1549955182; cv=none; d=google.com; s=arc-20160816; b=ndy++fDOmBytGrgl7lcloiTj+X/RwAYUZF5zUSCoabK4uLh2QfluCJY/eEp2F3AoZZ xsbKe+E13YjRIBrS20VxF8jWJrBnGwJYJEVzN/T93PK2INuMNjAqhSW5V1EdlMQjdmnr mX5UKalaciUp1yowr4RMq9VgjzRDTJE5NPMkk00ZC9TFtpf72KO7Rw8SQS0/wXS3wI9B fUg/4O1345qhPkesX1YLPhkKDc98tAYXvhFGUma0oJ9fEaZBv48X6FLcLpnL54DtoSar 1U+fo5FCLwf/XBuTY8mEWcGKX5JCj63slMnlTeZaJ4o2wcHR4VV3gWMY32N/NdBu93Sp BpUg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:in-reply-to :content-disposition:mime-version:references:message-id:subject:cc :to:from:date:dkim-signature; bh=7u9xjmOMAuk27iPJmPyFoypju05cfybxJz2gEHJlVV4=; b=UMqWkGwi0Wi6WUkxT9/Cx1SWlOpFf/DfeFHQZnTjBEt9KIzYTS1eopWnPY+R9EX1z7 DTxPW0cwqxoyt36JUNwbN6UKLHAm9CGzOA0udK6pthQKPq3+IJ1ZrRP4tIFM4YIgrWwg sV2KehK5P8qRTnAEFop8ANCuj2GIcrd/K1xPs15ZaUA7xK3k4Qm1ByjIJumbKxFR3X4o 0FnZAhzbJZwCxVXu71Qx06p0yuEotw88UkLV2pnRKoj92Qg72EO9O+gZvpPzu/HbbWOE gpwVPmPXGH+LvqaRVYiEMpReVPVIZqZhLbO5VToXGfW81tQh1lcGTLlkBVbBAqJmcNhq ozOQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=fail header.i=@infradead.org header.s=bombadil.20170209 header.b=faJjU0r1; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id c3si12236453plr.178.2019.02.11.23.06.03; Mon, 11 Feb 2019 23:06:22 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=fail header.i=@infradead.org header.s=bombadil.20170209 header.b=faJjU0r1; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727312AbfBLHF7 (ORCPT + 99 others); Tue, 12 Feb 2019 02:05:59 -0500 Received: from bombadil.infradead.org ([198.137.202.133]:59164 "EHLO bombadil.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726059AbfBLHF7 (ORCPT ); Tue, 12 Feb 2019 02:05:59 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20170209; h=In-Reply-To:Content-Type:MIME-Version :References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Id: List-Help:List-Unsubscribe:List-Subscribe:List-Post:List-Owner:List-Archive; bh=7u9xjmOMAuk27iPJmPyFoypju05cfybxJz2gEHJlVV4=; b=faJjU0r1Wltmsj8vgU7rajLrj VPYlZfB/UxLS7RXF0bPKdNsb5SS9mZThybJzmHrTnWYe5QswJnuhwINYtgi6ZaPRfcbibb1KWIkTB lVYqs/X/TzlHByFThh8FTEuvAuOpZ21JZUrbVsAcaI5EG2g8jOgoqqZe9gYYEGVEtkfa+iwrGtu1f KbRb37gOAktc8Muw1Mb18yKu7kd/q7V99GifrIz6R+geE3wEUuKRAP1SCCCGrZkD69T/+RToOpb09 X8mZQPpy3KyxYaCxajZBsm3rWaO+PnlvwkWbMiFmhyTUbhkAsAPuuKYmiwDuDno42tWC7lhXZVYvr 519XPUC3g==; Received: from hch by bombadil.infradead.org with local (Exim 4.90_1 #2 (Red Hat Linux)) id 1gtS8j-0000Ba-OY; Tue, 12 Feb 2019 07:05:57 +0000 Date: Mon, 11 Feb 2019 23:05:57 -0800 From: Christoph Hellwig To: Anup Patel Cc: Palmer Dabbelt , Albert Ou , "linux-kernel@vger.kernel.org" , Christoph Hellwig , Atish Patra , Paul Walmsley , "linux-riscv@lists.infradead.org" Subject: Re: [PATCH v2 2/6] RISC-V: Setup init_mm before parse_early_param() Message-ID: <20190212070557.GB26747@infradead.org> References: <20190119132650.9978-1-anup.patel@wdc.com> <20190119132650.9978-3-anup.patel@wdc.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20190119132650.9978-3-anup.patel@wdc.com> User-Agent: Mutt/1.9.2 (2017-12-15) X-SRS-Rewrite: SMTP reverse-path rewritten from by bombadil.infradead.org. See http://www.infradead.org/rpr.html Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sat, Jan 19, 2019 at 01:28:07PM +0000, Anup Patel wrote: > We should setup init_mm before doing parse_early_param() > in setup_arch() to be consistent with setup_arch() of > other architectures such as x86, ARM, and ARM64. Please use up all 72 lines in all your commit logs.. Otherwise looks fine: Reviewed-by: Christoph Hellwig