Received: by 2002:ac0:946b:0:0:0:0:0 with SMTP id j40csp3509039imj; Mon, 11 Feb 2019 23:14:29 -0800 (PST) X-Google-Smtp-Source: AHgI3IZIIfN2Cz4k7Z/2avALjX52tuvy+IomISEJZuuxqtn0koYBOoSLG10IFVtIKuFIdmarU19T X-Received: by 2002:a17:902:5601:: with SMTP id h1mr2651761pli.160.1549955669094; Mon, 11 Feb 2019 23:14:29 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1549955669; cv=none; d=google.com; s=arc-20160816; b=UdAb9V6NtK1QJy62JlUD21trJnkCbRpBnSMbYfGazPcr/reuOKXlMJd9RK5ZlrtoRG 6TbF0ngCH6RrKTEzDK6A4SXJusYieOOX+WM/jtQYZPXOh6GJZFksNDgcOLhQv1o19M1A DZ2R36HRyb70j4c9ajJxDQyXmiCcZc2i98KygHIeD73S7jRf8gYKJSTjsKtU/rwreKTx A3A9undhpdPosMYAwWZD5jIUqEOJZVBI1newt+BWoGe12EcdV/N855G6ZKl1iTii7fXu RyXwC+M2RqM0vnTLXohcCWu5EdSicMD8FSGKtDzSin2ZzLIhbw/sXUVXJVU/f7AbubrV xk9A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:in-reply-to :content-disposition:mime-version:references:message-id:subject:cc :to:from:date:dkim-signature; bh=eMDjoxEoIkUplQKJxvXKElX2XrBEFAeIGJy5ImjjJI8=; b=sNpW8nRalWoZ2Xy2voWTMclo3Hz+l2g06/kDC5O+dhpVX0QIFgaU09nnOpf1MbHZif jsea03EtRwMHensDlu5euxPLiIop9M9XEo7Fn2ZLqDIyLbcFetPZ2uxfmxFi9nKVsR3G RujCEVs6nhvng0Wt37ymk6wANHI8qck2irvVSW1kYhMyaTCuoS8nWPCsHHYqvcN9/y9V CNSnHVTRRuvcyyQqjC5uPbRtKsI+QfU0ss0CmCFu8obKjY5jBBxqvqSUha1C5xo2ssEC 44s9anq6qRrq1QGpqsQolmf4APPkYqZt/bERCwpldLpP85vs/QvMTuB31ARwNQatPMcb e4NA== ARC-Authentication-Results: i=1; mx.google.com; dkim=fail header.i=@infradead.org header.s=bombadil.20170209 header.b=AVzlxxx5; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id a2si662903pfb.166.2019.02.11.23.14.12; Mon, 11 Feb 2019 23:14:29 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=fail header.i=@infradead.org header.s=bombadil.20170209 header.b=AVzlxxx5; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728032AbfBLHMZ (ORCPT + 99 others); Tue, 12 Feb 2019 02:12:25 -0500 Received: from bombadil.infradead.org ([198.137.202.133]:36934 "EHLO bombadil.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725916AbfBLHMY (ORCPT ); Tue, 12 Feb 2019 02:12:24 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20170209; h=In-Reply-To:Content-Type:MIME-Version :References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Id: List-Help:List-Unsubscribe:List-Subscribe:List-Post:List-Owner:List-Archive; bh=eMDjoxEoIkUplQKJxvXKElX2XrBEFAeIGJy5ImjjJI8=; b=AVzlxxx5ZIYTtcLAxZXMeXljM zQ2dkwWLgx4aUBCCTf21DicM/YUymuUuz5OhEEfeak3Zzv0/YgkdAPnn6nCzn7v+xK8a0zwX9Fl+7 Oki2cLbnwZC2lsqxYe/lAx+rp2K5jJvfZAQoP9ivhUpXNTQFATnroicmYxoQtdLjORnwO9JK0gm7h SUB4ZXSSWmAKY5+XxiJ1jEzVCVcJN3D0++zST+ZqtHcGpZojvKaHI0iLfq9FKL/XDkqmwTivk0w4+ ECTOWjeCiz91VQqUVC4sd70rCekxq6cH73FGoauWFd8P57PCxyz4XUHZVYLhEpO4ua0dwPexQRMaL MexcWFCQw==; Received: from hch by bombadil.infradead.org with local (Exim 4.90_1 #2 (Red Hat Linux)) id 1gtSEx-0002w5-Cs; Tue, 12 Feb 2019 07:12:23 +0000 Date: Mon, 11 Feb 2019 23:12:23 -0800 From: Christoph Hellwig To: Johan Hovold Cc: Palmer Dabbelt , Albert Ou , Andreas Schwab , linux-kernel@vger.kernel.org, Atish Patra , Anup Patel , linux-riscv@lists.infradead.org Subject: Re: [PATCH 3/5] riscv: fix riscv_of_processor_hartid() comment Message-ID: <20190212071223.GJ26747@infradead.org> References: <20190118140308.9599-1-johan@kernel.org> <20190118140308.9599-4-johan@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20190118140308.9599-4-johan@kernel.org> User-Agent: Mutt/1.9.2 (2017-12-15) X-SRS-Rewrite: SMTP reverse-path rewritten from by bombadil.infradead.org. See http://www.infradead.org/rpr.html Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Jan 18, 2019 at 03:03:06PM +0100, Johan Hovold wrote: > The riscv_of_processor_hartid() helper returns -ENODEV when the > specified node isn't an enabled and valid RISC-V hart node. > > Also drop the unnecessary parenthesis around errno defines. > > Signed-off-by: Johan Hovold Looks good, Reviewed-by: Christoph Hellwig