Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Subject: Re: [RESEND PATCH v2 02/33] ARM: davinci: aintc: use irq domain
To:     Bartosz Golaszewski <brgl@bgdev.pl>,
        Kevin Hilman <khilman@kernel.org>,
        Thomas Gleixner <tglx@linutronix.de>,
        Jason Cooper <jason@lakedaemon.net>,
        Marc Zyngier <marc.zyngier@arm.com>,
        David Lechner <david@lechnology.com>
CC:     <linux-arm-kernel@lists.infradead.org>,
        <linux-kernel@vger.kernel.org>,
        Bartosz Golaszewski <bgolaszewski@baylibre.com>
References: <20190211122606.8662-1-brgl@bgdev.pl>
 <20190211122606.8662-3-brgl@bgdev.pl>
From:   Sekhar Nori <nsekhar@ti.com>
Message-ID: <74c9ae73-a6a2-1a76-3872-3a1950ac8dfb@ti.com>
Date:   Tue, 12 Feb 2019 13:56:38 +0530
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101
 Thunderbird/60.4.0
MIME-Version: 1.0
In-Reply-To: <20190211122606.8662-3-brgl@bgdev.pl>
Content-Type: text/plain; charset="utf-8"
Content-Language: en-US
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On 11/02/19 5:55 PM, Bartosz Golaszewski wrote:
> @@ -74,6 +75,7 @@ void __init davinci_irq_init(void)
>  {
>  	unsigned i, j;
>  	const u8 *davinci_def_priorities = davinci_soc_info.intc_irq_prios;
> +	int rv, irq_base;
>  
>  	davinci_intc_type = DAVINCI_INTC_TYPE_AINTC;
>  	davinci_intc_base = ioremap(davinci_soc_info.intc_base, SZ_4K);
> @@ -110,8 +112,25 @@ void __init davinci_irq_init(void)
>  		davinci_irq_writel(pri, i);
>  	}
>  
> +	irq_base = irq_alloc_descs(-1, 0, davinci_soc_info.intc_irq_num, 0);
> +	if (WARN_ON(irq_base < 0))
> +		return;
> +
> +	davinci_irq_domain = irq_domain_add_legacy(NULL,
> +					davinci_soc_info.intc_irq_num,
> +					irq_base, 0, &irq_domain_simple_ops,
> +					NULL);
> +	if (WARN_ON(!davinci_irq_domain))
> +		return;
> +
> +	rv = irq_alloc_domain_generic_chips(davinci_irq_domain, 32, 1,
> +					    "AINTC", handle_edge_irq,
> +					    IRQ_NOREQUEST | IRQ_NOPROBE, 0, 0);
> +	if (WARN_ON(rv))
> +		return;

Like you have done in other places, use "ret" instead of "rv" for
consistency.

Thanks,
Sekhar