Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
MIME-Version: 1.0
References: <20190131095625.261755-1-pihsun@chromium.org> <511a36863af02aec12fd77657b0ca199e023f319.camel@perches.com>
In-Reply-To: <511a36863af02aec12fd77657b0ca199e023f319.camel@perches.com>
From:   Pi-Hsun Shih <pihsun@chromium.org>
Date:   Tue, 12 Feb 2019 16:47:03 +0800
Message-ID: <CANdKZ0dEFr5TAuat16sEKm=B3bRa5nqBvR3OCM=hzKGcBQKbJA@mail.gmail.com>
Subject: Re: [PATCH] checkpatch: Properly detect /* */ style SPDX header.
To:     Joe Perches <joe@perches.com>
Cc:     Andy Whitcroft <apw@canonical.com>,
        open list <linux-kernel@vger.kernel.org>
Content-Type: text/plain; charset="UTF-8"
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On Fri, Feb 1, 2019 at 12:54 AM Joe Perches <joe@perches.com> wrote:
>
> On Thu, 2019-01-31 at 17:56 +0800, Pi-Hsun Shih wrote:
> > Currently for a header line "/* SPDX-License-Identifier: GPL-2.0 */",
> > only the part starting from "SPDX-" is passed to spdxcheck.py, and cause
> > false warning. Fix this by passing the whole line to spdxcheck.py
> > instead.
>
> Thanks but I submitted a different patch:
>
> https://lore.kernel.org/lkml/8b02899853247a2c67669561761f354dd3bd110e.camel@perches.com/
>

I tried your patch, but when running checkpatch.pl on
https://patchwork.kernel.org/patch/10790203/, I still get:
WARNING: 'SPDX-License-Identifier: GPL-2.0 */' is not supported in LICENSES/...
#75: FILE: drivers/remoteproc/mtk_common.h:1:
+/* SPDX-License-Identifier: GPL-2.0 */

Feels that these two patches fix different issues.