Received: by 2002:ac0:946b:0:0:0:0:0 with SMTP id j40csp3591708imj; Tue, 12 Feb 2019 01:05:44 -0800 (PST) X-Google-Smtp-Source: AHgI3IYvD1OMjpqgThpolcD21w00ZajkJ1zhM+f3TS5019Js3pivG/soWWJ6MqqHJKwymghWSiMp X-Received: by 2002:a63:fa10:: with SMTP id y16mr2640106pgh.88.1549962343587; Tue, 12 Feb 2019 01:05:43 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1549962343; cv=none; d=google.com; s=arc-20160816; b=D5pZudLfO3Li9oB10OcAK4WYHhXNvIdgOTBjsc7ay+d8pu93EhcTQgNcI7ccoVM3Q6 9UZIP8XiUi4MDyBBk5cUT/QB0W+FfBMwM0UuT/KUUfVsQOJ8h+Ke5pkVA0lrvtiihxmn rFcr2vqmVxCfIC3+SYU9e1xs6J9RNRL649OrPYETlbiJB/K1KCzd5+6RHxOQ06Mu/XyH MjJnSjnusFHmskgJDohX+5lKw7wyC4fiLM9hclIlC+NzOxVaVlu56bjsH040UXHcdxqT FMdfHpJF89Im58iSexZphk/0jEd7FomqjnxLp4bpqBbKEVhvxRO4ONdXWu1m2AZawaWq +iSA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:in-reply-to :content-disposition:mime-version:references:message-id:subject:cc :to:from:date:dkim-signature; bh=9JE1KUAaeIF0Eqil7KjRb60SMtOMHOgTxiw3v8XiNgE=; b=HBo4pNoaJKLccKi/IOYds5KjeuciSR1EKcfVdesykkI0Casx936eGgyiK08QqTSB6e ZTW71tS0TH4MZLtlYWHw3CltXTrSEhYgyBolVrhPdW9Yw/9G6ER1LSDzlfr9ztwde4k6 h8diPu7Fc6nuoyLBjmHpIbQUhvOGDyUqdTmSUeyB5+A4Gjp9DOieNQFqMsnKIk15Pciz EX4norFPqNlYkZ+dXSdKcJVOw0D2JuzgyuUOzxuQuF9prYn7GIdomxbZQ7ecBXRALhjo 3TE3l4g7DYbwUBQhFle7lcUkdYQKQMHq79BX8Kbzr+Gi/JYMJ5de1NKlyC5rrToF6oM2 lFiw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@resnulli-us.20150623.gappssmtp.com header.s=20150623 header.b=Pg6qh0gL; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id y35si4280026pgl.569.2019.02.12.01.05.26; Tue, 12 Feb 2019 01:05:43 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@resnulli-us.20150623.gappssmtp.com header.s=20150623 header.b=Pg6qh0gL; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728654AbfBLJFQ (ORCPT + 99 others); Tue, 12 Feb 2019 04:05:16 -0500 Received: from mail-wr1-f66.google.com ([209.85.221.66]:38806 "EHLO mail-wr1-f66.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728086AbfBLJFQ (ORCPT ); Tue, 12 Feb 2019 04:05:16 -0500 Received: by mail-wr1-f66.google.com with SMTP id v13so1762363wrw.5 for ; Tue, 12 Feb 2019 01:05:14 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=resnulli-us.20150623.gappssmtp.com; s=20150623; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=9JE1KUAaeIF0Eqil7KjRb60SMtOMHOgTxiw3v8XiNgE=; b=Pg6qh0gLb+h0h2pEYTpLbPLqyaPQ7seYet07ukPSuUkxnF/BRrOiDgTK1oyyGgN6/9 2hrBCT97S8f8rDsK2vo9z7SKsZnp/km6t0cAUGnwKvQjJTobBeVVAFJsRCkHrW1XbjqY DHR+3CWsz7+XdTOHE9hI0aVAKNFMfgTFxzSr/t9fuSsjQGyBsYiMOpmRRz2mkcgvNxA4 4ZKatl5MZlYnh2PE8zRro7ZpNmMvKZUnymJAhg1Sx4Shcxf7tBtaHDJLm3ml/TYrPym5 VZjtsbHvTKT0gzAcLTJUjy4IVViexDIRf0AndnIKk+JJwK4g9ujzLwqUQPkx/d/S/2ga oZbw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=9JE1KUAaeIF0Eqil7KjRb60SMtOMHOgTxiw3v8XiNgE=; b=pte4eOt0JdDE1REGpb9UTLIg6PFa3kQdSXkqsR77vQIcI4G/04lwSsCQYRoZtHoJ0O 0FXzVQt2Ut9HLUwdKpe6KCkJgwdpkK8IxFxAujVLhHaCOSo4tsKF5bR7Wu/l44zMl/mv mQPUpZO/Va4J1AXIsgLHsg+fcjuJpMiKg9Ajprzq2bgu5lIpFbv2px1EpP51qwQpeRxZ HsKnGk2bwKRu6UhwI/3flf9azIWalQ5LulIGdDMkt+vtMy6EcAraCtXtFmOqTfqcXMD1 KbdOFViXyCATrVTB+m8bdNoHEXMRJ7KpNI3skxy9wNQZ/U2qlrlcXLDGP9lhoKhFvnus pOUQ== X-Gm-Message-State: AHQUAuaPb94ubyU3rQrQrK7SYxwcjNib36j7iL8oT0KhuBZQRAqcCmee 8dSZgp7z6C8rwdlW0yUiphWChQ== X-Received: by 2002:adf:9167:: with SMTP id j94mr2067590wrj.106.1549962314208; Tue, 12 Feb 2019 01:05:14 -0800 (PST) Received: from localhost (mail.chocen-mesto.cz. [85.163.43.2]) by smtp.gmail.com with ESMTPSA id m4sm2556469wmi.3.2019.02.12.01.05.13 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Tue, 12 Feb 2019 01:05:13 -0800 (PST) Date: Tue, 12 Feb 2019 09:55:49 +0100 From: Jiri Pirko To: Florian Fainelli Cc: netdev@vger.kernel.org, "David S. Miller" , Ido Schimmel , open list , "open list:STAGING SUBSYSTEM" , "moderated list:ETHERNET BRIDGE" , jiri@mellanox.com, andrew@lunn.ch, vivien.didelot@gmail.com Subject: Re: [PATCH net-next 0/3] Remove getting SWITCHDEV_ATTR_ID_PORT_BRIDGE_FLAGS Message-ID: <20190212085549.GB2881@nanopsycho> References: <20190211211749.19847-1-f.fainelli@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20190211211749.19847-1-f.fainelli@gmail.com> User-Agent: Mutt/1.10.1 (2018-07-13) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Mon, Feb 11, 2019 at 10:17:46PM CET, f.fainelli@gmail.com wrote: >Hi all, > >AFAICT there is no code that attempts to get the value of the attribute >SWITCHDEV_ATTR_ID_PORT_BRIDGE_FLAGS while it is used with >switchdev_port_attr_set(). > >This is effectively no doing anything and it can slow down future work >that tries to make modifications in these areas so remove that. > >David, there should be no dependency with previous patch series, but >again, feedback from Ido and Jiri would be welcome in case this was >added for a reason. It was originally used by: switchdev_port_bridge_getlink() removed by: commit 29ab586c3d83f81c435e269cace9a1619afb5bbd Author: Arkadi Sharshevsky Date: Sun Aug 6 16:15:51 2017 +0300 net: switchdev: Remove bridge bypass support from switchdev So these are just leftovers. Let's flush them.