Received: by 2002:ac0:946b:0:0:0:0:0 with SMTP id j40csp3709676imj; Tue, 12 Feb 2019 03:24:26 -0800 (PST) X-Google-Smtp-Source: AHgI3IYAaS7CBsYfuYOcn7qu700dAZ/0pP7lTHQYZ3M3pNuWXvvQhvnjQAzZRyvARpRBHF4yytJF X-Received: by 2002:a62:47d9:: with SMTP id p86mr3415781pfi.95.1549970665900; Tue, 12 Feb 2019 03:24:25 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1549970665; cv=none; d=google.com; s=arc-20160816; b=JmvufJyUVIYXepoK7+i+qKKxO55O+YIpKH+jJccm5MzlbWkvT/z/SutNS7W77Q7Hu2 ZOWK6vpv9Pt6knpGXHZ2DVNTD+v9geWSQFTn3kmOUqWp9VfYd4rGAM8CeM6l3+mf4uS3 vzCHZ0xBOc+X/wGxyh6dkQ/Rn3LBHH5KiWH9fb6qmrKg3y5rNlGdANxrI4DYpGE/D5cZ 4Xl8epFIauaDRKoRDaIGCMjBvaf1ywOGP1O3c1ybdGwPfMGydHuuCHfnYjU4bDyb9zYF eyZRrRQsQMmMXoSm467M9N5ai/WoPCCYFeN3b2aSERQ7uPPLpuxkVGi1KT/qcCfrXO6W YEjg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:dkim-signature; bh=Ysrs7O4XTNHbvtUzCcBIUDGeAY1c+7Daeugzgccm8iU=; b=ITQKHVz/hIHiqxWpTnGBfExo5GG6zkj7XUhyPfR24Tdy/GBlWzc4oiPqOx7Kn/M+R5 vxYFlg4tH3pzityDcPuGhCgiiCJtgPWFm7qDB613OvCBpIzTbhHGs4ao2P9Yb3fXQfpq NmXgFGvScIPldAIVGDqjeCE3hDHuBo0u95muqm7gz6Q/YarMStClV2/VLeyisUqd8+q3 TBk+c6UPof+adQ2B6N990h5ENMljtcBLROuS59n5B2kfdc83KTR1HB2ZORMDp4urDCKk VcNvjRRpdO7/IyYE3E0PJ2X7w69d3eTdcr06ifXHOJRVsLKhc01iMNcVNWlotOLxkvCh PwWw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=DK5Q1Y+7; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id p7si3076037pls.283.2019.02.12.03.24.10; Tue, 12 Feb 2019 03:24:25 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=DK5Q1Y+7; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729082AbfBLLAq (ORCPT + 99 others); Tue, 12 Feb 2019 06:00:46 -0500 Received: from mail-yw1-f65.google.com ([209.85.161.65]:41225 "EHLO mail-yw1-f65.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728940AbfBLLAp (ORCPT ); Tue, 12 Feb 2019 06:00:45 -0500 Received: by mail-yw1-f65.google.com with SMTP id q128so369315ywg.8 for ; Tue, 12 Feb 2019 03:00:45 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=Ysrs7O4XTNHbvtUzCcBIUDGeAY1c+7Daeugzgccm8iU=; b=DK5Q1Y+7nBvI8ZtpUFCMnauiDQWU4LGZXXrmyHolKdselBSjPMAZPyIN3zU4Iugxrj wm6L86CYf8Uj7B78xFCE+7zDPajhYaxRMRHD19O4NLEDsR/6ynB5lR7QOADjBCovIyOS iB0PTjk5/4guFzs+ELbTH537Ku/BdLYmC2srDzcU84Y1aXKrDh5g8+q/ohHTwIKJTfEn 1PKHr40oa/3rhkp3KKAxgPF4ae/KPbs4lF5PmIj8nKSgGfRl6aYOQwS9hRHQFNoocNm7 pEWnCJJwX/bNKxiVxF4gY6FC1DEMHefSnrmy+gD8QQhVEk4y2OrjE0ZbFtG9O07I2U6k 93kQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=Ysrs7O4XTNHbvtUzCcBIUDGeAY1c+7Daeugzgccm8iU=; b=ir3iV+FpR5ihGb7ZjCLyswE4VW1FANEI4U/v2rdwa8aISqXmk5q38r+KQ0JMO0LbZT /lTKCg5/ejZ80PSnsOE7eQVIfhSwWp+u5LEV3IbP+V4twHfe9Fjl6RtbHbI2VJIJfWlp 6WKsemMMWTSFf1CX/yxPgGdwmjVzqqS0cuZRrcabJmT1+qDn+cj0BeuwOkBTsdIeYv4i VBgWcxiYKLSi2ql4mlVMdygkYQ+YVWyxigJG3rteOoGT0H+A6+VA50+THbGs+rDOU+c2 7f2GVNVobovUgWGVxfbqdnttt6pPUJ8i5P3qWRq8DcwtOHUNO+Js0Q4++GPOITQTK7sc SR3w== X-Gm-Message-State: AHQUAuYkoJdcwUEfZvUbEzB+MjgtEXjaW3kgK9GtwoOZlGYfnwEMMBT3 XUOS4kilCHSLfehUnn8rhDK97PFxZ5451AGN276RNw== X-Received: by 2002:a81:79d3:: with SMTP id u202mr2247939ywc.56.1549969244337; Tue, 12 Feb 2019 03:00:44 -0800 (PST) MIME-Version: 1.0 References: <20190212100825.9113-1-anders.roxell@linaro.org> In-Reply-To: From: Anders Roxell Date: Tue, 12 Feb 2019 12:00:33 +0100 Message-ID: Subject: Re: [PATCH 1/2] ima: fix build error redeclaration of enumerator To: Andy Shevchenko Cc: Mimi Zohar , Dmitry Kasatkin , James Morris , "Serge E. Hallyn" , Ard Biesheuvel , Thomas Gleixner , Ingo Molnar , Borislav Petkov , linux-integrity , linux-security-module , Linux Kernel Mailing List , "maintainer:X86 ARCHITECTURE (32-BIT AND 64-BIT)" , linux-efi , Platform Driver Content-Type: text/plain; charset="UTF-8" Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, 12 Feb 2019 at 11:23, Andy Shevchenko wrote: > > On Tue, Feb 12, 2019 at 12:21 PM Andy Shevchenko > wrote: > > > > On Tue, Feb 12, 2019 at 12:15 PM Anders Roxell wrote: > > > > > > Commit a893ea15d764 ("tpm: move tpm_chip definition to > > > include/linux/tpm.h") introduced a build error when both ima and efi is > > > enabled. What happens is that both headers (ima.h and efi.h) defines the > > > same 'NONE' constant, and it broke when they started getting included > > > from the same file. > > > > > We only need one of the two patches applied. > > > > I would argue that we need two patches applied. Namespace is a hidden > > issue in the code. > > > > This patch looks good to me, FWIW, > > Reviewed-by: Andy Shevchenko > > Oh, did you change ABI? So, I have to say that enum changes are okay, > but ABI, if any, are not. urgh, thank you for the review. It looks like I changed a bit too much in ima_parse_rule() =/ I'll send send out a v2 shortly. Cheers, Anders