Received: by 2002:ac0:946b:0:0:0:0:0 with SMTP id j40csp3718696imj; Tue, 12 Feb 2019 03:33:48 -0800 (PST) X-Google-Smtp-Source: AHgI3IZ1G+xrNi4tcOksqIAaS0acX8553RpLUSJsr2f1cuFoMdaSzSKg5C24u5QHbV8qLCrh4POF X-Received: by 2002:a17:902:bd4a:: with SMTP id b10mr3614336plx.232.1549971228238; Tue, 12 Feb 2019 03:33:48 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1549971228; cv=none; d=google.com; s=arc-20160816; b=CGKcQY9CKC8T3+/3FxawJGGkjsdPm0N7X8/xMfqP56gfhQaUImgjO80YBsdDyb2bVV 0FH6TAHR0BI+8KHF269cCLj+AeBYaWbLV53g8rBjDmfGWEEXh0Zqk2aISViVwpy71NnP +J4PQK5O68FZXGV9vcqxbmjOtvlxbctQFKsEyNVrjnK2nzEv0u2C6NPr6ydxrX25mxi0 XdBleKpfPL25KLGjaBcy2sjVj7Xr2NDqj8V86B5yM6zZ4RWnkBkLG+gJAGk+4QsLf6gV Wmh8b6KhqV1Av2b0WOrwF5CdVGRgW5DaO/nHmm6BD3FRSSEA1z97a/DVlQ3adWatp5KR 5F9Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:mime-version:content-transfer-encoding :content-id:content-language:accept-language:in-reply-to:references :message-id:date:thread-index:thread-topic:subject:cc:to:from :dkim-signature; bh=EQYVA43IDhME/ZzOTYQiEtsAAQ57YZJm/IgFCRGqlS8=; b=zSfXIlpJc3K2j+VB516r8p8BT8wx+ouPaNvcSTzE9zw38QYvzs4jgusKk0t0UoIZAL WAoe+JRJ/cDGtum0NJqfvI6/KG4q5635JQC3Ty6R6LKG4dVdcuY8Bkd3SL6gn4InXVpT N+Gvo96Zju0PZagYryah5P7T4lPZzY3/8ubWH1LUjAXbBpl2pgriB5vqjRnM9Xi3TfnY X5TWzZoKZ+l7bjUpqUxZTVPLkyCdMzBUQWF8cswaW/pmKCxQEZFi07x/m+9/cWmaVTOX kr8E/u1f8SeWkITftcHQq4eTtTE7iR+8ceirbkQ2UREXR21Ltjz2uz3k3U49vOTzsDVk x9gg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@Mellanox.com header.s=selector1 header.b=GPOTefjz; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=mellanox.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id f34si6781343ple.279.2019.02.12.03.33.32; Tue, 12 Feb 2019 03:33:48 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@Mellanox.com header.s=selector1 header.b=GPOTefjz; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=mellanox.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728601AbfBLL3r (ORCPT + 99 others); Tue, 12 Feb 2019 06:29:47 -0500 Received: from mail-eopbgr140077.outbound.protection.outlook.com ([40.107.14.77]:31399 "EHLO EUR01-VE1-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1727784AbfBLL3r (ORCPT ); Tue, 12 Feb 2019 06:29:47 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Mellanox.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=EQYVA43IDhME/ZzOTYQiEtsAAQ57YZJm/IgFCRGqlS8=; b=GPOTefjzI3/GKbr3JY4Pib2zSJ3hJc447DXI7NzpUCx7h2D5bhBw6C1gAMi/AFdVr51J/Uv47sTUyqi2IOLn+BrINIVbPMZ8nt9XJPMZLp1Mn1yfA9tP+l8y2BZS09RnMo5d3/EVTl6WQgkM0N3HBCFRKjPUOA0jW5U7DT07REI= Received: from DB6PR0501MB2694.eurprd05.prod.outlook.com (10.172.226.9) by DB6PR0501MB2166.eurprd05.prod.outlook.com (10.168.55.22) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.1601.21; Tue, 12 Feb 2019 11:29:43 +0000 Received: from DB6PR0501MB2694.eurprd05.prod.outlook.com ([fe80::ed9e:f27:4597:6db2]) by DB6PR0501MB2694.eurprd05.prod.outlook.com ([fe80::ed9e:f27:4597:6db2%10]) with mapi id 15.20.1601.023; Tue, 12 Feb 2019 11:29:43 +0000 From: Leon Romanovsky To: Colin King CC: Lijun Ou , Wei Hu , Doug Ledford , Jason Gunthorpe , "linux-rdma@vger.kernel.org" , "kernel-janitors@vger.kernel.org" , "linux-kernel@vger.kernel.org" Subject: Re: [PATCH][next] RDMA: fix allocation failure on pointer pd Thread-Topic: [PATCH][next] RDMA: fix allocation failure on pointer pd Thread-Index: AQHUwsVBJSiLJZH/hUKxowAFF3kinqXcBvEA Date: Tue, 12 Feb 2019 11:29:42 +0000 Message-ID: <20190212112940.GN21447@mtr-leonro.mtl.com> References: <20190212112233.25667-1-colin.king@canonical.com> In-Reply-To: <20190212112233.25667-1-colin.king@canonical.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-clientproxiedby: AM6PR06CA0011.eurprd06.prod.outlook.com (2603:10a6:20b:14::24) To DB6PR0501MB2694.eurprd05.prod.outlook.com (2603:10a6:4:82::9) authentication-results: spf=none (sender IP is ) smtp.mailfrom=leonro@mellanox.com; x-ms-exchange-messagesentrepresentingtype: 1 x-originating-ip: [77.138.135.184] x-ms-publictraffictype: Email x-microsoft-exchange-diagnostics: 1;DB6PR0501MB2166;6:6KcdFS9JboadlRuUzrYzX8uY8EszmbdHNVD3QuoDiCxzwdgMNJnLrGDm9g0GXTcwQqcN5KnlP8cFSiCFE9K+kVhlf54gSLh7cGaz7k1EtvOdsr+eRsPf178EqdfXtQLz2KZK/NaQNPo8pt5pniWCxdrdCkawMxpiMyDKrFTqjnmrxCHOx2TdU6tJ9stE2BNh3VfWF6LaSuIDu24JjKvlZTGX4IHPWRvzpMGd7fPJMBkn/9apuvFUwiK9UJDMJmG0LomGa7Z2NniR7qJqGwBzQ/K45hrEqzqdQPfk40NKT0ALcdqXLWipMej35IgcqCQtsroFOIpxW7NVGfKHPI3tXaz7P4X8A3LCBJ2Gbh0hQh8DJ0LqR6Yzl1xDLTOxSC0DLH01sxdMmpqiOxWeVFCoYXS1MAFEuSfFj3xB4Ou6+bgG2NneU6V1DPwFFrBlSoev72MSid+8R+4L7nDaIidMKg==;5:0q4rrIwjnsj4XjzlH9FSXvYWQOQCgweZgkoijEGF7EpzPNduK92KXngQf0l0nINHmj1/0agOf0GbheG+MO7cYKRsd7BmF2XRfMwuVlThSok/RX1oUdbmK0Q8GEgRefXxlKXBijHAYhVKs2Xp2dKrXNOttM8icmqtMPY5ZSLE75sJmKhWb1vX6n35rsiOEUyMP+SNNr1Zhif9OFSDvEGGxQ==;7:YQEJXiq0lkFeD1grUsYv4F3oq5uT9kZEF5NFSOePb/lhjfLYAmrwEfzCE3u4SxxzkrrYzRCPbVH9hZDf2NuK/3BStwk7vsPD97fx278icn5e7Ecmv/Yf/HZYe6X3A82FEmeBuvzXP/0bmAsR0RQ6iw== x-ms-office365-filtering-correlation-id: 9349b7b0-4532-475a-de27-08d690dd621f x-ms-office365-filtering-ht: Tenant x-microsoft-antispam: BCL:0;PCL:0;RULEID:(2390118)(7020095)(4652040)(8989299)(4534185)(4627221)(201703031133081)(201702281549075)(8990200)(5600110)(711020)(4605077)(4618075)(2017052603328)(7153060)(7193020);SRVR:DB6PR0501MB2166; x-ms-traffictypediagnostic: DB6PR0501MB2166: x-microsoft-antispam-prvs: x-forefront-prvs: 0946DC87A1 x-forefront-antispam-report: SFV:NSPM;SFS:(10009020)(396003)(366004)(39860400002)(376002)(136003)(346002)(189003)(199004)(4326008)(4744005)(6512007)(76176011)(1076003)(99286004)(68736007)(7736002)(52116002)(305945005)(186003)(486006)(11346002)(6436002)(446003)(9686003)(81156014)(256004)(8676002)(26005)(86362001)(476003)(97736004)(14444005)(33896004)(6506007)(386003)(6916009)(102836004)(53936002)(14454004)(33656002)(478600001)(6246003)(66066001)(106356001)(25786009)(81166006)(71200400001)(2906002)(6116002)(3846002)(316002)(54906003)(71190400001)(229853002)(6486002)(8936002)(105586002);DIR:OUT;SFP:1101;SCL:1;SRVR:DB6PR0501MB2166;H:DB6PR0501MB2694.eurprd05.prod.outlook.com;FPR:;SPF:None;LANG:en;PTR:InfoNoRecords;MX:1;A:1; received-spf: None (protection.outlook.com: mellanox.com does not designate permitted sender hosts) x-ms-exchange-senderadcheck: 1 x-microsoft-antispam-message-info: 7pRrsgWbI2DtWUv0XTwUqXH8Po2VuI1+h4cddrywvSglaZXP5Zj4WVftMDAMfG0vSnZvbERSEeXuuk3uVZEiXHQ10IkxDJJBljEMyUI78yvqky15wNSYzGSNObgsCLa1MizhFS/+dWQif4g5vSBfUxrNeWaJULPguuGvaTI35C6p7BLQW2TqmjT6T9c8K9c7yujwiLJqCpsS0cFzGz2mYf8Q7aOu2H4PzRdtaTbSy9S5KrlIj8ZiWAj5FTi2bW9AHb7pkLoJQrnC44EQR3muPnieh1DILLId2bcNmWkY8noEN+5blroUlmxUNWC1UFm3RRlE5xWwgYdw7uBmF5iBwte3g79bEVzalK+ivKQ4jU+eHAfijkdYjuN5qfq6znMKyJW/n9TEs2LwOC1fli/LKF7D5lIu9kYbg19ZmoS3U+s= Content-Type: text/plain; charset="us-ascii" Content-ID: <6973099414FE5A43BD7A7EFBBBFD0477@eurprd05.prod.outlook.com> Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: Mellanox.com X-MS-Exchange-CrossTenant-Network-Message-Id: 9349b7b0-4532-475a-de27-08d690dd621f X-MS-Exchange-CrossTenant-originalarrivaltime: 12 Feb 2019 11:29:42.4388 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-id: a652971c-7d2e-4d9b-a6a4-d149256f461b X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB6PR0501MB2166 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Feb 12, 2019 at 11:22:33AM +0000, Colin King wrote: > From: Colin Ian King > > The null check on an allocation failure on pd is currently checking > if pd is non-null rather than null. Fix this by adding the missing ! > operator. > > Fixes: 21a428a019c9 ("RDMA: Handle PD allocations by IB/core") > Signed-off-by: Colin Ian King > --- > drivers/infiniband/hw/hns/hns_roce_hw_v1.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > Thanks a lot, Reviewed-by: Leon Romanovsky