Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
MIME-Version: 1.0
References: <20190119055625.100054-1-anup@brainfault.org> <20190119055625.100054-3-anup@brainfault.org>
 <20190212070925.GE26747@infradead.org>
In-Reply-To: <20190212070925.GE26747@infradead.org>
From:   Anup Patel <anup@brainfault.org>
Date:   Tue, 12 Feb 2019 17:35:32 +0530
Message-ID: <CAAhSdy310ninVL5PLHhqbv0-WSj9npjMzauQTiRvE-E==XT=Rg@mail.gmail.com>
Subject: Re: [PATCH v5 2/5] irqchip: sifive-plic: Don't inline plic_toggle()
 and plic_irq_toggle()
To:     Christoph Hellwig <hch@infradead.org>
Cc:     Palmer Dabbelt <palmer@sifive.com>,
        Albert Ou <aou@eecs.berkeley.edu>,
        Daniel Lezcano <daniel.lezcano@linaro.org>,
        Thomas Gleixner <tglx@linutronix.de>,
        Jason Cooper <jason@lakedaemon.net>,
        Marc Zyngier <marc.zyngier@arm.com>,
        Atish Patra <atish.patra@wdc.com>,
        linux-riscv@lists.infradead.org,
        "linux-kernel@vger.kernel.org List" <linux-kernel@vger.kernel.org>
Content-Type: text/plain; charset="UTF-8"
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On Tue, Feb 12, 2019 at 12:39 PM Christoph Hellwig <hch@infradead.org> wrote:
>
> On Sat, Jan 19, 2019 at 11:26:22AM +0530, Anup Patel wrote:
> > The plic_toggle() uses raw_spin_lock() and plic_irq_toggle has a
> > for loop so both these functions are not suitable for being inline
> > hence this patch removes the inline keyword.
>
> I still very much disagree.  Very strongly with the above rationale,
> but also (less strongly) with the decision not to inline here.

No issues. I will drop this patch since you "very much disagree".

Regards,
Anup