Received: by 2002:ac0:946b:0:0:0:0:0 with SMTP id j40csp3878845imj; Tue, 12 Feb 2019 06:17:18 -0800 (PST) X-Google-Smtp-Source: AHgI3Ib12xZJDEChE+yzG4wqeayp0WOa5VUDEEZQFUU62WOJysJWuB2043mO+BzWVebUVAwpX+Ra X-Received: by 2002:a62:8d46:: with SMTP id z67mr4112419pfd.249.1549981037997; Tue, 12 Feb 2019 06:17:17 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1549981037; cv=none; d=google.com; s=arc-20160816; b=Hb9RNCjbamFjCRMj3ZsU8mGr73QbGwfy/PTy022YHlQ3ZdQ0DXk2fdzSUWrub23xcG KXkjqRu1vogt+/hr6OIX61nFymSBW31kyKHl0Jn3+DXluRHAVaBHJfH1WyDQZVRMNw/2 5Lkuf8Qd0XkSJcduoJdhPHtRvTeO6lu62xdOUCa2Nz9x85VLpmEwID9hQgNpervI8TvH dfW6uYNiMJTQuv1RXef4vRluFERB1hY++XcTfo8bw+KjN8CnOcavpiw/9+vXdDlpkoR4 olGWSKcqJ1O0LxFA7C9mzNamEvweqrXqZif1Hx52hDn4crU+4JQPf4iFzMem5mml2ykL x2uA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding :content-language:in-reply-to:mime-version:user-agent:date :message-id:autocrypt:openpgp:from:references:cc:to:subject :dkim-signature; bh=kcc3Fzlxp7wGiV7nt8e4w+TbbQN55LWVCLA855+HTI4=; b=EIrWLqB+0m/KEKgtmr4jbOXFoLjoCRxJXMLqUU8APDNP2W3hYUF5ABMxvkPiG9Ediv 9fhlmZWCxz7efw6+m2GVJpbn3nKZRUFXqo3D4cyQVcEEp40eA+thY/z6RAVaenAqoSGp WIS5Q49b3Cf5wabhYucDH7xghkGrtfOJFj9flOxSgJ7NDA2BRtPiUcQhVBbI99v/p5ve B3ea9IaCy9kwlW08GWFDOrnpwvTAmohp7auIV8NEXUu8IMuOc2uXyhaBTzPEKtzRIn8p J1N7Qtstr+4b4iIyDHInHiQ83+YZonjdtmw/Z/Qzqh772GQCXx7od9zx3ZhDu/hzklm6 bsWQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=fail header.i=@gmail.com header.s=20161025 header.b=EVF1tIzN; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=redhat.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id b38si12299590plb.11.2019.02.12.06.16.55; Tue, 12 Feb 2019 06:17:17 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=fail header.i=@gmail.com header.s=20161025 header.b=EVF1tIzN; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=redhat.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1730118AbfBLOQq (ORCPT + 99 others); Tue, 12 Feb 2019 09:16:46 -0500 Received: from mail-wr1-f65.google.com ([209.85.221.65]:36294 "EHLO mail-wr1-f65.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1729954AbfBLOQp (ORCPT ); Tue, 12 Feb 2019 09:16:45 -0500 Received: by mail-wr1-f65.google.com with SMTP id o17so2876183wrw.3; Tue, 12 Feb 2019 06:16:43 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:subject:to:cc:references:from:openpgp:autocrypt:message-id :date:user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=kcc3Fzlxp7wGiV7nt8e4w+TbbQN55LWVCLA855+HTI4=; b=EVF1tIzNKaZRmC6Dw5if0ynOgLqBhxYmFwdxrpq9IHfvES2krlRpffPD3THptLBIZ7 IRZ7QX4PgdAC9pEhYGLT4+Hb8+V+X6LW+jiwPM13qH0rmpEWR0ixsU0v09CuxPA6IwQe HR4XjDBJ0ThAK9GeCYPv5tBei24MYVU9Mobea4ihc4UhaqTweTWMZXCbpIxvuA0G9e3u qnNh3DiG1vAcAOvZySO4XymsUjqI/mlsD+MPO7aXOeWc/ASe+SAXMR4mmW+d3FBH75+6 wEa0GvOjtbCnAVuczp4oMeLyLV5vEQ/GxUUlb5WARyZI4GP4bjFjLTIWcLOOi0kddmtf L7SQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:subject:to:cc:references:from:openpgp :autocrypt:message-id:date:user-agent:mime-version:in-reply-to :content-language:content-transfer-encoding; bh=kcc3Fzlxp7wGiV7nt8e4w+TbbQN55LWVCLA855+HTI4=; b=SGbzes0bwIIskjj6bNxFpU9YjX08TkC7OzhaCMiCZbarQ90lZfBNtBiTd8EhU+8EBN aNvvqOsA7RA/8Qlsj/ElVAtiYRZNWhOd5la4oiDDsuSOfWHdJUV9W5KheWEYYYY/sy48 aZN73qvcN13wICleEtkUMqMpSrF/QpICp7YYEJI7BPTPsU5h/RhlLqj320E28AlciQSJ H+z2aH3FCos9B+Uv5XCkMMvE+tE6I8r6/Hlcds3S8TUHtW0lkUZj3HFEMEup56aGwSSe voNU3WddAY6hRdzE4hpKpHGSsroj1LdZc2C4qlfBMUGGKXb99XhN5rM4/ALSTpmXmzcH h+fg== X-Gm-Message-State: AHQUAuZkLemCYFovmmpEXEK1S2es9oi1oGgeM10uErFa2FfLZiTL48Rk 33QEnWLe/ehA4CIOTGPSEJriVod4 X-Received: by 2002:adf:8b83:: with SMTP id o3mr3212546wra.81.1549981002265; Tue, 12 Feb 2019 06:16:42 -0800 (PST) Received: from ?IPv6:2001:b07:6468:f312:5c98:e2e4:edd5:bef0? ([2001:b07:6468:f312:5c98:e2e4:edd5:bef0]) by smtp.googlemail.com with ESMTPSA id t18sm2329303wmt.35.2019.02.12.06.16.41 (version=TLS1_3 cipher=AEAD-AES128-GCM-SHA256 bits=128/128); Tue, 12 Feb 2019 06:16:41 -0800 (PST) Subject: Re: [PATCH] x86/kvm/nVMX: read from MSR_IA32_VMX_PROCBASED_CTLS2 only when it is available To: Jim Mattson , Vitaly Kuznetsov Cc: kvm list , =?UTF-8?B?UmFkaW0gS3LEjW3DocWZ?= , Sean Christopherson , LKML References: <20190207104214.8142-1-vkuznets@redhat.com> From: Paolo Bonzini Openpgp: preference=signencrypt Autocrypt: addr=pbonzini@redhat.com; keydata= mQHhBFRCcBIBDqDGsz4K0zZun3jh+U6Z9wNGLKQ0kSFyjN38gMqU1SfP+TUNQepFHb/Gc0E2 CxXPkIBTvYY+ZPkoTh5xF9oS1jqI8iRLzouzF8yXs3QjQIZ2SfuCxSVwlV65jotcjD2FTN04 hVopm9llFijNZpVIOGUTqzM4U55sdsCcZUluWM6x4HSOdw5F5Utxfp1wOjD/v92Lrax0hjiX DResHSt48q+8FrZzY+AUbkUS+Jm34qjswdrgsC5uxeVcLkBgWLmov2kMaMROT0YmFY6A3m1S P/kXmHDXxhe23gKb3dgwxUTpENDBGcfEzrzilWueOeUWiOcWuFOed/C3SyijBx3Av/lbCsHU Vx6pMycNTdzU1BuAroB+Y3mNEuW56Yd44jlInzG2UOwt9XjjdKkJZ1g0P9dwptwLEgTEd3Fo UdhAQyRXGYO8oROiuh+RZ1lXp6AQ4ZjoyH8WLfTLf5g1EKCTc4C1sy1vQSdzIRu3rBIjAvnC tGZADei1IExLqB3uzXKzZ1BZ+Z8hnt2og9hb7H0y8diYfEk2w3R7wEr+Ehk5NQsT2MPI2QBd wEv1/Aj1DgUHZAHzG1QN9S8wNWQ6K9DqHZTBnI1hUlkp22zCSHK/6FwUCuYp1zcAEQEAAbQj UGFvbG8gQm9uemluaSA8cGJvbnppbmlAcmVkaGF0LmNvbT6JAg0EEwECACMFAlRCcBICGwMH CwkIBwMCAQYVCAIJCgsEFgIDAQIeAQIXgAAKCRB+FRAMzTZpsbceDp9IIN6BIA0Ol7MoB15E 11kRz/ewzryFY54tQlMnd4xxfH8MTQ/mm9I482YoSwPMdcWFAKnUX6Yo30tbLiNB8hzaHeRj jx12K+ptqYbg+cevgOtbLAlL9kNgLLcsGqC2829jBCUTVeMSZDrzS97ole/YEez2qFpPnTV0 VrRWClWVfYh+JfzpXmgyhbkuwUxNFk421s4Ajp3d8nPPFUGgBG5HOxzkAm7xb1cjAuJ+oi/K CHfkuN+fLZl/u3E/fw7vvOESApLU5o0icVXeakfSz0LsygEnekDbxPnE5af/9FEkXJD5EoYG SEahaEtgNrR4qsyxyAGYgZlS70vkSSYJ+iT2rrwEiDlo31MzRo6Ba2FfHBSJ7lcYdPT7bbk9 AO3hlNMhNdUhoQv7M5HsnqZ6unvSHOKmReNaS9egAGdRN0/GPDWr9wroyJ65ZNQsHl9nXBqE AukZNr5oJO5vxrYiAuuTSd6UI/xFkjtkzltG3mw5ao2bBpk/V/YuePrJsnPFHG7NhizrxttB nTuOSCMo45pfHQ+XYd5K1+Cv/NzZFNWscm5htJ0HznY+oOsZvHTyGz3v91pn51dkRYN0otqr bQ4tlFFuVjArBZcapSIe6NV8C4cEiSS5AQ0EVEJxcwEIAK+nUrsUz3aP2aBjIrX3a1+C+39R nctpNIPcJjFJ/8WafRiwcEuLjbvJ/4kyM6K7pWUIQftl1P8Woxwb5nqL7zEFHh5I+hKS3haO 5pgco//V0tWBGMKinjqntpd4U4Dl299dMBZ4rRbPvmI8rr63sCENxTnHhTECyHdGFpqSzWzy 97rH68uqMpxbUeggVwYkYihZNd8xt1+lf7GWYNEO/QV8ar/qbRPG6PEfiPPHQd/sldGYavmd //o6TQLSJsvJyJDt7KxulnNT8Q2X/OdEuVQsRT5glLaSAeVAABcLAEnNgmCIGkX7TnQF8a6w gHGrZIR9ZCoKvDxAr7RP6mPeS9sAEQEAAYkDEgQYAQIACQUCVEJxcwIbAgEpCRB+FRAMzTZp scBdIAQZAQIABgUCVEJxcwAKCRC/+9JfeMeug/SlCACl7QjRnwHo/VzENWD9G2VpUOd9eRnS DZGQmPo6Mp3Wy8vL7snGFBfRseT9BevXBSkxvtOnUUV2YbyLmolAODqUGzUI8ViF339poOYN i6Ffek0E19IMQ5+CilqJJ2d5ZvRfaq70LA/Ly9jmIwwX4auvXrWl99/2wCkqnWZI+PAepkcX JRD4KY2fsvRi64/aoQmcxTiyyR7q3/52Sqd4EdMfj0niYJV0Xb9nt8G57Dp9v3Ox5JeWZKXS krFqy1qyEIypIrqcMbtXM7LSmiQ8aJRM4ZHYbvgjChJKR4PsKNQZQlMWGUJO4nVFSkrixc9R Z49uIqQK3b3ENB1QkcdMg9cxsB0Onih8zR+Wp1uDZXnz1ekto+EivLQLqvTjCCwLxxJafwKI bqhQ+hGR9jF34EFur5eWt9jJGloEPVv0GgQflQaE+rRGe+3f5ZDgRe5Y/EJVNhBhKcafcbP8 MzmLRh3UDnYDwaeguYmxuSlMdjFL96YfhRBXs8tUw6SO9jtCgBvoOIBDCxxAJjShY4KIvEpK b2hSNr8KxzelKKlSXMtB1bbHbQxiQcerAipYiChUHq1raFc3V0eOyCXK205rLtknJHhM5pfG 6taABGAMvJgm/MrVILIxvBuERj1FRgcgoXtiBmLEJSb7akcrRlqe3MoPTntSTNvNzAJmfWhd SvP0G1WDLolqvX0OtKMppI91AWVu72f1kolJg43wbaKpRJg1GMkKEI3H+jrrlTBrNl/8e20m TElPRDKzPiowmXeZqFSS1A6Azv0TJoo9as+lWF+P4zCXt40+Zhh5hdHO38EV7vFAVG3iuay6 7ToF8Uy7tgc3mdH98WQSmHcn/H5PFYk3xTP3KHB7b0FZPdFPQXBZb9+tJeZBi9gMqcjMch+Y R8dmTcQRQX14bm5nXlBF7VpSOPZMR392LY7wzAvRdhz7aeIUkdO7VelaspFk2nT7wOj1Y6uL nRxQlLkBDQRUQnHuAQgAx4dxXO6/Zun0eVYOnr5GRl76+2UrAAemVv9Yfn2PbDIbxXqLff7o yVJIkw4WdhQIIvvtu5zH24iYjmdfbg8iWpP7NqxUQRUZJEWbx2CRwkMHtOmzQiQ2tSLjKh/c HeyFH68xjeLcinR7jXMrHQK+UCEw6jqi1oeZzGvfmxarUmS0uRuffAb589AJW50kkQK9VD/9 QC2FJISSUDnRC0PawGSZDXhmvITJMdD4TjYrePYhSY4uuIV02v028TVAaYbIhxvDY0hUQE4r 8ZbGRLn52bEzaIPgl1p/adKfeOUeMReg/CkyzQpmyB1TSk8lDMxQzCYHXAzwnGi8WU9iuE1P 0wARAQABiQHzBBgBAgAJBQJUQnHuAhsMAAoJEH4VEAzNNmmxp1EOoJy0uZggJm7gZKeJ7iUp eX4eqUtqelUw6gU2daz2hE/jsxsTbC/w5piHmk1H1VWDKEM4bQBTuiJ0bfo55SWsUNN+c9hh IX+Y8LEe22izK3w7mRpvGcg+/ZRG4DEMHLP6JVsv5GMpoYwYOmHnplOzCXHvmdlW0i6SrMsB Dl9rw4AtIa6bRwWLim1lQ6EM3PWifPrWSUPrPcw4OLSwFk0CPqC4HYv/7ZnASVkR5EERFF3+ 6iaaVi5OgBd81F1TCvCX2BEyIDRZLJNvX3TOd5FEN+lIrl26xecz876SvcOb5SL5SKg9/rCB ufdPSjojkGFWGziHiFaYhbuI2E+NfWLJtd+ZvWAAV+O0d8vFFSvriy9enJ8kxJwhC0ECbSKF Y+W1eTIhMD3aeAKY90drozWEyHhENf4l/V+Ja5vOnW+gCDQkGt2Y1lJAPPSIqZKvHzGShdh8 DduC0U3xYkfbGAUvbxeepjgzp0uEnBXfPTy09JGpgWbg0w91GyfT/ujKaGd4vxG2Ei+MMNDm S1SMx7wu0evvQ5kT9NPzyq8R2GIhVSiAd2jioGuTjX6AZCFv3ToO53DliFMkVTecLptsXaes uUHgL9dKIfvpm+rNXRn9wAwGjk0X/A== Message-ID: <9cbc28ac-77bb-5507-d82c-d63d3941a2c7@redhat.com> Date: Tue, 12 Feb 2019 15:16:41 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.4.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 07/02/19 22:17, Jim Mattson wrote: >> SDM says MSR_IA32_VMX_PROCBASED_CTLS2 is only available "If >> (CPUID.01H:ECX.[5] && IA32_VMX_PROCBASED_CTLS[63])". It was found that >> some old cpus (namely "Intel(R) Core(TM)2 CPU 6600 @ 2.40GHz (family: 0x6, >> model: 0xf, stepping: 0x6") don't have it. Add the missing check. >> >> Reported-by: Zdenek Kaspar >> Tested-by: Zdenek Kaspar >> Signed-off-by: Vitaly Kuznetsov > > Reviewed-by: Jim Mattson Queued, thanks. Paolo