Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Subject: Re: [PATCH] mei: expand minor range when registering chrdev region
To:     Greg KH <gregkh@linuxfoundation.org>
Cc:     tomas.winkler@intel.com, arnd@arndb.de,
        linux-kernel@vger.kernel.org
References: <20190212060252.8948-1-cgxu519@gmx.com>
 <20190212092902.GD27450@kroah.com>
From:   cgxu519 <cgxu519@gmx.com>
Message-ID: <03e93235-9fc8-dbc5-49e4-45be8e715398@gmx.com>
Date:   Tue, 12 Feb 2019 22:55:03 +0800
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101
 Thunderbird/60.4.0
MIME-Version: 1.0
In-Reply-To: <20190212092902.GD27450@kroah.com>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Transfer-Encoding: 7bit
Content-Language: en-US
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On 2/12/19 5:29 PM, Greg KH wrote:
> On Tue, Feb 12, 2019 at 02:02:52PM +0800, Chengguang Xu wrote:
>> Actually, total amount of available minor number
>> for a single major is MINORMARK + 1. So expand
>> minor range when registering chrdev region.
>>
>> Signed-off-by: Chengguang Xu <cgxu519@gmx.com>
>> ---
>>   drivers/misc/mei/main.c | 2 +-
>>   1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/drivers/misc/mei/main.c b/drivers/misc/mei/main.c
>> index 87281b3695e6..3df54f1e1a8b 100644
>> --- a/drivers/misc/mei/main.c
>> +++ b/drivers/misc/mei/main.c
>> @@ -869,7 +869,7 @@ static const struct file_operations mei_fops = {
>>   
>>   static struct class *mei_class;
>>   static dev_t mei_devt;
>> -#define MEI_MAX_DEVS  MINORMASK
>> +#define MEI_MAX_DEVS  (MINORMASK + 1)
> Why is this needed?  Have you really run out of that many minor nodes
> for this driver?

Not really, practically maybe we cannot reach to the limit.
I was just curious why only one minor number left there and assumed
that was from a mistake(since I've seen similar mistake in other driver).
However, if it explicitly sets to MINORMASK for some reasons, then it's
better to keep as is.

Thanks