Received: by 2002:ac0:946b:0:0:0:0:0 with SMTP id j40csp3953231imj; Tue, 12 Feb 2019 07:25:43 -0800 (PST) X-Google-Smtp-Source: AHgI3Ia02dgJLtbtHSN0CyI0nCoo0+Gy9cJiF7ESaYYq/A8HeOPF3j7Srrcv/7+IO8Ir4ubRwgm1 X-Received: by 2002:a17:902:3143:: with SMTP id w61mr4625354plb.253.1549985143836; Tue, 12 Feb 2019 07:25:43 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1549985143; cv=none; d=google.com; s=arc-20160816; b=DN644zS6OKvZyHivIR60Qzf2Pz+WtNx3uHBeQsnP5DprcA2iDR3dk83oVxqzrOygn2 0SDiFAaGTl9CcSRXSrVuJM/6yKv8FUScF2IpVo7FKRYX8F4/AQ0EANJ0M+dxrM6kK2Lv fp2zJcEN3Se8pp/YVlOB4mvK/yjF2vqyq+ukfmOLnH51ZfudxJG9ocPFk3/kWaaF2bED KLXPCMexXvq/t7LXG70gzD59i3wO1W/J9yl4qWbYPijdG9dXHyKktgVCy8oVSrzXEJ6E vY0T9WKSDrPCPYtWz55T/bvSng8DlDLbURHOoKrehHHbDKi3dG754LHD1EjJU1YKpBjB vE/A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:mime-version:message-id:date:subject:cc :to:from; bh=zKyjvRPirs0hXlT0btyxg7ZrF26O9Dtch0J1YCjWh3U=; b=nWXOykBXwnZwElzBtH0a7cfZhWsqbXUjqnds4SvVRrIIKyI1aiNA11Pkq2AJTpJDHQ XlRkHw6RGwOjp4Qc3DqZP5xyYamUvB6AULvINw+UY0nAedMAUkXcS710dLWEidCC/2Fb N4HZ6a283HkD5M7Z554pNSVE/qcxGPubwHJwDsbvWw613x+t9gosgmsmyGs4e3QZvUzX d+PRc05W3kWtx+XLTYiGCVQqDsapDqJKNOS54WdL9u7oOiixxclmjE9paPgrMkcL0Y4S DF5hG7rLBlkoj4F5JR5VCzHMMdnb074W8pJjZh/wA+DtG0yyRhfe7+vLtqCR/28cu1/K WvFg== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id s12si1184825pfm.242.2019.02.12.07.25.27; Tue, 12 Feb 2019 07:25:43 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1730048AbfBLPY6 (ORCPT + 99 others); Tue, 12 Feb 2019 10:24:58 -0500 Received: from mx08-00178001.pphosted.com ([91.207.212.93]:47061 "EHLO mx07-00178001.pphosted.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1728273AbfBLPY5 (ORCPT ); Tue, 12 Feb 2019 10:24:57 -0500 Received: from pps.filterd (m0046661.ppops.net [127.0.0.1]) by mx08-00178001.pphosted.com (8.16.0.27/8.16.0.27) with SMTP id x1CFGUq1031812; Tue, 12 Feb 2019 16:24:41 +0100 Received: from beta.dmz-eu.st.com (beta.dmz-eu.st.com [164.129.1.35]) by mx08-00178001.pphosted.com with ESMTP id 2qjfy65jx9-1 (version=TLSv1 cipher=ECDHE-RSA-AES256-SHA bits=256 verify=NOT); Tue, 12 Feb 2019 16:24:41 +0100 Received: from zeta.dmz-eu.st.com (zeta.dmz-eu.st.com [164.129.230.9]) by beta.dmz-eu.st.com (STMicroelectronics) with ESMTP id 6020D34; Tue, 12 Feb 2019 15:24:40 +0000 (GMT) Received: from Webmail-eu.st.com (sfhdag4node2.st.com [10.75.127.11]) by zeta.dmz-eu.st.com (STMicroelectronics) with ESMTP id 3CA385459; Tue, 12 Feb 2019 15:24:40 +0000 (GMT) Received: from localhost (10.75.127.45) by SFHDAG4NODE2.st.com (10.75.127.11) with Microsoft SMTP Server (TLS) id 15.0.1347.2; Tue, 12 Feb 2019 16:24:39 +0100 From: To: Michael Turquette , Stephen Boyd , Maxime Coquelin , Alexandre Torgue CC: , , , , Gabriel Fernandez Subject: [PATCH] Input: st-keyscan - fix potential zalloc NULL dereference Date: Tue, 12 Feb 2019 16:24:29 +0100 Message-ID: <20190212152429.1936-1-gabriel.fernandez@st.com> X-Mailer: git-send-email 2.17.0 MIME-Version: 1.0 Content-Type: text/plain X-Originating-IP: [10.75.127.45] X-ClientProxiedBy: SFHDAG5NODE1.st.com (10.75.127.13) To SFHDAG4NODE2.st.com (10.75.127.11) X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:,, definitions=2019-02-12_08:,, signatures=0 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Gabriel Fernandez This patch fixes the following static checker warning: drivers/input/keyboard/st-keyscan.c:156 keyscan_probe() error: potential zalloc NULL dereference: 'keypad_data->input_dev' Reported-by: Dan Carpenter Signed-off-by: Gabriel Fernandez --- drivers/input/keyboard/st-keyscan.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/input/keyboard/st-keyscan.c b/drivers/input/keyboard/st-keyscan.c index babcfb165e4f..3b85631fde91 100644 --- a/drivers/input/keyboard/st-keyscan.c +++ b/drivers/input/keyboard/st-keyscan.c @@ -153,6 +153,8 @@ static int keyscan_probe(struct platform_device *pdev) input_dev->id.bustype = BUS_HOST; + keypad_data->input_dev = input_dev; + error = keypad_matrix_key_parse_dt(keypad_data); if (error) return error; @@ -168,8 +170,6 @@ static int keyscan_probe(struct platform_device *pdev) input_set_drvdata(input_dev, keypad_data); - keypad_data->input_dev = input_dev; - res = platform_get_resource(pdev, IORESOURCE_MEM, 0); keypad_data->base = devm_ioremap_resource(&pdev->dev, res); if (IS_ERR(keypad_data->base)) -- 2.17.0