Received: by 2002:ac0:946b:0:0:0:0:0 with SMTP id j40csp4082894imj; Tue, 12 Feb 2019 09:28:33 -0800 (PST) X-Google-Smtp-Source: AHgI3IZfQD/fNP8XfeZIjix4iODaSp2AAXUgqGownD9iWzHrBaC0HvZRXJUX0GPaS+9lv5YqvpLp X-Received: by 2002:a17:902:7592:: with SMTP id j18mr4958393pll.289.1549992512996; Tue, 12 Feb 2019 09:28:32 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1549992512; cv=none; d=google.com; s=arc-20160816; b=WyIyO1ftKH5bwrmSiqOUpsB/9N/kXkX7Zn/qmr0C2toCGeLUUdRTu1BB4LenV+U8Bd yKDMnFuFuPSkf9wI4mvC56GrxY3VzMjRgdX0IZrE/n9O9f1Vi8dkjcbMS1Fdfd6dQe6g NhX2WC64d/9Q5RrLtDvyK+qBJy0QtnH1obzzIqDTkeHEQYF9a0Bf8toAnTk1cITQPPOP K0HKjsORAhJIuUEeCxFO3JPiv9zOOYAJvMcCMdtR36ZXemJfsRZ6XgOCYAuhLvN7rawJ nJknaA9CJCJIgjne7kc6rjYjo+ATUyt9SIi0kx55lB0TfmVjoykxHGPnAlZq8jhVa85/ D5uw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:mime-version:user-agent:message-id :in-reply-to:date:references:organization:from:subject:cc:to :dkim-signature; bh=3d7aRkfIc/8qoA7b3ZFbgX2IeFUVd3mE9T+3hDqpLOg=; b=JHpKiPyQrAugd6Cufb4p3nN0LZE3/JRWnpN2+gYRcs9ilrRKvVhoUhKJRN8SlukGQi flD11x3E83WZtb3gnGAyCVQv1QpTpMoeB5UOzQraazJZK936qePnrLnwJvD6KTnyt0oJ Zm31KqCG0+5Qw4az2e2Fva1y2Vxu6SPEemkzE/kjsu+cliEFBwWnbfyiZZLoSoCUiK4Q cc5Nlxlb0yl87xXWRtUJ4q2m1rIUL+L13VS3ZPXcuSirbLHm9ghQ3af1nMbaifGkxYOD WYRRXEwbcGlJ2Y0NU6D5kGwCMfBUP4+laUTbvKXjjUSwkbZeJmwRQZwDTtHWC4h1RxkO esiA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@oracle.com header.s=corp-2018-07-02 header.b=mguxkzXo; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=oracle.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id s80si3639392pfa.130.2019.02.12.09.28.16; Tue, 12 Feb 2019 09:28:32 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@oracle.com header.s=corp-2018-07-02 header.b=mguxkzXo; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=oracle.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729167AbfBLQ7j (ORCPT + 99 others); Tue, 12 Feb 2019 11:59:39 -0500 Received: from userp2130.oracle.com ([156.151.31.86]:45774 "EHLO userp2130.oracle.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727348AbfBLQ7j (ORCPT ); Tue, 12 Feb 2019 11:59:39 -0500 Received: from pps.filterd (userp2130.oracle.com [127.0.0.1]) by userp2130.oracle.com (8.16.0.27/8.16.0.27) with SMTP id x1CGsNl4155634; Tue, 12 Feb 2019 16:59:32 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.com; h=to : cc : subject : from : references : date : in-reply-to : message-id : mime-version : content-type; s=corp-2018-07-02; bh=3d7aRkfIc/8qoA7b3ZFbgX2IeFUVd3mE9T+3hDqpLOg=; b=mguxkzXo46FaMgMUbG0+fSF9fAGJe7NoUNaQU5u2JYzHcHPIaUtLqiVrGzmr4euXzP+4 ypTZqRyhscztpShps2C9QrzeD15hxUbhURuOLtMjhxu3mA50SwEU/4VaGf1WBYjMRsy9 EvFa77+AXXur7sERvPsTYks+a/aRrHmJT0Bmru0Uz3ak8E45ZhA9PA4LWfhx8bm9OgVN TlGjbevX7HDVLSSd8Zx0rg2iCzlrFIKMB6hu8HPBF+Udw7sycZ/WVMEgKr9C7SaVFgwh PMgVDmF49hp75F6bbGhYccoHzUxSGNES+nWyZsC5iqVtY05tJMaxATVLOsQJxik75mp4 0Q== Received: from aserv0022.oracle.com (aserv0022.oracle.com [141.146.126.234]) by userp2130.oracle.com with ESMTP id 2qhrekd728-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Tue, 12 Feb 2019 16:59:32 +0000 Received: from aserv0122.oracle.com (aserv0122.oracle.com [141.146.126.236]) by aserv0022.oracle.com (8.14.4/8.14.4) with ESMTP id x1CGxVwL012693 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Tue, 12 Feb 2019 16:59:31 GMT Received: from abhmp0019.oracle.com (abhmp0019.oracle.com [141.146.116.25]) by aserv0122.oracle.com (8.14.4/8.14.4) with ESMTP id x1CGxU7M030199; Tue, 12 Feb 2019 16:59:30 GMT Received: from ca-mkp.ca.oracle.com (/10.159.214.123) by default (Oracle Beehive Gateway v4.0) with ESMTP ; Tue, 12 Feb 2019 08:59:30 -0800 To: Jens Axboe Cc: James Bottomley , linux-scsi , Xuewei Zhang , linux-block@vger.kernel.org, linux-kernel@vger.kernel.org, Mikael Pettersson Subject: Re: [PATCH] scsi: sd: fix entropy gathering for most rotational disks From: "Martin K. Petersen" Organization: Oracle Corporation References: <1549987525.3173.17.camel@HansenPartnership.com> Date: Tue, 12 Feb 2019 11:59:27 -0500 In-Reply-To: (Jens Axboe's message of "Tue, 12 Feb 2019 09:06:29 -0700") Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Proofpoint-Virus-Version: vendor=nai engine=5900 definitions=9165 signatures=668683 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 priorityscore=1501 malwarescore=0 suspectscore=0 phishscore=0 bulkscore=0 spamscore=0 clxscore=1011 lowpriorityscore=0 mlxscore=0 impostorscore=0 mlxlogscore=581 adultscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.0.1-1810050000 definitions=main-1902120120 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Jens, >> The fix is to set the non-rotational and add-randomness flags >> unconditionally early on in the disk initialization path, so they can >> be reset only if the device actually reports being non-rotational via >> the VPD page. > > Reviewed-by: Jens Axboe Yeah, this looks good to me. I'll queue it up for fixes. -- Martin K. Petersen Oracle Linux Engineering