Received: by 2002:ac0:946b:0:0:0:0:0 with SMTP id j40csp4103925imj; Tue, 12 Feb 2019 09:50:06 -0800 (PST) X-Google-Smtp-Source: AHgI3IbWpUvMlPV6ZgYQuKxlqJGhn6bRc0FsvRKuuyjzUQYs0EuHACMBKla7aI8oj5NV6iYi2PYd X-Received: by 2002:a63:d052:: with SMTP id s18mr4599167pgi.11.1549993806778; Tue, 12 Feb 2019 09:50:06 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1549993806; cv=none; d=google.com; s=arc-20160816; b=PlwiA/Sl6Wc8J1hDBHxQ/9VQ33J3pjP5QGWajIy6/aysyO1S+a1dZExLINxfvmbOtQ ciuYIQGffjgEmBz5lfZ6DjNEuXbvFECAtmxAm0nUeIV9OZ7Vofc27/PRirzz72AZFv6G 3bd6KSv/PKhS39gmQIndrXsZj8ZGJk2RFA5wifxaNg1rDLM+RYTF+n1oj87ZrODs2r58 eO2Ok+DjfdyqPoDLtqozn4SKcschcZIbzpPYqITztvw6KTa81UUCQOscUj0rUSKDDIDJ W1SenFkhZOkZx1e+OCJfPR0tW8AU70JP8soiXKmZ7bBTXYjBl2M1xZYgPYE8RYyETY+F sm6A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:mime-version:content-transfer-encoding :content-language:accept-language:references:message-id:date :thread-index:thread-topic:subject:cc:to:from:dkim-signature; bh=mijQDKKR1kpHK8koYtF6HwS0jcOGw6HfTfVDcIcOdJs=; b=A7PW/yZqhmCXpVuuHVRaAKA5IyuPv2Pk9u1cCYejaZowqB63P5fERp7ftp8Cy9+tNo jljLJPM5h9o162UXgV3sQrLm3/njQaQz4W7KFAb5N1MF6s0nZ0MYhN2je3lm36ZjmEcB bjcwCXkyvoeOEQ3MzRBTPbUv2jMIKGwD+2ndqkwDSG4NJzaHIJKRD8zi/AlLXEs2ji4w fteDyc904fkSUGkRbx6gxBvmhPFQ/wckWH8bA6AvG4w+eXOVvK3rgZJJHTh8jZ43HsXy vL7pWFJQHBQAnBewhiRg3gOqk6y4QrNyZzqpNTkXJ6wCQjFJcBnH26ZKsiOjHqhgJoNj 9QnA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@synopsys.com header.s=mail header.b=aD1hLkwW; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=synopsys.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id z5si12339587pgu.19.2019.02.12.09.49.50; Tue, 12 Feb 2019 09:50:06 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@synopsys.com header.s=mail header.b=aD1hLkwW; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=synopsys.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1731733AbfBLReR (ORCPT + 99 others); Tue, 12 Feb 2019 12:34:17 -0500 Received: from us01smtprelay-2.synopsys.com ([198.182.47.9]:34252 "EHLO smtprelay.synopsys.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1731314AbfBLReR (ORCPT ); Tue, 12 Feb 2019 12:34:17 -0500 Received: from mailhost.synopsys.com (dc8-mailhost1.synopsys.com [10.13.135.209]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtprelay.synopsys.com (Postfix) with ESMTPS id 052EF24E1161; Tue, 12 Feb 2019 09:34:17 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=synopsys.com; s=mail; t=1549992857; bh=vg1TPQfWdsxJZpZWI17rvpr8eGcvlcDHMvdEafPNt9A=; h=From:To:CC:Subject:Date:References:From; b=aD1hLkwWsNobGr09/UW81UmyAutpA+p0zBZkd2TC+HeHbQKd0o2r9kl8/A8Xo5MLJ xQ3CzH91vaaJ/wmP1qUXC+P3XFSOdIeABljOC5IkgIm9edUkZNw9E6qbjQaCyWNAVn 448+lKCZQVvT9yubwuzpnTDK456KDgWBSTxBUOZznWepCXyO9aQfXNL+ZhR2YTDu7Q dCJ36xF26opqieZyFZr6gyl/QvvL3rl3zfILrrpbSUizGUCM1LGjYNbO4za/Zvpn1l kztT0vEEJR8rOfWLHNczSV7oyfErMvPoFajwexrO0ZQj/xd8OJ2JMUNvAAH9ZybYFl Jv0QzfFIVvLoQ== Received: from US01WEHTC2.internal.synopsys.com (us01wehtc2.internal.synopsys.com [10.12.239.237]) (using TLSv1.2 with cipher AES128-SHA256 (128/128 bits)) (No client certificate requested) by mailhost.synopsys.com (Postfix) with ESMTPS id 642A1A005A; Tue, 12 Feb 2019 17:34:16 +0000 (UTC) Received: from US01WEMBX2.internal.synopsys.com ([fe80::e4b6:5520:9c0d:250b]) by US01WEHTC2.internal.synopsys.com ([10.12.239.237]) with mapi id 14.03.0415.000; Tue, 12 Feb 2019 09:34:14 -0800 From: Vineet Gupta To: Eugeniy Paltsev , "Eugeniy.Paltsev@synopsys.com" , "linux-snps-arc@lists.infradead.org" CC: "linux-kernel@vger.kernel.org" , "Alexey Brodkin" , "khilman@baylibre.com" , "clabbe@baylibre.com" Subject: Re: [PATCH 1/2] ARC: U-boot: check arguments paranoidly Thread-Topic: [PATCH 1/2] ARC: U-boot: check arguments paranoidly Thread-Index: AQHUwukx1Fnw5f+naU+WRGyYwF4mHg== Date: Tue, 12 Feb 2019 17:34:13 +0000 Message-ID: References: <20190212153932.28371-1-Eugeniy.Paltsev@synopsys.com> <20190212153932.28371-2-Eugeniy.Paltsev@synopsys.com> <1549992326.27724.98.camel@synopsys.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.144.199.106] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 2/12/19 9:25 AM, Eugeniy Paltsev wrote:=0A= >> This is technically changing the ABI - I think we don't need to enforce = this -=0A= >> keep ignoring this=0A= > I think it's better to add this check:=0A= > * This check doesn't break backward compatibility. ARC U-boot pass zero = to r1=0A= > from the beginnings, I specially checked this. So we doesn't change AB= I,=0A= > we only document it ;) =0A= =0A= OK good.=0A= =0A= > * By adding this check we can cheap and easily minimize problems in JTAG= case.=0A= =0A= Prior to your patch this register was irrelevant - it didn't matter for jta= g or=0A= uboot cause what its value was since it was not being checked at all. Now y= ou=0A= enforce this be 0. Simple reasoning tells me it will likely cause problems,= if=0A= any, but won't reduce them at all. So I'd insist we keep ignoring it even i= f uboot=0A= was zeroing it out. Atleast this leaves the door open any future changes.= =0A=