Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
MIME-Version: 1.0
References: <20190207104214.8142-1-vkuznets@redhat.com> <CALMp9eQXUWjde5_7HNsDN=xx9WeccQ1Hp0_hGOWKd+Sjv4bbfg@mail.gmail.com>
 <9cbc28ac-77bb-5507-d82c-d63d3941a2c7@redhat.com>
In-Reply-To: <9cbc28ac-77bb-5507-d82c-d63d3941a2c7@redhat.com>
From:   Jim Mattson <jmattson@google.com>
Date:   Tue, 12 Feb 2019 10:00:59 -0800
Message-ID: <CALMp9eRV8KmA1KQf3C8GX3p5voBvLMspR-XRSb4BLmZhLKQLKA@mail.gmail.com>
Subject: Re: [PATCH] x86/kvm/nVMX: read from MSR_IA32_VMX_PROCBASED_CTLS2 only
 when it is available
To:     Paolo Bonzini <pbonzini@redhat.com>
Cc:     Vitaly Kuznetsov <vkuznets@redhat.com>,
        kvm list <kvm@vger.kernel.org>,
        =?UTF-8?B?UmFkaW0gS3LEjW3DocWZ?= <rkrcmar@redhat.com>,
        Sean Christopherson <sean.j.christopherson@intel.com>,
        LKML <linux-kernel@vger.kernel.org>
Content-Type: text/plain; charset="UTF-8"
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On Tue, Feb 12, 2019 at 6:16 AM Paolo Bonzini <pbonzini@redhat.com> wrote:
>
> On 07/02/19 22:17, Jim Mattson wrote:
> >> SDM says MSR_IA32_VMX_PROCBASED_CTLS2 is only available "If
> >> (CPUID.01H:ECX.[5] && IA32_VMX_PROCBASED_CTLS[63])". It was found that
> >> some old cpus (namely "Intel(R) Core(TM)2 CPU 6600 @ 2.40GHz (family: 0x6,
> >> model: 0xf, stepping: 0x6") don't have it. Add the missing check.
> >>
> >> Reported-by: Zdenek Kaspar <zkaspar82@gmail.com>
> >> Tested-by: Zdenek Kaspar <zkaspar82@gmail.com>
> >> Signed-off-by: Vitaly Kuznetsov <vkuznets@redhat.com>
> >
> > Reviewed-by: Jim Mattson <jmattson@google.com>
>
> Queued, thanks.
>
> Paolo

Alternatively, rdmsr could be changed to rdmsr_safe.