Received: by 2002:ac0:946b:0:0:0:0:0 with SMTP id j40csp4198330imj; Tue, 12 Feb 2019 11:29:01 -0800 (PST) X-Google-Smtp-Source: AHgI3IZU1Vxq0fKNmnnnehJxB8mbVgK/9W44lNKAKUNJEoMcKTWSkcmdMRWa7JrPZ1iN3i+CO9Gc X-Received: by 2002:aa7:8212:: with SMTP id k18mr5512391pfi.48.1549999741624; Tue, 12 Feb 2019 11:29:01 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1549999741; cv=none; d=google.com; s=arc-20160816; b=W8vrswtXYYiw0syHrURc2pf1qOZY8eR6Ojx2bicukHqfczxo0Crjkc16EFXWDMN1gZ mmNl3mZOBAJEWveCJbFL/+bkmPAGosn14OO+7qRjgiRLh0wURi7hI18XLjX2E65S6pNh nm1T9eObRBHGjVHZ+bUaqpVq7fgvI1v3o4woPyxmcbhQsVYF0Uh8Tk+pqCkeCXwBXoa1 z6hRLg6DqNfLcWcmod1td264oa7T0joKMzGZNNrwZ0yF7PrUWFXCjMCeyHamJfHDIrMj 86TurI1YNYYYQjTNVbRGsQl4R33AX9Gi7GctEG9R7HH8ZHMjFbimB0w094MtkWzaOO9w KDsA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :references:in-reply-to:from:subject:cc:to:message-id:date; bh=PrKA0p92k7n2CLHrbJ8NnP/H+Gf+41Sz+ltGDeaStNI=; b=ye76iSuKvwd8xeq5dPBm7hZvfnEmUdvKTE0bfDkrNnV9T0Db59/A/3vfLHQs0s2n2Z yGvMubqh/tcX5h96NKug9aTfkOon/yv5hVMNhwxeKaCambIbe9Nft66QdYkiXN/bfuQz fn0ixKe/oAyUh3+4JPtLbeVZQWyPSBzDR8CKPla2dmhGbGxtgKPZFJhqszVcnxw+JeyE GzI7BYJz97b8LCEtbF6XTZzKlLHHJjJzuPnQ1P0SuWzwRKZ4jZgs//s8h2oN9cCON8hS K+VXCV7tJvfXGgnmuKKbe6Rz02kgO28VKMuIbCS8CVrS74X2MJm+ZeDfB8p8+GPZyRD5 5wlA== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id d24si409295plr.409.2019.02.12.11.28.45; Tue, 12 Feb 2019 11:29:01 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1731916AbfBLSiX (ORCPT + 99 others); Tue, 12 Feb 2019 13:38:23 -0500 Received: from shards.monkeyblade.net ([23.128.96.9]:56136 "EHLO shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727469AbfBLSiW (ORCPT ); Tue, 12 Feb 2019 13:38:22 -0500 Received: from localhost (96-89-128-221-static.hfc.comcastbusiness.net [96.89.128.221]) (using TLSv1 with cipher AES256-SHA (256/256 bits)) (Client did not present a certificate) (Authenticated sender: davem-davemloft) by shards.monkeyblade.net (Postfix) with ESMTPSA id 9EBCC14C59DA3; Tue, 12 Feb 2019 10:38:21 -0800 (PST) Date: Tue, 12 Feb 2019 10:38:21 -0800 (PST) Message-Id: <20190212.103821.1113180544052186059.davem@davemloft.net> To: kal.conley@dectris.com Cc: willemb@google.com, edumazet@google.com, alexander.h.duyck@intel.com, jeffrey.t.kirsher@intel.com, ktkhai@virtuozzo.com, vincent.whitchurch@axis.com, lirongqing@baidu.com, magnus.karlsson@intel.com, netdev@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v2] net/packet: fix 4gb buffer limit due to overflow check From: David Miller In-Reply-To: <20190210085712.31622-1-kal.conley@dectris.com> References: <20190209.190114.542890373094719579.davem@davemloft.net> <20190210085712.31622-1-kal.conley@dectris.com> X-Mailer: Mew version 6.8 on Emacs 26.1 Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.5.12 (shards.monkeyblade.net [149.20.54.216]); Tue, 12 Feb 2019 10:38:22 -0800 (PST) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Kal Conley Date: Sun, 10 Feb 2019 09:57:11 +0100 > When calculating rb->frames_per_block * req->tp_block_nr the result > can overflow. Check it for overflow without limiting the total buffer > size to UINT_MAX. > > This change fixes support for packet ring buffers >= UINT_MAX. > > Fixes: 8f8d28e4d6d8 ("net/packet: fix overflow in check for tp_frame_nr") > Signed-off-by: Kal Conley > --- > Changes in v2: > - Add Signed-off-by and Fixes tag Applied and queued up for -stable, thanks.