Received: by 2002:ac0:946b:0:0:0:0:0 with SMTP id j40csp4236662imj; Tue, 12 Feb 2019 12:12:00 -0800 (PST) X-Google-Smtp-Source: AHgI3IYod7XzfTaYCTMNBgkKiYwYquUV08WGJI5vXpuUOpEkqhBHujNWz9c4B9hicn4mffainTQq X-Received: by 2002:a17:902:2e01:: with SMTP id q1mr5693428plb.240.1550002319961; Tue, 12 Feb 2019 12:11:59 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1550002319; cv=none; d=google.com; s=arc-20160816; b=0pjduGo9eJqKZLMTHLAXixpCU6mGG5OSEoYtMO9XEvTrZcYBT1xVWL98y1b++6n6Jk yOiGwUnil8HzcBb7wfxoLm02JOZ3man9ISGHlxlYGE9PA8bKWDXqPs7PBrZQcIky4bvm awO4v+at/cPm9vHfRy3VoVDkXVJGuJ1k/LpndBqTXnKoXILXjS13o3ShuX/f/tsGseYC 4st0jL0k6cDl4QLAAqf9YEYecv3KBgNd6IeEGu9iuNZkoFtMNmwHvHHgwPoEtuYe30Ip xkne0GyN1iZjil1zfnaoXGphbFGH3psjoHooICN6bRHFtUsCuGWNO4BxefpMCM16JJhd QF/A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding :content-language:in-reply-to:mime-version:user-agent:date :message-id:from:references:cc:to:subject; bh=5J3BEVMX8I3R6aDWiylH49L5Eh0Yio3E7KsL+Og9pHE=; b=wFHYuK9hC9Wn0fV7p7vC+mt25Z9mrQTytCbsqKzT5eWViUI7eKfb4/DaOy1NypZojJ ff2D+dGJ8UFrHDKXmwi/v+wwYU5h6n+52ZdjWCDrIOVwYdFSgbxvw1bJzuk3IesE6ADq Jp3IR6i2OneeBuPv5GMWlqcWV8PITlQ/dcX6cp8bz2uHQ5Qb5qSuaA/eYBA32xHhdD1z 0LnChZjTQccC1IUyFVyNfxyM2jgpJ8ESuMF/EUrjA6tBmR0p3+jmSuMJJ20yj4HKzjSD yP9ZlIyVrk8xVGemyaSkbIGeZAVc+ucka07FmY0ZShw9qjf2SUd8HwaqSGEqEEEepjFs M9+g== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=redhat.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id i9si1802048pgr.131.2019.02.12.12.11.43; Tue, 12 Feb 2019 12:11:59 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=redhat.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1730861AbfBLUBn (ORCPT + 99 others); Tue, 12 Feb 2019 15:01:43 -0500 Received: from mail-qt1-f193.google.com ([209.85.160.193]:39248 "EHLO mail-qt1-f193.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728438AbfBLUBm (ORCPT ); Tue, 12 Feb 2019 15:01:42 -0500 Received: by mail-qt1-f193.google.com with SMTP id o6so4478440qtk.6 for ; Tue, 12 Feb 2019 12:01:42 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=5J3BEVMX8I3R6aDWiylH49L5Eh0Yio3E7KsL+Og9pHE=; b=FTGRj2/zg0aDbncfgeenjJeItqDh2drHs2MkCwjTtHB6Tm2WsFz87Q+SJ3a//sIZCn 91ay4Ajum2R85riVca9AA8fFPNG41/LxW/dfsH23UkY+3sHlCrcoUH3eJOEL29asFtr3 5D++QCtzIWEh1DKc2clxFgIKXbqZU18p6vBcocLW1TXFm0ns2ztR7UhKU2fzSYJ1quvr a3ru4+yqzk4nZjJgYIxQVlnjmuDU3qv1SRL2m1r5Rz+QgncKS/QRrjcCpqeGOwTzv2S3 UlilXcBFxwWxAyVb8hhAVEQm8hixXscYA4pIZQr+2y7DEuIYA4nPAYIOxAlElBvN2qrD z4Ig== X-Gm-Message-State: AHQUAua6AvMttL1NxZR6xECbU1gxoXZ0Q6XaYIvwzR5aLNOId41LHri7 ywWZorb5NcMh42pjzotWfHycWQ== X-Received: by 2002:ac8:21ce:: with SMTP id 14mr4243520qtz.306.1550001701410; Tue, 12 Feb 2019 12:01:41 -0800 (PST) Received: from ?IPv6:2601:602:9800:dae6::112f? ([2601:602:9800:dae6::112f]) by smtp.gmail.com with ESMTPSA id t123sm14960812qkc.6.2019.02.12.12.01.37 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Tue, 12 Feb 2019 12:01:40 -0800 (PST) Subject: Re: [RFC PATCH v7 05/16] arm64/mm: Add support for XPFO To: Khalid Aziz , Konrad Rzeszutek Wilk Cc: juergh@gmail.com, tycho@tycho.ws, jsteckli@amazon.de, ak@linux.intel.com, torvalds@linux-foundation.org, liran.alon@oracle.com, keescook@google.com, Juerg Haefliger , deepa.srinivasan@oracle.com, chris.hyser@oracle.com, tyhicks@canonical.com, dwmw@amazon.co.uk, andrew.cooper3@citrix.com, jcm@redhat.com, boris.ostrovsky@oracle.com, kanth.ghatraju@oracle.com, joao.m.martins@oracle.com, jmattson@google.com, pradeep.vincent@oracle.com, john.haxby@oracle.com, tglx@linutronix.de, kirill.shutemov@linux.intel.com, hch@lst.de, steven.sistare@oracle.com, kernel-hardening@lists.openwall.com, linux-mm@kvack.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, Tycho Andersen References: <89f03091af87f5ab27bd6cafb032236d5bd81d65.1547153058.git.khalid.aziz@oracle.com> <20190123142410.GC19289@Konrads-MacBook-Pro.local> <4dfba458-1bf6-25ff-df4c-b96a1221cd95@oracle.com> From: Laura Abbott Message-ID: <7497bd44-1fda-e073-ba7f-18a76577b64a@redhat.com> Date: Tue, 12 Feb 2019 12:01:36 -0800 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.4.0 MIME-Version: 1.0 In-Reply-To: <4dfba458-1bf6-25ff-df4c-b96a1221cd95@oracle.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 2/12/19 7:52 AM, Khalid Aziz wrote: > On 1/23/19 7:24 AM, Konrad Rzeszutek Wilk wrote: >> On Thu, Jan 10, 2019 at 02:09:37PM -0700, Khalid Aziz wrote: >>> From: Juerg Haefliger >>> >>> Enable support for eXclusive Page Frame Ownership (XPFO) for arm64 and >>> provide a hook for updating a single kernel page table entry (which is >>> required by the generic XPFO code). >>> >>> v6: use flush_tlb_kernel_range() instead of __flush_tlb_one() >>> >>> CC: linux-arm-kernel@lists.infradead.org >>> Signed-off-by: Juerg Haefliger >>> Signed-off-by: Tycho Andersen >>> Signed-off-by: Khalid Aziz >>> --- >>> arch/arm64/Kconfig | 1 + >>> arch/arm64/mm/Makefile | 2 ++ >>> arch/arm64/mm/xpfo.c | 58 ++++++++++++++++++++++++++++++++++++++++++ >>> 3 files changed, 61 insertions(+) >>> create mode 100644 arch/arm64/mm/xpfo.c >>> >>> diff --git a/arch/arm64/Kconfig b/arch/arm64/Kconfig >>> index ea2ab0330e3a..f0a9c0007d23 100644 >>> --- a/arch/arm64/Kconfig >>> +++ b/arch/arm64/Kconfig >>> @@ -171,6 +171,7 @@ config ARM64 >>> select SWIOTLB >>> select SYSCTL_EXCEPTION_TRACE >>> select THREAD_INFO_IN_TASK >>> + select ARCH_SUPPORTS_XPFO >>> help >>> ARM 64-bit (AArch64) Linux support. >>> >>> diff --git a/arch/arm64/mm/Makefile b/arch/arm64/mm/Makefile >>> index 849c1df3d214..cca3808d9776 100644 >>> --- a/arch/arm64/mm/Makefile >>> +++ b/arch/arm64/mm/Makefile >>> @@ -12,3 +12,5 @@ KASAN_SANITIZE_physaddr.o += n >>> >>> obj-$(CONFIG_KASAN) += kasan_init.o >>> KASAN_SANITIZE_kasan_init.o := n >>> + >>> +obj-$(CONFIG_XPFO) += xpfo.o >>> diff --git a/arch/arm64/mm/xpfo.c b/arch/arm64/mm/xpfo.c >>> new file mode 100644 >>> index 000000000000..678e2be848eb >>> --- /dev/null >>> +++ b/arch/arm64/mm/xpfo.c >>> @@ -0,0 +1,58 @@ >>> +/* >>> + * Copyright (C) 2017 Hewlett Packard Enterprise Development, L.P. >>> + * Copyright (C) 2016 Brown University. All rights reserved. >>> + * >>> + * Authors: >>> + * Juerg Haefliger >>> + * Vasileios P. Kemerlis >>> + * >>> + * This program is free software; you can redistribute it and/or modify it >>> + * under the terms of the GNU General Public License version 2 as published by >>> + * the Free Software Foundation. >>> + */ >>> + >>> +#include >>> +#include >>> + >>> +#include >>> + >>> +/* >>> + * Lookup the page table entry for a virtual address and return a pointer to >>> + * the entry. Based on x86 tree. >>> + */ >>> +static pte_t *lookup_address(unsigned long addr) >>> +{ >>> + pgd_t *pgd; >>> + pud_t *pud; >>> + pmd_t *pmd; >>> + >>> + pgd = pgd_offset_k(addr); >>> + if (pgd_none(*pgd)) >>> + return NULL; >>> + >>> + pud = pud_offset(pgd, addr); >>> + if (pud_none(*pud)) >>> + return NULL; >>> + >>> + pmd = pmd_offset(pud, addr); >>> + if (pmd_none(*pmd)) >>> + return NULL; >>> + >>> + return pte_offset_kernel(pmd, addr); >>> +} >>> + >>> +/* Update a single kernel page table entry */ >>> +inline void set_kpte(void *kaddr, struct page *page, pgprot_t prot) >>> +{ >>> + pte_t *pte = lookup_address((unsigned long)kaddr); >>> + >>> + set_pte(pte, pfn_pte(page_to_pfn(page), prot)); >> >> Thought on the other hand.. what if the page is PMD? Do you really want >> to do this? >> >> What if 'pte' is NULL? >>> +} >>> + >>> +inline void xpfo_flush_kernel_tlb(struct page *page, int order) >>> +{ >>> + unsigned long kaddr = (unsigned long)page_address(page); >>> + unsigned long size = PAGE_SIZE; >>> + >>> + flush_tlb_kernel_range(kaddr, kaddr + (1 << order) * size); >> >> Ditto here. You are assuming it is PTE, but it may be PMD or such. >> Or worts - the lookup_address could be NULL. >> >>> +} >>> -- >>> 2.17.1 >>> > > Hi Konrad, > > This makes sense. x86 version of set_kpte() checks pte for NULL and also > checks if the page is PMD. Now what you said about adding level to > lookup_address() for arm makes more sense. > > Can someone with knowledge of arm64 mmu make recommendations here? > > Thanks, > Khalid > arm64 can't split larger pages and requires everything must be mapped as pages (see [RFC PATCH v7 08/16] arm64/mm: disable section/contiguous mappings if XPFO is enabled) . Any situation where we would get something other than a pte would be a bug. Thanks, Laura