Received: by 2002:ac0:946b:0:0:0:0:0 with SMTP id j40csp4318619imj; Tue, 12 Feb 2019 13:45:42 -0800 (PST) X-Google-Smtp-Source: AHgI3IaKPrC2gs8E6f6V0E11m4+2nBg8lGBEj48sT4b+3tdez4gSEIOZAtuMUpJnGEP0BmuXfHF+ X-Received: by 2002:a17:902:8f91:: with SMTP id z17mr5992607plo.300.1550007942344; Tue, 12 Feb 2019 13:45:42 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1550007942; cv=none; d=google.com; s=arc-20160816; b=aPgb+fdttNydNHp8i+3xuDd4iCAia77euRtituxz85rPnPymm0ZCq6nEYZjo253tee JVzPT7TCkMLIbWCurqvk5oWO7JItjZFiYvpUKO/94PwgOYZ4QWBgb1h7vWcSqxscqO/z 4/+FM81cI7rfXMWj9/Inhtf+/wdzNOWhU1WIBKKCwW2ynauxDPBJ0vHNP0gaQAirsUNB 8PKO2Q8zYoTq2Ox0UhCQw+y1K33SONVFnJSv5FVxhfnJqNLiplUVgadMb0MCtQnr/W/r 1Vx1j2yztsHl2DCe8pILWHRwxvSKVqHk9iKlND24eRBcmwZOmrl/Ci9fouzbWl8GnqsF TDcQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:in-reply-to :content-disposition:mime-version:references:message-id:subject:cc :to:from:date:dkim-signature; bh=9obCINMWSbQx5Z9XA4aTeD2Li1SJweF1UfOgZps0VW8=; b=SUCGFPRhVVYOsHl126L2wZBN+YK7j9r5ZQem27lsVLNatc7otRLJbU8tIpu+GdBxpo ebZvPrjtERDuzWfcMnxDDg9p9g2n2f1Exhh3gezqWydj2Tbo/LPu0kD54MDSqjSaDdgy CPpt/lKKI7Xg02hKoweJW9eUMLB/nhbwh1PKNCZq6bWXwq0Eivn57enQvRMlLo+7BkZ6 PL41NW95fHU5/shKKFksLwaNgmIPBGVHhz5U/cAje43MKH0k7JJgQAKZvMgS7h6f4OHB 0Co/kYEvVD+ZVJfm5aJ4InCyv8vJsUjwyKJN2ox66pwrX9a7fjXDRAjjKBVJFJEp+RGE mu5w== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@ziepe.ca header.s=google header.b="iX/VWox6"; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id f6si13072936pgo.58.2019.02.12.13.45.25; Tue, 12 Feb 2019 13:45:42 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@ziepe.ca header.s=google header.b="iX/VWox6"; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1730329AbfBLU40 (ORCPT + 99 others); Tue, 12 Feb 2019 15:56:26 -0500 Received: from mail-pl1-f196.google.com ([209.85.214.196]:40956 "EHLO mail-pl1-f196.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727977AbfBLU4Z (ORCPT ); Tue, 12 Feb 2019 15:56:25 -0500 Received: by mail-pl1-f196.google.com with SMTP id bj4so35021plb.7 for ; Tue, 12 Feb 2019 12:56:25 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ziepe.ca; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=9obCINMWSbQx5Z9XA4aTeD2Li1SJweF1UfOgZps0VW8=; b=iX/VWox6n763texG9bk7BIhTEUn7Mz7SzHXowBIQoaQ4kO4jf3KAE1fQcKU0XDJLSp t9y+1BbnoL19/5L4HvWfkjhybUxW70ZxYp69QWF+YtXMujgNhHjwE/F90rGxVGw2PrWX s2qEc1BYeIZJ/FumqZlD0NXvzFSIHwd/jAHB/HUFT7rRi1wu1bGBRng7LpVN41AFZnDW /DXKlYobWVJfzneZeS8FUyizl6VYUCqD9fUquQOgf84mQGaTkQL4ogECEgZxLzzcQcjk vFuI7cp1eZPlTZoygpPalZ4C1jgnZFxQfspp8nWCn670+hD2sKpgHya2x7mRRd/KHFo8 vMqQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=9obCINMWSbQx5Z9XA4aTeD2Li1SJweF1UfOgZps0VW8=; b=n5NPRbSLl5d0xtkRbhL/7JmGFIWn+a3HlJYEjrGM1XCWTxFyOEpfnQ4gC2oYfeOGx7 O/S0GCtyuQUsP7uX8LKuQgT+WvP37jqr+PfUe8QNpswdpbnfxu6ixdzsIp8EzYMbhBEd 4jp7+aRvKVdfLqZ1NLOf1IOjXsI2cUnW116KOd2uAoX47vFHEeYJ9nnlK1oSMgpjnevZ VtNgU3hsGiDwZgLa0NIeEmc92RHIRXspXdAQw6MYhGyPwJFofcIXJjDxD3WBTRA8Atec idrfhoPEFsucoKsMjRyXFv7sUNS9/clTGkvv91DafGtI2Cc5i2Lql0YgFikB4Tsgys9m eJuw== X-Gm-Message-State: AHQUAubrpvtSHYwTftvUS5uJHK4m3I4+dx235hljMMPPonObqIYKP+QJ w1ZbQXRIfRmnDrZM9z2/vYimig== X-Received: by 2002:a17:902:9b87:: with SMTP id y7mr5970199plp.336.1550004985210; Tue, 12 Feb 2019 12:56:25 -0800 (PST) Received: from ziepe.ca (S010614cc2056d97f.ed.shawcable.net. [174.3.196.123]) by smtp.gmail.com with ESMTPSA id i74sm28807661pfi.33.2019.02.12.12.56.24 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Tue, 12 Feb 2019 12:56:24 -0800 (PST) Received: from jgg by mlx.ziepe.ca with local (Exim 4.90_1) (envelope-from ) id 1gtf6O-0006qD-0Q; Tue, 12 Feb 2019 13:56:24 -0700 Date: Tue, 12 Feb 2019 13:56:23 -0700 From: Jason Gunthorpe To: Colin King Cc: Leon Romanovsky , Lijun Ou , Wei Hu , Doug Ledford , linux-rdma@vger.kernel.org, kernel-janitors@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH][next] RDMA: fix allocation failure on pointer pd Message-ID: <20190212205623.GA26269@ziepe.ca> References: <20190212112233.25667-1-colin.king@canonical.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20190212112233.25667-1-colin.king@canonical.com> User-Agent: Mutt/1.9.4 (2018-02-28) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Feb 12, 2019 at 11:22:33AM +0000, Colin King wrote: > From: Colin Ian King > > The null check on an allocation failure on pd is currently checking > if pd is non-null rather than null. Fix this by adding the missing ! > operator. > > Fixes: 21a428a019c9 ("RDMA: Handle PD allocations by IB/core") > Signed-off-by: Colin Ian King > Reviewed-by: Leon Romanovsky > --- > drivers/infiniband/hw/hns/hns_roce_hw_v1.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) Thanks applied to for-next Regards, Jason